)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"4bd4c2f2b69628ea5082d30e5c11b9e2964221a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check keypair after rebuild server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When finish to rebuild server,the keypair should be same as before."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id778eb35ac12aba342c8a3b16007b2d2d4a233f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_c47ee8e2","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":22},"updated":"2017-11-03 17:44:09.000000000","message":"finish rebuilding","commit_id":"3e2b3b6f711d60f0c66975314e26a2dcfc776bd1"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"467a7743d6faf7960b9ca043533c4355478ad3fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check keypair after rebuild server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When finish to rebuild server,the keypair should be same as before."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id778eb35ac12aba342c8a3b16007b2d2d4a233f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_e070a942","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":22},"in_reply_to":"3f4b6375_c47ee8e2","updated":"2017-11-03 23:54:17.000000000","message":"Done","commit_id":"3e2b3b6f711d60f0c66975314e26a2dcfc776bd1"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"960edf0f39d560a035c1d277f632d40fdd4026e0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # Get the IPs the server has before rebuilding it"},{"line_number":178,"context_line":"        original_addresses \u003d (self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":179,"context_line":"                              [\u0027addresses\u0027])"},{"line_number":180,"context_line":"        # Get the keypair the server has before rebuilding it"},{"line_number":181,"context_line":"        original_key_name \u003d (self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":182,"context_line":"                             [\u0027key_name\u0027])"},{"line_number":183,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":184,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":185,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_390ba52a","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":42},"updated":"2017-11-03 17:11:28.000000000","message":"We are defining the resize API is\n\nhttps://developer.openstack.org/api-guide/compute/server_concepts.html\n\n Rebuild\n Use this function to remove all data on the server and\n replaces it with the specified image. Server ID and IP\n addresses remain the same.\n\nSo the above IP address check of line 178 is valid from the definition, but I am not sure keypair also should be the same.\nAs the result of this test, maybe it would be fine from POV of current implementation. But I am not sure that is intentional or not.","commit_id":"3e2b3b6f711d60f0c66975314e26a2dcfc776bd1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc64f3b05be8971869b0948a4e4505e90d6fbc85","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # Get the IPs the server has before rebuilding it"},{"line_number":178,"context_line":"        original_addresses \u003d (self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":179,"context_line":"                              [\u0027addresses\u0027])"},{"line_number":180,"context_line":"        # Get the keypair the server has before rebuilding it"},{"line_number":181,"context_line":"        original_key_name \u003d (self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":182,"context_line":"                             [\u0027key_name\u0027])"},{"line_number":183,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":184,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"},{"line_number":185,"context_line":"        new_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-server\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_0159eb58","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":42},"in_reply_to":"3f4b6375_390ba52a","updated":"2017-11-21 02:32:00.000000000","message":"yeah, I am also doubtful about the test criteria. We can\u0027t test something just because it now looks like that. \nIf keypair indeed should not change after rebuild, then better to mention it in the api ref(maybe need some work on nova doc)","commit_id":"3e2b3b6f711d60f0c66975314e26a2dcfc776bd1"}]}
