)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d898b565b35a691abc064d44834a193549078d13","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        if should_succeed:"},{"line_number":905,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"},{"line_number":906,"context_line":"                % (dest, source_host)"},{"line_number":907,"context_line":"            self._log_console_output()"},{"line_number":908,"context_line":"        else:"},{"line_number":909,"context_line":"            msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":910,"context_line":"        self.assertTrue(result, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c9c255e9","line":907,"range":{"start_line":907,"start_character":12,"end_line":907,"end_character":38},"updated":"2017-11-07 02:09:52.000000000","message":"This statement shouldn\u0027t be put here, for it will cause logging console output even if the testcase doesn\u0027t fail.","commit_id":"c49fdf8bd067cd9d746afeedfe694cb184df3c0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"09b99f4748b866060a0d7d910c18fbe3e2ce5246","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        if should_succeed:"},{"line_number":905,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"},{"line_number":906,"context_line":"                % (dest, source_host)"},{"line_number":907,"context_line":"            self._log_console_output()"},{"line_number":908,"context_line":"        else:"},{"line_number":909,"context_line":"            msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":910,"context_line":"        self.assertTrue(result, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_db8a09ba","line":907,"range":{"start_line":907,"start_character":12,"end_line":907,"end_character":38},"in_reply_to":"3f4b6375_c9c255e9","updated":"2017-11-07 17:50:51.000000000","message":"oh right...","commit_id":"c49fdf8bd067cd9d746afeedfe694cb184df3c0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ac9c752a24dd0252dbd893a249a1146c3c58a35","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        if should_succeed:"},{"line_number":905,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"},{"line_number":906,"context_line":"                % (dest, source_host)"},{"line_number":907,"context_line":"            self._log_console_output()"},{"line_number":908,"context_line":"        else:"},{"line_number":909,"context_line":"            msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":910,"context_line":"        self.assertTrue(result, msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a7c84e21","line":907,"range":{"start_line":907,"start_character":12,"end_line":907,"end_character":38},"in_reply_to":"3f4b6375_db8a09ba","updated":"2017-11-07 22:13:31.000000000","message":"Done","commit_id":"c49fdf8bd067cd9d746afeedfe694cb184df3c0b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c533789549304c6a2a455c05f554c92ad7deb42e","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        result \u003d test_utils.call_until_true(ping_remote,"},{"line_number":902,"context_line":"                                            CONF.validation.ping_timeout, 1)"},{"line_number":903,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":904,"context_line":"        if should_succeed:"},{"line_number":905,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"},{"line_number":906,"context_line":"                % (dest, source_host)"},{"line_number":907,"context_line":"        else:"},{"line_number":908,"context_line":"            msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":909,"context_line":"        if not result:"},{"line_number":910,"context_line":"            self._log_console_output()"},{"line_number":911,"context_line":"            self.fail(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_ac59998e","line":908,"range":{"start_line":903,"start_character":0,"end_line":908,"end_character":65},"updated":"2017-11-16 19:57:29.000000000","message":"These lines are used only if result is False, so here should be\n\n if not result:\n     source_host \u003d ...\n     ...\n     self._log_console_output()\n     self.fail(msg)\n\nor just likes\n\n if result:\n     return\n soruce_host \u003d ..\n ...\n self._log_console_output()\n self.fail(msg)\n\nfor the readability.","commit_id":"b504d170da89f4b8bb715d8f472edf13657c52c6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"87ce918735ca02c6793f8b1d59a18ae8c7c8f599","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        result \u003d test_utils.call_until_true(ping_remote,"},{"line_number":902,"context_line":"                                            CONF.validation.ping_timeout, 1)"},{"line_number":903,"context_line":"        source_host \u003d source.ssh_client.host"},{"line_number":904,"context_line":"        if should_succeed:"},{"line_number":905,"context_line":"            msg \u003d \"Timed out waiting for %s to become reachable from %s\" \\"},{"line_number":906,"context_line":"                % (dest, source_host)"},{"line_number":907,"context_line":"        else:"},{"line_number":908,"context_line":"            msg \u003d \"%s is reachable from %s\" % (dest, source_host)"},{"line_number":909,"context_line":"        if not result:"},{"line_number":910,"context_line":"            self._log_console_output()"},{"line_number":911,"context_line":"            self.fail(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_fdbf39a7","line":908,"range":{"start_line":903,"start_character":0,"end_line":908,"end_character":65},"in_reply_to":"1f485f77_ac59998e","updated":"2017-11-16 21:39:59.000000000","message":"Done","commit_id":"b504d170da89f4b8bb715d8f472edf13657c52c6"}],"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d898b565b35a691abc064d44834a193549078d13","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                res \u003d test_utils.call_until_true("},{"line_number":193,"context_line":"                    v6_addr_assigned, CONF.validation.ping_timeout, 1)"},{"line_number":194,"context_line":"                if not res:"},{"line_number":195,"context_line":"                    self._log_console_output()"},{"line_number":196,"context_line":"                    self.fail("},{"line_number":197,"context_line":"                        \u0027Address %s not configured for instance %s\u0027 %"},{"line_number":198,"context_line":"                        (ip, sid))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a93839ed","line":195,"range":{"start_line":195,"start_character":19,"end_line":195,"end_character":46},"updated":"2017-11-07 02:09:52.000000000","message":"better to pass servers parameter, because here only one server\u0027s console output is needed, and get_console_output is a bit time consuming.","commit_id":"c49fdf8bd067cd9d746afeedfe694cb184df3c0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"09b99f4748b866060a0d7d910c18fbe3e2ce5246","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                res \u003d test_utils.call_until_true("},{"line_number":193,"context_line":"                    v6_addr_assigned, CONF.validation.ping_timeout, 1)"},{"line_number":194,"context_line":"                if not res:"},{"line_number":195,"context_line":"                    self._log_console_output()"},{"line_number":196,"context_line":"                    self.fail("},{"line_number":197,"context_line":"                        \u0027Address %s not configured for instance %s\u0027 %"},{"line_number":198,"context_line":"                        (ip, sid))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_7b9c350d","line":195,"range":{"start_line":195,"start_character":19,"end_line":195,"end_character":46},"in_reply_to":"3f4b6375_a93839ed","updated":"2017-11-07 17:50:51.000000000","message":"I don\u0027t have servers in here. I would need to fetch them, or make prepare_server return them (the latter is too disruptive).","commit_id":"c49fdf8bd067cd9d746afeedfe694cb184df3c0b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"467d31dbe92a96d343e546982345696ae6c89d84","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    (srv1, sshv4_1, ips_from_api_1),"},{"line_number":186,"context_line":"                    (srv2, sshv4_2, ips_from_api_2)):"},{"line_number":187,"context_line":"                ip \u003d ips[\u00276\u0027][i]"},{"line_number":188,"context_line":"                res \u003d test_utils.call_until_true("},{"line_number":189,"context_line":"                    guest_has_address,"},{"line_number":190,"context_line":"                    CONF.validation.ping_timeout, 1, ssh, ip)"},{"line_number":191,"context_line":"                if not res:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_aee2c89e","line":188,"range":{"start_line":188,"start_character":16,"end_line":188,"end_character":19},"updated":"2017-11-16 05:06:42.000000000","message":"I\u0027d prefer \"result\", because \"res\" usually refers to \"resource\"","commit_id":"b80483ccec28845fb18a1011df6c8ead60b7ff98"}]}