)]}'
{"tempest/api/identity/admin/v3/test_domains.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"83b5fbf9fd52904969c342d5bc5b3d7b53f639b1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # Create domain"},{"line_number":77,"context_line":"        d_name \u003d data_utils.rand_name(\u0027domain\u0027)"},{"line_number":78,"context_line":"        d_desc \u003d data_utils.rand_name(\u0027domain-desc\u0027)"},{"line_number":79,"context_line":"        domain \u003d self.domains_client.create_domain("},{"line_number":80,"context_line":"            name\u003dd_name, description\u003dd_desc)[\u0027domain\u0027]"},{"line_number":81,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":82,"context_line":"                        self.delete_domain, domain[\u0027id\u0027])"},{"line_number":83,"context_line":"        self.assertIn(\u0027description\u0027, domain)"},{"line_number":84,"context_line":"        self.assertIn(\u0027name\u0027, domain)"},{"line_number":85,"context_line":"        self.assertIn(\u0027enabled\u0027, domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_92689087","line":82,"range":{"start_line":79,"start_character":8,"end_line":82,"end_character":57},"updated":"2017-11-14 08:08:38.000000000","message":"If you add **kwargs to create_domain method in base module, you can then just call:\n\n    self.create_domain(name\u003dd_name, description\u003dd_desc)\n\nand get rid of the clean up.","commit_id":"eed21d7a1c0b3e5620960de9878ac9df0d2907fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"cf5a3f8f9f2ad0e835a8a7e6142d8e6c281e1721","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # Create domain"},{"line_number":77,"context_line":"        d_name \u003d data_utils.rand_name(\u0027domain\u0027)"},{"line_number":78,"context_line":"        d_desc \u003d data_utils.rand_name(\u0027domain-desc\u0027)"},{"line_number":79,"context_line":"        domain \u003d self.domains_client.create_domain("},{"line_number":80,"context_line":"            name\u003dd_name, description\u003dd_desc)[\u0027domain\u0027]"},{"line_number":81,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":82,"context_line":"                        self.delete_domain, domain[\u0027id\u0027])"},{"line_number":83,"context_line":"        self.assertIn(\u0027description\u0027, domain)"},{"line_number":84,"context_line":"        self.assertIn(\u0027name\u0027, domain)"},{"line_number":85,"context_line":"        self.assertIn(\u0027enabled\u0027, domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_6600b968","line":82,"range":{"start_line":79,"start_character":8,"end_line":82,"end_character":57},"in_reply_to":"1f485f77_92689087","updated":"2017-11-14 08:55:38.000000000","message":"Yes, I had thought of that, and I was hesitated because the testcase is for testing \"create domain\", so I just left it as:)","commit_id":"eed21d7a1c0b3e5620960de9878ac9df0d2907fa"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"83b5fbf9fd52904969c342d5bc5b3d7b53f639b1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def test_create_domain_without_description(self):"},{"line_number":132,"context_line":"        # Create domain only with name"},{"line_number":133,"context_line":"        d_name \u003d data_utils.rand_name(\u0027domain\u0027)"},{"line_number":134,"context_line":"        domain \u003d self.domains_client.create_domain(name\u003dd_name)[\u0027domain\u0027]"},{"line_number":135,"context_line":"        self.addCleanup(self.delete_domain, domain[\u0027id\u0027])"},{"line_number":136,"context_line":"        expected_data \u003d {\u0027name\u0027: d_name, \u0027enabled\u0027: True}"},{"line_number":137,"context_line":"        self.assertEqual(\u0027\u0027, domain[\u0027description\u0027])"},{"line_number":138,"context_line":"        self.assertDictContainsSubset(expected_data, domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_720514c2","line":135,"range":{"start_line":134,"start_character":7,"end_line":135,"end_character":57},"updated":"2017-11-14 08:08:38.000000000","message":"Ditto.","commit_id":"eed21d7a1c0b3e5620960de9878ac9df0d2907fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"cf5a3f8f9f2ad0e835a8a7e6142d8e6c281e1721","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def test_create_domain_without_description(self):"},{"line_number":132,"context_line":"        # Create domain only with name"},{"line_number":133,"context_line":"        d_name \u003d data_utils.rand_name(\u0027domain\u0027)"},{"line_number":134,"context_line":"        domain \u003d self.domains_client.create_domain(name\u003dd_name)[\u0027domain\u0027]"},{"line_number":135,"context_line":"        self.addCleanup(self.delete_domain, domain[\u0027id\u0027])"},{"line_number":136,"context_line":"        expected_data \u003d {\u0027name\u0027: d_name, \u0027enabled\u0027: True}"},{"line_number":137,"context_line":"        self.assertEqual(\u0027\u0027, domain[\u0027description\u0027])"},{"line_number":138,"context_line":"        self.assertDictContainsSubset(expected_data, domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_66355946","line":135,"range":{"start_line":134,"start_character":7,"end_line":135,"end_character":57},"in_reply_to":"1f485f77_720514c2","updated":"2017-11-14 08:55:38.000000000","message":"here base.create_domain is not suitable because we don\u0027t want to have \u0027description\u0027 param in the api call.","commit_id":"eed21d7a1c0b3e5620960de9878ac9df0d2907fa"}]}