)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f7e19d286dea6b9de4b98766441077a8a1c5ec9f","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                if not extra_msg:"},{"line_number":582,"context_line":"                    extra_msg \u003d \u0027Failed to ssh to %s\u0027 % ip_address"},{"line_number":583,"context_line":"                LOG.exception(extra_msg)"},{"line_number":584,"context_line":"                raise"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":587,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_41b85029","line":584,"updated":"2017-11-21 05:03:00.000000000","message":"Looks like you can also call:\n\n    self._log_console_output([server])\n\non L584 (above raise), as it appeared on L589 before.","commit_id":"de88b07ea6bd9421820aae46bdd2e6930aa74f15"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"92e5a1e986c47745f6130e64186cb9224646f033","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                if not extra_msg:"},{"line_number":582,"context_line":"                    extra_msg \u003d \u0027Failed to ssh to %s\u0027 % ip_address"},{"line_number":583,"context_line":"                LOG.exception(extra_msg)"},{"line_number":584,"context_line":"                raise"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":587,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_410290b6","line":584,"in_reply_to":"ff82abbf_41b85029","updated":"2017-11-21 05:20:17.000000000","message":"Hi Felipe, because we now pass server\u003dserver when calling get_remote_client(L578), which will log console when ssh fails, \nso we needn\u0027t call _log_console_output outside any longer","commit_id":"de88b07ea6bd9421820aae46bdd2e6930aa74f15"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"d09a98fa5a027787655cc8a57d08eb04063fdd34","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                              extra_msg\u003d\"\","},{"line_number":587,"context_line":"                              server\u003dNone,"},{"line_number":588,"context_line":"                              mtu\u003dNone):"},{"line_number":589,"context_line":"        \"\"\"Check server connectivity"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :param ip_address: server to test against"},{"line_number":592,"context_line":"        :param username: server\u0027s ssh username"},{"line_number":593,"context_line":"        :param private_key: server\u0027s ssh private key to be used"},{"line_number":594,"context_line":"        :param should_connect: True/False indicates positive/negative test"},{"line_number":595,"context_line":"            positive - attempt ping and ssh"},{"line_number":596,"context_line":"            negative - attempt ping and fail if succeed"},{"line_number":597,"context_line":"        :param mtu: network MTU to use for connectivity validation"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        :raises: AssertError if the result of the connectivity check does"},{"line_number":600,"context_line":"            not match the value of the should_connect param"},{"line_number":601,"context_line":"        \"\"\""},{"line_number":602,"context_line":"        LOG.debug(\u0027checking network connections to IP %s with user: %s\u0027,"},{"line_number":603,"context_line":"                  ip_address, username)"},{"line_number":604,"context_line":"        if should_connect:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b53b25cf","line":601,"range":{"start_line":589,"start_character":8,"end_line":601,"end_character":11},"updated":"2018-06-11 04:53:53.000000000","message":"It\u0027s better to add doc for newly added parameters i.e. \"extra_msg\" and \"server\"","commit_id":"e5b06f2b7775a6bedbf60b606a757c250f292f5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c7022e7486869f141740e4e79a574db09c4c69f0","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                              extra_msg\u003d\"\","},{"line_number":587,"context_line":"                              server\u003dNone,"},{"line_number":588,"context_line":"                              mtu\u003dNone):"},{"line_number":589,"context_line":"        \"\"\"Check server connectivity"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        :param ip_address: server to test against"},{"line_number":592,"context_line":"        :param username: server\u0027s ssh username"},{"line_number":593,"context_line":"        :param private_key: server\u0027s ssh private key to be used"},{"line_number":594,"context_line":"        :param should_connect: True/False indicates positive/negative test"},{"line_number":595,"context_line":"            positive - attempt ping and ssh"},{"line_number":596,"context_line":"            negative - attempt ping and fail if succeed"},{"line_number":597,"context_line":"        :param mtu: network MTU to use for connectivity validation"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        :raises: AssertError if the result of the connectivity check does"},{"line_number":600,"context_line":"            not match the value of the should_connect param"},{"line_number":601,"context_line":"        \"\"\""},{"line_number":602,"context_line":"        LOG.debug(\u0027checking network connections to IP %s with user: %s\u0027,"},{"line_number":603,"context_line":"                  ip_address, username)"},{"line_number":604,"context_line":"        if should_connect:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_59089e8f","line":601,"range":{"start_line":589,"start_character":8,"end_line":601,"end_character":11},"in_reply_to":"5f7c97a3_b53b25cf","updated":"2018-07-07 22:08:41.000000000","message":"Done, although this is unrelated to patchset but it\u0027s trivial","commit_id":"e5b06f2b7775a6bedbf60b606a757c250f292f5d"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"d09a98fa5a027787655cc8a57d08eb04063fdd34","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return self.keypairs[server[\u0027key_name\u0027]][\u0027private_key\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _check_public_network_connectivity("},{"line_number":179,"context_line":"            self, should_connect\u003dTrue, msg\u003dNone,"},{"line_number":180,"context_line":"            should_check_floating_ip_status\u003dTrue, mtu\u003dNone):"},{"line_number":181,"context_line":"        \"\"\"Verifies connectivty to a VM via public network and floating IP"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_157f7966","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":47},"updated":"2018-06-11 04:53:53.000000000","message":"There is no usage of msg in body  of \"_check_public_network_connectivity\". So it should be improved accordingly.","commit_id":"e5b06f2b7775a6bedbf60b606a757c250f292f5d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c7022e7486869f141740e4e79a574db09c4c69f0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return self.keypairs[server[\u0027key_name\u0027]][\u0027private_key\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _check_public_network_connectivity("},{"line_number":179,"context_line":"            self, should_connect\u003dTrue, msg\u003dNone,"},{"line_number":180,"context_line":"            should_check_floating_ip_status\u003dTrue, mtu\u003dNone):"},{"line_number":181,"context_line":"        \"\"\"Verifies connectivty to a VM via public network and floating IP"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_79d55ae5","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":47},"in_reply_to":"5f7c97a3_157f7966","updated":"2018-07-07 22:08:41.000000000","message":"Done","commit_id":"e5b06f2b7775a6bedbf60b606a757c250f292f5d"}]}