)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6a977eb2a6c21676c79419e6ce0fe9f3331eae63","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                         \u0027There should only be one port created for \u0027"},{"line_number":721,"context_line":"                         \u0027server %s.\u0027 % server[\u0027id\u0027])"},{"line_number":722,"context_line":"        self.assertEqual(port[\u0027id\u0027], port_list[0][\u0027id\u0027])"},{"line_number":723,"context_line":"        self._reassociate_floating_ips()"},{"line_number":724,"context_line":"        # Check Connectivity for the server"},{"line_number":725,"context_line":"        self.check_public_network_connectivity("},{"line_number":726,"context_line":"            should_connect\u003dTrue, msg\u003d\"check connectivity of the second server\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_a3ce5e60","line":723,"range":{"start_line":723,"start_character":8,"end_line":723,"end_character":40},"updated":"2017-12-10 09:30:56.000000000","message":"reassociate_floating_ips will create new server, which is not what we want","commit_id":"1c85167114ce73343fb50670b98cdb7c2e0254ac"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"466539ec67c6a2e580790b957d81f859b718a41a","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                         \u0027There should only be one port created for \u0027"},{"line_number":721,"context_line":"                         \u0027server %s.\u0027 % server[\u0027id\u0027])"},{"line_number":722,"context_line":"        self.assertEqual(port[\u0027id\u0027], port_list[0][\u0027id\u0027])"},{"line_number":723,"context_line":"        self._reassociate_floating_ips()"},{"line_number":724,"context_line":"        # Check Connectivity for the server"},{"line_number":725,"context_line":"        self.check_public_network_connectivity("},{"line_number":726,"context_line":"            should_connect\u003dTrue, msg\u003d\"check connectivity of the second server\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_40a24eb0","line":723,"range":{"start_line":723,"start_character":8,"end_line":723,"end_character":40},"in_reply_to":"df87a7cf_a3ce5e60","updated":"2018-01-15 08:29:44.000000000","message":"Done","commit_id":"1c85167114ce73343fb50670b98cdb7c2e0254ac"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c5e0efc6f6e087b6feaaeee41b0dca818f0919ce","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                         \u0027There should only be one port created for \u0027"},{"line_number":721,"context_line":"                         \u0027server %s.\u0027 % server[\u0027id\u0027])"},{"line_number":722,"context_line":"        self.assertEqual(port[\u0027id\u0027], port_list[0][\u0027id\u0027])"},{"line_number":723,"context_line":"        self._reassociate_floating_ips()"},{"line_number":724,"context_line":"        # Check Connectivity for the server"},{"line_number":725,"context_line":"        self.check_public_network_connectivity("},{"line_number":726,"context_line":"            should_connect\u003dTrue, msg\u003d\"check connectivity of the second server\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_e084bab3","line":723,"range":{"start_line":723,"start_character":8,"end_line":723,"end_character":40},"in_reply_to":"df87a7cf_a3ce5e60","updated":"2018-01-28 09:03:16.000000000","message":"Done","commit_id":"1c85167114ce73343fb50670b98cdb7c2e0254ac"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1cfd8ebc88f8bcdbde7497cbe69151a6bb5943e6","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _reassociate_floating_ips(self, server\u003dNone):"},{"line_number":218,"context_line":"        floating_ip, server \u003d self.floating_ip_tuple"},{"line_number":219,"context_line":"        if server is None:"},{"line_number":220,"context_line":"            # create a new server for the floating ip"},{"line_number":221,"context_line":"            server \u003d self._create_server(self.network)"},{"line_number":222,"context_line":"        port_id, _ \u003d self._get_server_port_id_and_ip4(server)"},{"line_number":223,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":224,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport_id)[\u0027floatingip\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_2f392d40","line":221,"range":{"start_line":219,"start_character":0,"end_line":221,"end_character":54},"updated":"2018-01-15 11:37:56.000000000","message":"where do you create the server with the same port?","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"06840a6fedadf4213b9e43326488383d7e8491a6","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _reassociate_floating_ips(self, server\u003dNone):"},{"line_number":218,"context_line":"        floating_ip, server \u003d self.floating_ip_tuple"},{"line_number":219,"context_line":"        if server is None:"},{"line_number":220,"context_line":"            # create a new server for the floating ip"},{"line_number":221,"context_line":"            server \u003d self._create_server(self.network)"},{"line_number":222,"context_line":"        port_id, _ \u003d self._get_server_port_id_and_ip4(server)"},{"line_number":223,"context_line":"        floating_ip \u003d self.floating_ips_client.update_floatingip("},{"line_number":224,"context_line":"            floating_ip[\u0027id\u0027], port_id\u003dport_id)[\u0027floatingip\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_41e1edcf","line":221,"range":{"start_line":219,"start_character":0,"end_line":221,"end_character":54},"in_reply_to":"7f96bb07_2f392d40","updated":"2018-01-15 12:12:35.000000000","message":"nevermind I get it","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5481fe56260d1df5797fe0b5c3d7eb453fce7ab","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        # Setup the network, create a port and boot the server from that port."},{"line_number":688,"context_line":"        self._setup_network_and_servers(boot_with_port\u003dTrue)"},{"line_number":689,"context_line":"        floating_ip, server \u003d self.floating_ip_tuple"},{"line_number":690,"context_line":"        self.assertEqual(1, len(self.ports),"},{"line_number":691,"context_line":"                         \u0027There should only be one port created for \u0027"},{"line_number":692,"context_line":"                         \u0027server %s.\u0027 % server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_a306981b","line":689,"range":{"start_line":689,"start_character":8,"end_line":689,"end_character":19},"updated":"2018-01-16 06:49:58.000000000","message":"this seems nowhere to use?","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c5e0efc6f6e087b6feaaeee41b0dca818f0919ce","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        # Setup the network, create a port and boot the server from that port."},{"line_number":688,"context_line":"        self._setup_network_and_servers(boot_with_port\u003dTrue)"},{"line_number":689,"context_line":"        floating_ip, server \u003d self.floating_ip_tuple"},{"line_number":690,"context_line":"        self.assertEqual(1, len(self.ports),"},{"line_number":691,"context_line":"                         \u0027There should only be one port created for \u0027"},{"line_number":692,"context_line":"                         \u0027server %s.\u0027 % server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f93b717_d13079eb","line":689,"range":{"start_line":689,"start_character":8,"end_line":689,"end_character":19},"in_reply_to":"7f96bb07_a306981b","updated":"2018-01-28 09:03:16.000000000","message":"Done","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5481fe56260d1df5797fe0b5c3d7eb453fce7ab","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        self.assertEqual(self.network[\u0027id\u0027], port[\u0027network_id\u0027])"},{"line_number":711,"context_line":"        self.assertEqual(\u0027\u0027, port[\u0027device_id\u0027])"},{"line_number":712,"context_line":"        self.assertEqual(\u0027\u0027, port[\u0027device_owner\u0027])"},{"line_number":713,"context_line":"        self._disassociate_floating_ips()"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        # Boot another server with the same port to make sure nothing was"},{"line_number":716,"context_line":"        # left around that could cause issues."}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_4330f4e8","line":713,"range":{"start_line":713,"start_character":8,"end_line":713,"end_character":41},"updated":"2018-01-16 06:49:58.000000000","message":"I wonder why we need disassociate and reassociate floating ip to one same port?","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c5e0efc6f6e087b6feaaeee41b0dca818f0919ce","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        self.assertEqual(self.network[\u0027id\u0027], port[\u0027network_id\u0027])"},{"line_number":711,"context_line":"        self.assertEqual(\u0027\u0027, port[\u0027device_id\u0027])"},{"line_number":712,"context_line":"        self.assertEqual(\u0027\u0027, port[\u0027device_owner\u0027])"},{"line_number":713,"context_line":"        self._disassociate_floating_ips()"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        # Boot another server with the same port to make sure nothing was"},{"line_number":716,"context_line":"        # left around that could cause issues."}],"source_content_type":"text/x-python","patch_set":7,"id":"5f93b717_714de570","line":713,"range":{"start_line":713,"start_character":8,"end_line":713,"end_character":41},"in_reply_to":"7f96bb07_4330f4e8","updated":"2018-01-28 09:03:16.000000000","message":"I\u0027ve tried removing it, it doesn\u0027t work without it,\nI have no good explanation as to why.","commit_id":"b02823cd708751b7ec080097df4e03fdd2fa6439"}]}