)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"dc40ff30f63b956c84d55164c777b88e59a01366","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        def _clean_oldest_backup(oldest_backup):"},{"line_number":407,"context_line":"            if oldest_backup_exist:"},{"line_number":408,"context_line":"                try:"},{"line_number":409,"context_line":"                    glance_client.delete_image(oldest_backup)"},{"line_number":410,"context_line":"                except lib_exc.NotFound:"},{"line_number":411,"context_line":"                    pass"},{"line_number":412,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_6ca28bfe","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":20},"updated":"2017-11-16 13:51:50.000000000","message":"weird dup block","commit_id":"959bf86f2f83431e4ca4e4f2b49997669b4e06be"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"78994cb16e1eef01df8dd2e5ff3d08ff12106ba8","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":340,"context_line":"                self.get_server_ip(server, validation_resources),"},{"line_number":341,"context_line":"                self.ssh_user,"},{"line_number":342,"context_line":"                password\u003dNone,"},{"line_number":343,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":344,"context_line":"                server\u003dserver,"},{"line_number":345,"context_line":"                servers_client\u003dself.client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_a9386bed","line":342,"range":{"start_line":342,"start_character":16,"end_line":342,"end_character":29},"updated":"2017-11-16 19:27:50.000000000","message":"Why we need to specify None as password here instead of self.password? That is different from the other calls of RemoteClient in this test module.","commit_id":"a6ef703604e70cf4aeedf87bd156a4f8d36cb5a6"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"877e3211d8dd283c308c2cd436caa0680249c2c2","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":340,"context_line":"                self.get_server_ip(server, validation_resources),"},{"line_number":341,"context_line":"                self.ssh_user,"},{"line_number":342,"context_line":"                password\u003dNone,"},{"line_number":343,"context_line":"                pkey\u003dvalidation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":344,"context_line":"                server\u003dserver,"},{"line_number":345,"context_line":"                servers_client\u003dself.client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_dba0fb44","line":342,"range":{"start_line":342,"start_character":16,"end_line":342,"end_character":29},"in_reply_to":"1f485f77_a9386bed","updated":"2017-11-17 08:38:39.000000000","message":"Because self.password is given as adminPass only if the server is created via base.BaseV2ComputeTest.recreate_server()\nWhich is not the case in test_resize_volume_backed_server_confirm testcase","commit_id":"a6ef703604e70cf4aeedf87bd156a4f8d36cb5a6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a011b3f3466e71bc461e703dbdf9b604dd9b37cb","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            # output; we don\u0027t actually care about the output,"},{"line_number":332,"context_line":"            # just that it doesn\u0027t raise an error."},{"line_number":333,"context_line":"            self.client.get_console_output(server[\u0027id\u0027])"},{"line_number":334,"context_line":"        elif CONF.validation.run_validation:"},{"line_number":335,"context_line":"            # If console output is not supported for this virtualization,"},{"line_number":336,"context_line":"            # then check ssh connectivity"},{"line_number":337,"context_line":"            validation_resources \u003d self.get_class_validation_resources("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_56b6f4db","line":334,"updated":"2017-11-20 07:07:49.000000000","message":"Can we run this condition in the upstream gate? I think we probably can check this even if console_output is True, too.","commit_id":"4626ba159581c03bdf400d45ebcc54ddc7b9b715"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"cb697ede5b79c883eedc3091ee213315028a7ff9","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            # output; we don\u0027t actually care about the output,"},{"line_number":332,"context_line":"            # just that it doesn\u0027t raise an error."},{"line_number":333,"context_line":"            self.client.get_console_output(server[\u0027id\u0027])"},{"line_number":334,"context_line":"        elif CONF.validation.run_validation:"},{"line_number":335,"context_line":"            # If console output is not supported for this virtualization,"},{"line_number":336,"context_line":"            # then check ssh connectivity"},{"line_number":337,"context_line":"            validation_resources \u003d self.get_class_validation_resources("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_58e61aeb","line":334,"in_reply_to":"ff82abbf_56b6f4db","updated":"2017-11-20 13:38:30.000000000","message":"Done","commit_id":"4626ba159581c03bdf400d45ebcc54ddc7b9b715"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"b150955691ecbe7bac0cacd020722d4bd99a084c","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            # just that it doesn\u0027t raise an error."},{"line_number":333,"context_line":"            self.client.get_console_output(server[\u0027id\u0027])"},{"line_number":334,"context_line":"        if CONF.validation.run_validation:"},{"line_number":335,"context_line":"            # If console output is not supported for this virtualization,"},{"line_number":336,"context_line":"            # then check ssh connectivity"},{"line_number":337,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":338,"context_line":"                self.os_primary)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_78043e7c","line":335,"range":{"start_line":335,"start_character":14,"end_line":335,"end_character":72},"updated":"2017-11-20 13:43:15.000000000","message":"This comment isn\u0027t true since you made these conditions independent.","commit_id":"1cfa5bce35ae39579ef0142ffffd45803528109a"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"f050cbb6f230c5c11ea324975c4f2c76310afc88","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            # just that it doesn\u0027t raise an error."},{"line_number":333,"context_line":"            self.client.get_console_output(server[\u0027id\u0027])"},{"line_number":334,"context_line":"        if CONF.validation.run_validation:"},{"line_number":335,"context_line":"            # If console output is not supported for this virtualization,"},{"line_number":336,"context_line":"            # then check ssh connectivity"},{"line_number":337,"context_line":"            validation_resources \u003d self.get_class_validation_resources("},{"line_number":338,"context_line":"                self.os_primary)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_eefe44ad","line":335,"range":{"start_line":335,"start_character":14,"end_line":335,"end_character":72},"in_reply_to":"ff82abbf_78043e7c","updated":"2017-11-20 14:49:35.000000000","message":"Done","commit_id":"1cfa5bce35ae39579ef0142ffffd45803528109a"}]}
