)]}'
{"tempest/api/volume/admin/test_group_types.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"51f15f245ccc96a0a68aa65e12bab9eaeebf20f7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @decorators.idempotent_id(\u0027dd71e5f9-393e-4d4f-90e9-fa1b8d278864\u0027)"},{"line_number":27,"context_line":"    def test_group_type_create_list_show_update(self):"},{"line_number":28,"context_line":"        # Create/list/show group type."},{"line_number":29,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-group-type\u0027)"},{"line_number":30,"context_line":"        description \u003d data_utils.rand_name(\"group-type-description\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_2aadfe30","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":47},"updated":"2017-12-13 03:03:53.000000000","message":"test_group_type_create_list_update_show :)","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fff9a3c57d7809f59f41b11cd3c07afe0ae67dc7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        updated_group_type \u003d self.admin_group_types_client.update_group_type("},{"line_number":63,"context_line":"            body[\u0027id\u0027], **group_type_params)[\u0027group_type\u0027]"},{"line_number":64,"context_line":"        for param, expected_val in group_type_params.items():"},{"line_number":65,"context_line":"            self.assertEqual(expected_val, updated_group_type[param])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_21474f4e","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":69},"updated":"2017-11-21 01:48:32.000000000","message":"better to add a check after show_group_type, to verify the attributes are really modified","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2cd6451aeadac2760b2733622c3ce4a2d08315bf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        updated_group_type \u003d self.admin_group_types_client.update_group_type("},{"line_number":63,"context_line":"            body[\u0027id\u0027], **group_type_params)[\u0027group_type\u0027]"},{"line_number":64,"context_line":"        for param, expected_val in group_type_params.items():"},{"line_number":65,"context_line":"            self.assertEqual(expected_val, updated_group_type[param])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_7ccbc0a4","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":69},"in_reply_to":"ff82abbf_21474f4e","updated":"2017-11-21 02:50:16.000000000","message":"Agree, fixed in next patch.","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"941f084ebbab6d6a89dbf504347a7ba2ea89f458","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        updated_group_type \u003d self.admin_group_types_client.update_group_type("},{"line_number":63,"context_line":"            body[\u0027id\u0027], **group_type_params)[\u0027group_type\u0027]"},{"line_number":64,"context_line":"        for param, expected_val in group_type_params.items():"},{"line_number":65,"context_line":"            self.assertEqual(expected_val, updated_group_type[param])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_87974891","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":69},"in_reply_to":"ff82abbf_7ccbc0a4","updated":"2017-11-21 07:59:54.000000000","message":"i will suggest to make update before L49 so that single show can be utilized.","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"}],"tempest/lib/services/volume/v3/group_types_client.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fff9a3c57d7809f59f41b11cd3c07afe0ae67dc7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        API reference:"},{"line_number":84,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#update-group-type"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        post_body \u003d json.dumps({\u0027group_type\u0027: kwargs})"},{"line_number":87,"context_line":"        resp, body \u003d self.put(\u0027group_types/%s\u0027 % group_type_id, post_body)"},{"line_number":88,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":89,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_414a9327","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":54},"updated":"2017-11-21 01:48:32.000000000","message":"from the ref link https://developer.openstack.org/api-ref/block-storage/v3/#update-group-type,\n\u0027group_type\u0027 seems to be one of the possible parameters, e.g., maybe we want to update group_type_id?","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2cd6451aeadac2760b2733622c3ce4a2d08315bf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        API reference:"},{"line_number":84,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#update-group-type"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        post_body \u003d json.dumps({\u0027group_type\u0027: kwargs})"},{"line_number":87,"context_line":"        resp, body \u003d self.put(\u0027group_types/%s\u0027 % group_type_id, post_body)"},{"line_number":88,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":89,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_5c47dc1e","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":54},"in_reply_to":"ff82abbf_414a9327","updated":"2017-11-21 02:50:16.000000000","message":"I saw that earlier and was a bit confused by that documentation. \n\nIf you notice, group_type_id (which is mandatory, not optional, which is a bug in docs I think) and project_id are only path parameters. I\u0027m pretty sure that group_type_id is an auto-generated UUID that can\u0027t be updated.\n\ngroup_type is just the outer key that is mandatory; it should follow the same format as create_group_type above, right?","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bb077b398ee993fff941adfe60fee4403495742d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        API reference:"},{"line_number":84,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#update-group-type"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        post_body \u003d json.dumps({\u0027group_type\u0027: kwargs})"},{"line_number":87,"context_line":"        resp, body \u003d self.put(\u0027group_types/%s\u0027 % group_type_id, post_body)"},{"line_number":88,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":89,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_7c82e0ca","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":54},"in_reply_to":"ff82abbf_5c47dc1e","updated":"2017-11-21 03:18:59.000000000","message":"Yes it\u0027s ok to follow the same format as create_group_type, and after I read the doc of create_group_type, I am still confused\nbecause the doc seems to say we can either pass \u0027group_type\u0027 or \u0027name\u0027 to create/update group type. So I\u0027d like to know whether\nI have some misunderstandings about the doc, or the doc need some more work?","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"941f084ebbab6d6a89dbf504347a7ba2ea89f458","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        API reference:"},{"line_number":84,"context_line":"        https://developer.openstack.org/api-ref/block-storage/v3/#update-group-type"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        post_body \u003d json.dumps({\u0027group_type\u0027: kwargs})"},{"line_number":87,"context_line":"        resp, body \u003d self.put(\u0027group_types/%s\u0027 % group_type_id, post_body)"},{"line_number":88,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":89,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e712d4b1","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":54},"in_reply_to":"ff82abbf_7c82e0ca","updated":"2017-11-21 07:59:54.000000000","message":"group_type_id is in path and mandatory for this is API  - https://github.com/openstack/cinder/blob/master/cinder/api/v3/group_types.py#L101\n\ndoc is wrong as usual. bug and fix -https://bugs.launchpad.net/cinder/+bug/1733504\nhttps://review.openstack.org/#/c/521747/","commit_id":"d07c73e7e0f6914e18696c57f5f6c3d24ecb02ef"}]}