)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5eb6d431430917c9b6378e9b0e231bdef77c97f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Leontii Istomin \u003clistomin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-27 11:55:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cut cinder backend name from host info."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" bug: 1734636"},{"line_number":10,"context_line":" Output of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_683d9adb","line":7,"updated":"2017-11-28 09:07:02.000000000","message":"The trailing period is unnecessary.","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":15232,"name":"Leontii","email":"leontii.istomin@intel.com","username":"listomin"},"change_message_id":"598cd550710b7c286d2fb86c766d8697deadd8e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Leontii Istomin \u003clistomin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-27 11:55:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cut cinder backend name from host info."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" bug: 1734636"},{"line_number":10,"context_line":" Output of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_ef466dc0","line":7,"in_reply_to":"ff82abbf_683d9adb","updated":"2017-11-29 10:31:03.000000000","message":"Done","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5eb6d431430917c9b6378e9b0e231bdef77c97f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cut cinder backend name from host info."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" bug: 1734636"},{"line_number":10,"context_line":" Output of"},{"line_number":11,"context_line":" \"openstack volume show -f value -c os-vol-host-attr:host \u003cvolume\u003e\" command"},{"line_number":12,"context_line":" includes backend name like \"\u003chost name\u003e#\u003cbackend name\u003e\". We need to cut"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_08264ecf","line":9,"updated":"2017-11-28 09:07:02.000000000","message":"This can be like this:\n\n  Closes-Bug: #1734636\n\nMore information is here https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":15232,"name":"Leontii","email":"leontii.istomin@intel.com","username":"listomin"},"change_message_id":"598cd550710b7c286d2fb86c766d8697deadd8e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cut cinder backend name from host info."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" bug: 1734636"},{"line_number":10,"context_line":" Output of"},{"line_number":11,"context_line":" \"openstack volume show -f value -c os-vol-host-attr:host \u003cvolume\u003e\" command"},{"line_number":12,"context_line":" includes backend name like \"\u003chost name\u003e#\u003cbackend name\u003e\". We need to cut"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_4f3c392e","line":9,"in_reply_to":"ff82abbf_08264ecf","updated":"2017-11-29 10:31:03.000000000","message":"Done","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"714f633f6a7b47b1fac20f2e034de23feff89a56","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Leontii Istomin \u003clistomin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-01 12:20:44 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cut cinder backend name from host info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Output of"},{"line_number":10,"context_line":" \"openstack volume show -f value -c os-vol-host-attr:host \u003cvolume\u003e\" command"},{"line_number":11,"context_line":" includes backend name like \"\u003chost name\u003e#\u003cbackend name\u003e\". We need to cut"},{"line_number":12,"context_line":" excess info."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1734636"},{"line_number":15,"context_line":"Change-Id: If50b82a48e7449f41f8fb08f63232eb9a21c2cf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df87a7cf_f3dbfce9","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":13},"updated":"2017-12-08 03:16:44.000000000","message":"please write it in more clear way with cinder format for host. something like-\n\nExtract hostname as per cinder supported host format\n\nCinder can have hostname with \u0027host@backend#pool\u0027 format where pool info can be present on hostname string.\n\nTo handle all cases we need to extract the hostname string as per above format like cinder does\n- https://github.com/openstack/cinder/blob/4f649809a4a51a5ddbce290ca0dcb3f1566f044b/cinder/volume/utils.py#L691\n\nCloses-Bug: #1734636","commit_id":"7599dbdc66786f27f87085fa74ef70a118b4e72b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a31e35c3fff91129652abe0dd20f2b1d0d7140a8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  Cinder can have hostname with \u0027host@backend#pool\u0027 format where pool"},{"line_number":10,"context_line":"  info can be present on hostname string."},{"line_number":11,"context_line":"  To handle all cases we need to extract the hostname string as per"},{"line_number":12,"context_line":"  above formatrmat."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1734636"},{"line_number":15,"context_line":"Change-Id: If50b82a48e7449f41f8fb08f63232eb9a21c2cf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"df87a7cf_226c63cc","line":12,"updated":"2017-12-12 02:52:48.000000000","message":"NIT: I think these indentations are unnecessary.","commit_id":"2e8768ac3e455cc611c17ecd87c9d28b76878317"}],"tempest/api/volume/admin/test_volume_services.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5eb6d431430917c9b6378e9b0e231bdef77c97f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def _get_host(host):"},{"line_number":20,"context_line":"    host \u003d host.split(\u0027#\u0027)[0]"},{"line_number":21,"context_line":"    return host.split(\u0027@\u0027)[0]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumesServicesTestJSON(base.BaseVolumeAdminTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_282312bf","line":21,"updated":"2017-11-28 09:07:02.000000000","message":"We can merge like this\n\n  return host.split(\u0027#\u0027)[0].split(\u0027@\u0027)[0]\n\nAnd, how about adding a NOTE for these special characters(# and @)?\n\nAnd my concern is there\u0027s no information about \u0027#\u0027 in the api docs..","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":15232,"name":"Leontii","email":"leontii.istomin@intel.com","username":"listomin"},"change_message_id":"598cd550710b7c286d2fb86c766d8697deadd8e7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def _get_host(host):"},{"line_number":20,"context_line":"    host \u003d host.split(\u0027#\u0027)[0]"},{"line_number":21,"context_line":"    return host.split(\u0027@\u0027)[0]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumesServicesTestJSON(base.BaseVolumeAdminTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_2ffc556e","line":21,"in_reply_to":"ff82abbf_282312bf","updated":"2017-11-29 10:31:03.000000000","message":"Done","commit_id":"5e4a6c89bcb717ea403c76d3fd21b29e007d21f2"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"20e19abd7ceec7310b90dd3d5bb0e285a439c614","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def _get_host(host):"},{"line_number":20,"context_line":"    return host.split(\u0027#\u0027)[0].host.split(\u0027@\u0027)[0]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class VolumesServicesTestJSON(base.BaseVolumeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_7af1bd00","line":20,"updated":"2017-11-29 10:51:44.000000000","message":"It won\u0027t work for all backends. We need here something like we\u0027ve got in cinder [1]\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/utils.py#L690","commit_id":"e88950867c8991810e2932aec50fda8f64e2087d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"714f633f6a7b47b1fac20f2e034de23feff89a56","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def _get_host(host):"},{"line_number":20,"context_line":"    \"\"\"NOTE:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"      - We need to cut all after \"#\" symbol due to this launchpad bug #1734636"},{"line_number":23,"context_line":"      - We need to cut all after \"@\" symbol as we can see the following similar"},{"line_number":24,"context_line":"        to bug above behavior:"},{"line_number":25,"context_line":"        openstack volume service list -f value -c Host"},{"line_number":26,"context_line":"        cmp001@lvm-driver"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    return host.split(\u0027#\u0027)[0].split(\u0027@\u0027)[0]"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_734dac98","line":27,"range":{"start_line":20,"start_character":0,"end_line":27,"end_character":7},"updated":"2017-12-08 03:16:44.000000000","message":"you can just include the NOTE here like below:\n\n# NOTE:  hostname string from cinder could be in format host@backend#pool. So fetch the host name accordingly.","commit_id":"7599dbdc66786f27f87085fa74ef70a118b4e72b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a31e35c3fff91129652abe0dd20f2b1d0d7140a8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # NOTE:  hostname string from cinder could be in format host@backend#pool."},{"line_number":22,"context_line":"    # So fetch the host name accordingly."},{"line_number":23,"context_line":"    return host.split(\u0027#\u0027)[0].split(\u0027@\u0027)[0]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumesServicesTestJSON(base.BaseVolumeAdminTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_426727ea","line":23,"updated":"2017-12-12 02:52:48.000000000","message":"So, according to this NOTE, I think we don\u0027t need to care about \u0027#\u0027 to get \u0027host\u0027. Just \n\n  return host.split(\u0027@\u0027)[0]\n\nis enough. But you said the value can be like \u0027ctl01#DEFAULT\u0027, right? I think it\u0027s good to mention about it like \"why do we get \u0027ctl01#DEFAULT\u0027?\" or like that. Otherwise, the code looks weird.","commit_id":"2e8768ac3e455cc611c17ecd87c9d28b76878317"}]}