)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"638ad5d248545eaaf0ef679c519f952e5ba644f6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        client.attach_volume("},{"line_number":193,"context_line":"            server_id, volumeId\u003dvolume_id,"},{"line_number":194,"context_line":"            device\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":195,"context_line":"        waiters.wait_for_volume_resource_status(client, volume_id, \u0027in-use\u0027)"},{"line_number":196,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status, client,"},{"line_number":197,"context_line":"                        volume_id, \u0027available\u0027)"},{"line_number":198,"context_line":"        self.addCleanup(client.detach_volume, server_id, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_f510bb50","line":195,"range":{"start_line":195,"start_character":48,"end_line":195,"end_character":54},"updated":"2017-11-27 14:33:56.000000000","message":"it has to be volumes_client otherwise it would not find show_volume in server client. You can keep self.volumes_client  here","commit_id":"4e3389c64c7e07b91b697a9e40d35bebfca2ec31"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9c5a66f93e55468575d6205e26a3a8a934b61c4f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        client.attach_volume("},{"line_number":193,"context_line":"            server_id, volumeId\u003dvolume_id,"},{"line_number":194,"context_line":"            device\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":195,"context_line":"        waiters.wait_for_volume_resource_status(client, volume_id, \u0027in-use\u0027)"},{"line_number":196,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status, client,"},{"line_number":197,"context_line":"                        volume_id, \u0027available\u0027)"},{"line_number":198,"context_line":"        self.addCleanup(client.detach_volume, server_id, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_939a8eb6","line":195,"range":{"start_line":195,"start_character":48,"end_line":195,"end_character":54},"in_reply_to":"ff82abbf_f510bb50","updated":"2017-11-28 11:12:32.000000000","message":"Done","commit_id":"4e3389c64c7e07b91b697a9e40d35bebfca2ec31"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"638ad5d248545eaaf0ef679c519f952e5ba644f6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            server_id, volumeId\u003dvolume_id,"},{"line_number":194,"context_line":"            device\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":195,"context_line":"        waiters.wait_for_volume_resource_status(client, volume_id, \u0027in-use\u0027)"},{"line_number":196,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status, client,"},{"line_number":197,"context_line":"                        volume_id, \u0027available\u0027)"},{"line_number":198,"context_line":"        self.addCleanup(client.detach_volume, server_id, volume_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_55008701","line":196,"range":{"start_line":196,"start_character":65,"end_line":196,"end_character":71},"updated":"2017-11-27 14:33:56.000000000","message":"Ditto","commit_id":"4e3389c64c7e07b91b697a9e40d35bebfca2ec31"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9c5a66f93e55468575d6205e26a3a8a934b61c4f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            server_id, volumeId\u003dvolume_id,"},{"line_number":194,"context_line":"            device\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":195,"context_line":"        waiters.wait_for_volume_resource_status(client, volume_id, \u0027in-use\u0027)"},{"line_number":196,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status, client,"},{"line_number":197,"context_line":"                        volume_id, \u0027available\u0027)"},{"line_number":198,"context_line":"        self.addCleanup(client.detach_volume, server_id, volume_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_b3955289","line":196,"range":{"start_line":196,"start_character":65,"end_line":196,"end_character":71},"in_reply_to":"ff82abbf_55008701","updated":"2017-11-28 11:12:32.000000000","message":"Done","commit_id":"4e3389c64c7e07b91b697a9e40d35bebfca2ec31"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"04b568347d94f596e7154ba8a641c1847abb3573","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if snapshot_id in self.snapshots:"},{"line_number":186,"context_line":"            self.snapshots.remove(snapshot_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def attach_volume(self, server_id, volume_id, client\u003dNone, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Attach a volume to a server\"\"\""},{"line_number":190,"context_line":"        device \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":191,"context_line":"        if client is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_53ad642f","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":21},"updated":"2017-12-05 08:21:57.000000000","message":"this seems much complicated, so I\u0027d rather let the code as is:)","commit_id":"eb5784d61a6646257f3a4c5f7e83c7a2ab6052c2"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a835de04c51dead2735572db52d2771e7f0cf64f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if snapshot_id in self.snapshots:"},{"line_number":186,"context_line":"            self.snapshots.remove(snapshot_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def attach_volume(self, server_id, volume_id, client\u003dNone, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Attach a volume to a server\"\"\""},{"line_number":190,"context_line":"        device \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":191,"context_line":"        if client is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_811b367f","line":188,"updated":"2017-12-08 05:26:20.000000000","message":"yeah, I agree with zhufl.","commit_id":"eb5784d61a6646257f3a4c5f7e83c7a2ab6052c2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2cd7c90318600f0ee8e0eeca7150b860e680f337","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if snapshot_id in self.snapshots:"},{"line_number":186,"context_line":"            self.snapshots.remove(snapshot_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def attach_volume(self, server_id, volume_id, client\u003dNone, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Attach a volume to a server\"\"\""},{"line_number":190,"context_line":"        device \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":191,"context_line":"        if client is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_ae280386","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":21},"in_reply_to":"df87a7cf_53ad642f","updated":"2017-12-05 08:31:39.000000000","message":"Right i agree and i think there are only 2 tests that use volume_client for this operation.","commit_id":"eb5784d61a6646257f3a4c5f7e83c7a2ab6052c2"}],"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ca44c86dc2d061054072a91458a55e7d6828a467","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # Create a server"},{"line_number":72,"context_line":"        server \u003d self.create_server()"},{"line_number":73,"context_line":"        # Verify that a volume\u0027s attachment information is retrieved"},{"line_number":74,"context_line":"        self.volumes_client.attach_volume(self.volume[\u0027id\u0027],"},{"line_number":75,"context_line":"                                          instance_uuid\u003dserver[\u0027id\u0027],"},{"line_number":76,"context_line":"                                          mountpoint\u003d\u0027/dev/%s\u0027 %"},{"line_number":77,"context_line":"                                          CONF.compute.volume_device_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1bea3eab","side":"PARENT","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":60},"updated":"2017-11-27 03:09:03.000000000","message":"In base.py we use servers_client.attach_volume, so they are not totally identical","commit_id":"6e3b0b0d956e0cf4c83cf331b4e0eb8f5a6221a6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b6db7962c283ceb24958f3c805f6c49714c256f0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # Create a server"},{"line_number":72,"context_line":"        server \u003d self.create_server()"},{"line_number":73,"context_line":"        # Verify that a volume\u0027s attachment information is retrieved"},{"line_number":74,"context_line":"        self.volumes_client.attach_volume(self.volume[\u0027id\u0027],"},{"line_number":75,"context_line":"                                          instance_uuid\u003dserver[\u0027id\u0027],"},{"line_number":76,"context_line":"                                          mountpoint\u003d\u0027/dev/%s\u0027 %"},{"line_number":77,"context_line":"                                          CONF.compute.volume_device_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_d72fc285","side":"PARENT","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":60},"in_reply_to":"ff82abbf_1bea3eab","updated":"2017-11-27 09:47:00.000000000","message":"Right thanks, I updated \u0027attach_volume\u0027 method to support both clients.","commit_id":"6e3b0b0d956e0cf4c83cf331b4e0eb8f5a6221a6"}]}