)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"55790b0e74aa8d4884ae1da32080d327b07bece8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use addClassResourceCleanup in test_roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"call_and_ignore_notfound_exc is only used on cls.role because it"},{"line_number":10,"context_line":"is the only resource that is deleted in the role tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5930c5f9d68b0258620e6de90398b34f84e06d9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_9161f1d5","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":54},"updated":"2017-11-30 03:14:01.000000000","message":"This seems not true because in testcases we don\u0027t delete cls.role. (delete_role_from_user_on_project won\u0027t delete role)","commit_id":"89e38afd663644bf0b7a57dbd95645acab881678"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e186b60238afd56f639a2991a28e6cc4018e1464","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use addClassResourceCleanup in test_roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"call_and_ignore_notfound_exc is only used on cls.role because it"},{"line_number":10,"context_line":"is the only resource that is deleted in the role tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5930c5f9d68b0258620e6de90398b34f84e06d9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_c2e237a1","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":54},"in_reply_to":"ff82abbf_9161f1d5","updated":"2017-11-30 16:52:09.000000000","message":"Done","commit_id":"89e38afd663644bf0b7a57dbd95645acab881678"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3fd5c132454e9c9291c8872cb996d4ac4aee5541","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use addClassResourceCleanup in test_roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"call_and_ignore_notfound_exc is only used on cls.role because it"},{"line_number":10,"context_line":"is the only resource that is deleted in the role tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5930c5f9d68b0258620e6de90398b34f84e06d9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_972eb6f8","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":54},"in_reply_to":"ff82abbf_9161f1d5","updated":"2017-11-30 14:44:08.000000000","message":"oh that\u0027s interesting, it uses the DELETE method but the description says, \"Unassigns a role from a group on a project\". I understand now, thanks for catching that zhufl :)","commit_id":"89e38afd663644bf0b7a57dbd95645acab881678"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"20141ab3b1e4e2598fe1d29042fcab7e7b844204","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Replaces resource_cleanup with addClassResourceCleanup in"},{"line_number":10,"context_line":"test_roles."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"test_utils.call_and_ignore_notfound_exc is NOT used in resource_setup"},{"line_number":13,"context_line":"as delete_role_from_user_on_project and similar calls, do not delete"},{"line_number":14,"context_line":"the role, it just unassigns the role from the target."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_3a18e073","line":12,"updated":"2017-12-01 01:41:16.000000000","message":"Not sure if this really belongs here because it\u0027s patch specific [0] but it does help reviewers so LGTM.\n\n[0] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"ee6b277cdfb2e890019f407585f8b1b4c60a6a05"}],"tempest/api/identity/admin/v3/test_roles.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc0942a028b241a77b8be8f4db7a319155c325d6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            role \u003d cls.roles_client.create_role(name\u003drole_name)[\u0027role\u0027]"},{"line_number":35,"context_line":"            cls.roles.append(role)"},{"line_number":36,"context_line":"        for role in cls.roles:"},{"line_number":37,"context_line":"            cls.addClassResourceCleanup(cls.roles_client.delete_role,"},{"line_number":38,"context_line":"                                        role[\u0027id\u0027])"},{"line_number":39,"context_line":"        u_name \u003d data_utils.rand_name(\u0027user\u0027)"},{"line_number":40,"context_line":"        u_desc \u003d \u0027%s description\u0027 % u_name"},{"line_number":41,"context_line":"        u_email \u003d \u0027%s@testmail.tm\u0027 % u_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_644da53c","line":38,"range":{"start_line":37,"start_character":12,"end_line":38,"end_character":51},"updated":"2017-11-29 08:20:59.000000000","message":"this can be put directly after L34","commit_id":"32efb8acd7b2c00b74c84651a2eecbb2f375c65d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"240b109213b31a83aad0dffd535e83427e2f4006","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            role \u003d cls.roles_client.create_role(name\u003drole_name)[\u0027role\u0027]"},{"line_number":35,"context_line":"            cls.roles.append(role)"},{"line_number":36,"context_line":"        for role in cls.roles:"},{"line_number":37,"context_line":"            cls.addClassResourceCleanup(cls.roles_client.delete_role,"},{"line_number":38,"context_line":"                                        role[\u0027id\u0027])"},{"line_number":39,"context_line":"        u_name \u003d data_utils.rand_name(\u0027user\u0027)"},{"line_number":40,"context_line":"        u_desc \u003d \u0027%s description\u0027 % u_name"},{"line_number":41,"context_line":"        u_email \u003d \u0027%s@testmail.tm\u0027 % u_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_90beddd2","line":38,"range":{"start_line":37,"start_character":12,"end_line":38,"end_character":51},"in_reply_to":"ff82abbf_644da53c","updated":"2017-11-29 14:45:11.000000000","message":"Correct! My bad. :)","commit_id":"32efb8acd7b2c00b74c84651a2eecbb2f375c65d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"70692e7c9cdece7ac64c243e813a9eb2a53ad6a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            role \u003d cls.roles_client.create_role(name\u003drole_name)[\u0027role\u0027]"},{"line_number":35,"context_line":"            cls.roles.append(role)"},{"line_number":36,"context_line":"        for role in cls.roles:"},{"line_number":37,"context_line":"            cls.addClassResourceCleanup(cls.roles_client.delete_role,"},{"line_number":38,"context_line":"                                        role[\u0027id\u0027])"},{"line_number":39,"context_line":"        u_name \u003d data_utils.rand_name(\u0027user\u0027)"},{"line_number":40,"context_line":"        u_desc \u003d \u0027%s description\u0027 % u_name"},{"line_number":41,"context_line":"        u_email \u003d \u0027%s@testmail.tm\u0027 % u_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_e341a1a7","line":38,"range":{"start_line":37,"start_character":12,"end_line":38,"end_character":51},"in_reply_to":"ff82abbf_644da53c","updated":"2017-11-29 15:24:54.000000000","message":"Done","commit_id":"32efb8acd7b2c00b74c84651a2eecbb2f375c65d"}]}