)]}'
{"tempest/api/volume/admin/test_group_type_specs.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ff986a5d296f7403eac148aa66032d130cf37e3e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        body \u003d self.admin_group_types_client.update_group_type_specs_item("},{"line_number":68,"context_line":"            group_type[\u0027id\u0027], update_key, update_spec)"},{"line_number":69,"context_line":"        self.assertEqual(update_spec, body)"},{"line_number":70,"context_line":"        body \u003d self.admin_group_types_client.show_group_type_specs_item("},{"line_number":71,"context_line":"            group_type[\u0027id\u0027], update_key)"},{"line_number":72,"context_line":"        self.assertIn(update_key, body)"},{"line_number":73,"context_line":"        self.assertEqual(update_spec[update_key], body[update_key])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Delete specified item of group type specs"},{"line_number":76,"context_line":"        delete_key \u003d \u0027key1\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_2bab9c75","line":73,"range":{"start_line":70,"start_character":0,"end_line":73,"end_character":67},"updated":"2017-12-14 09:18:25.000000000","message":"How about moving list_group_type_specs here to check whether the result equals create_specs.update(update_specs).update(update_spec)?","commit_id":"a8894e5d641459ee94d535cb59673c714253bcc4"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"df9b37627566d4dbcf6a684fb897722e64318680","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        body \u003d self.admin_group_types_client.update_group_type_specs_item("},{"line_number":68,"context_line":"            group_type[\u0027id\u0027], update_key, update_spec)"},{"line_number":69,"context_line":"        self.assertEqual(update_spec, body)"},{"line_number":70,"context_line":"        body \u003d self.admin_group_types_client.show_group_type_specs_item("},{"line_number":71,"context_line":"            group_type[\u0027id\u0027], update_key)"},{"line_number":72,"context_line":"        self.assertIn(update_key, body)"},{"line_number":73,"context_line":"        self.assertEqual(update_spec[update_key], body[update_key])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Delete specified item of group type specs"},{"line_number":76,"context_line":"        delete_key \u003d \u0027key1\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_d8c0ace3","line":73,"range":{"start_line":70,"start_character":0,"end_line":73,"end_character":67},"in_reply_to":"df87a7cf_2bab9c75","updated":"2017-12-15 06:19:01.000000000","message":"Done, it looks good, thanks, :)","commit_id":"a8894e5d641459ee94d535cb59673c714253bcc4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"208d6b06ebc298083666c1c6834fde8bd2306181","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        list_specs.update(update_spec)"},{"line_number":69,"context_line":"        body \u003d self.admin_group_types_client.list_group_type_specs("},{"line_number":70,"context_line":"            group_type[\u0027id\u0027])[\u0027group_specs\u0027]"},{"line_number":71,"context_line":"        self.assertEqual(len(list_specs), len(body))"},{"line_number":72,"context_line":"        for key in list_specs:"},{"line_number":73,"context_line":"            self.assertIn(key, body)"},{"line_number":74,"context_line":"            self.assertEqual(list_specs[key], body[key])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Delete specified item of group type specs"},{"line_number":77,"context_line":"        delete_key \u003d \u0027key1\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_426cab35","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":56},"updated":"2017-12-18 02:48:57.000000000","message":"Can these be replaced with self.assertEqual(body, list_specs)?","commit_id":"10c0f7cc9012408ead5cf2d7ef024ead4eed527c"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"23253135ebf1badcf937d237d9afd7a0d4d1b5f0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        list_specs.update(update_spec)"},{"line_number":69,"context_line":"        body \u003d self.admin_group_types_client.list_group_type_specs("},{"line_number":70,"context_line":"            group_type[\u0027id\u0027])[\u0027group_specs\u0027]"},{"line_number":71,"context_line":"        self.assertEqual(len(list_specs), len(body))"},{"line_number":72,"context_line":"        for key in list_specs:"},{"line_number":73,"context_line":"            self.assertIn(key, body)"},{"line_number":74,"context_line":"            self.assertEqual(list_specs[key], body[key])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Delete specified item of group type specs"},{"line_number":77,"context_line":"        delete_key \u003d \u0027key1\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_fd8a0219","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":56},"in_reply_to":"df87a7cf_426cab35","updated":"2017-12-18 13:50:25.000000000","message":"Yeah, it\u0027s simpler and much better, thanks! :)","commit_id":"10c0f7cc9012408ead5cf2d7ef024ead4eed527c"}],"tempest/lib/services/volume/v3/group_types_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fa74a5760d38bd6a48ce210307da0ad4ac15d1d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        body \u003d json.loads(body)"},{"line_number":76,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_or_update_group_type_specs(self, group_type_id, group_specs):"},{"line_number":80,"context_line":"        \"\"\"Creates new group type specs or updates existing group type specs."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_f1055812","line":78,"updated":"2017-12-07 00:09:50.000000000","message":"Why is there no endpoint for list?\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/#list-group-specs-for-a-group-type","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"a6a05303c629ba02db1692bdd8dca9cc382a66f8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        body \u003d json.loads(body)"},{"line_number":76,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_or_update_group_type_specs(self, group_type_id, group_specs):"},{"line_number":80,"context_line":"        \"\"\"Creates new group type specs or updates existing group type specs."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_510f6436","line":78,"in_reply_to":"df87a7cf_f1055812","updated":"2017-12-07 01:18:30.000000000","message":"Done","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fa74a5760d38bd6a48ce210307da0ad4ac15d1d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        put_body \u003d json.dumps(spec)"},{"line_number":118,"context_line":"        resp, body \u003d self.put(url, put_body)"},{"line_number":119,"context_line":"        body \u003d json.loads(body)"},{"line_number":120,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def delete_group_type_specs_item(self, group_type_id, spec_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_f11d5973","line":120,"range":{"start_line":120,"start_character":30,"end_line":120,"end_character":33},"updated":"2017-12-07 00:09:50.000000000","message":"Should be 202 according to docs.","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"a6a05303c629ba02db1692bdd8dca9cc382a66f8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        put_body \u003d json.dumps(spec)"},{"line_number":118,"context_line":"        resp, body \u003d self.put(url, put_body)"},{"line_number":119,"context_line":"        body \u003d json.loads(body)"},{"line_number":120,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def delete_group_type_specs_item(self, group_type_id, spec_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_34172e48","line":120,"range":{"start_line":120,"start_character":30,"end_line":120,"end_character":33},"in_reply_to":"df87a7cf_f11d5973","updated":"2017-12-07 01:18:30.000000000","message":"The return code is indeed 200 in my test env. In other way, if the return code should be 202, the assertion for response status should fail.\nAnd I have proposed a patch to Cinder: https://review.openstack.org/#/c/525868/","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"}],"tempest/tests/lib/services/volume/v3/test_group_types_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4fa74a5760d38bd6a48ce210307da0ad4ac15d1d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            bytes_body,"},{"line_number":157,"context_line":"            group_type_id\u003d\"3fbbcccf-d058-4502-8844-6feeffdf4cb5\","},{"line_number":158,"context_line":"            spec_id\u003d\"key2\","},{"line_number":159,"context_line":"            spec\u003dspec)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_create_group_type_with_str_body(self):"},{"line_number":162,"context_line":"        self._test_create_group_type()"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_b10b5022","line":159,"updated":"2017-12-07 00:09:50.000000000","message":"status\u003d202 here according to docs.","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"a6a05303c629ba02db1692bdd8dca9cc382a66f8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            bytes_body,"},{"line_number":157,"context_line":"            group_type_id\u003d\"3fbbcccf-d058-4502-8844-6feeffdf4cb5\","},{"line_number":158,"context_line":"            spec_id\u003d\"key2\","},{"line_number":159,"context_line":"            spec\u003dspec)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_create_group_type_with_str_body(self):"},{"line_number":162,"context_line":"        self._test_create_group_type()"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_f42ea690","line":159,"in_reply_to":"df87a7cf_b10b5022","updated":"2017-12-07 01:18:30.000000000","message":"Ditto","commit_id":"2f5b306e547576f15483d10ffd421a149f675737"}]}