)]}'
{"doc/source/microversion_testing.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ecb24b06de2eeb2fca1f8e21733c0909f53127d","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"  * `2.62`_"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  .. _2.62: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id55"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"* Volume"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f6a8fd7_12bff9fb","line":351,"range":{"start_line":351,"start_character":12,"end_line":351,"end_character":95},"updated":"2018-04-17 08:30:32.000000000","message":"this link might change as 2.61 is merged but we can update this once nova patch is merged","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"fd96a15433de29fac9e95cdee2cade798c3816c8","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"  * `2.62`_"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"  .. _2.62: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id55"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"* Volume"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f6a8fd7_ae6a617d","line":351,"range":{"start_line":351,"start_character":12,"end_line":351,"end_character":95},"in_reply_to":"9f6a8fd7_12bff9fb","updated":"2018-04-17 14:53:05.000000000","message":"Done","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"69059632800e7feffdef8abbc186e022a14fa4da","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"  * `2.60`_"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"  .. _2.60: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id54"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"  * `2.63`_"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-rst","patch_set":37,"id":"5f7c97a3_da66c551","line":371,"updated":"2018-06-01 02:01:53.000000000","message":"heh, I just found this URL should be \"....#maximum_in_queens\" id54 is for 2.61. I think this should be fixed in a different patch, though.","commit_id":"a2dded90d81575f579982acee9ba88aeae68d25c"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"b42a01847154723d9da16f62b2ec9fad86764958","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"  * `2.63`_"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"  .. _2.63: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id56"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"* Volume"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-rst","patch_set":37,"id":"5f7c97a3_64757400","line":375,"range":{"start_line":375,"start_character":91,"end_line":375,"end_character":95},"updated":"2018-06-14 20:24:23.000000000","message":"This should now be #id57, so I\u0027ll update the prior one too.","commit_id":"a2dded90d81575f579982acee9ba88aeae68d25c"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ecb24b06de2eeb2fca1f8e21733c0909f53127d","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":199,"context_line":"    def test_show_server(self):"},{"line_number":200,"context_line":"        server \u003d self.create_test_server("},{"line_number":201,"context_line":"            trusted_image_certificates\u003d[\u0027test-cert-1\u0027, \u0027test-cert-2\u0027])"},{"line_number":202,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_92e9c981","line":202,"range":{"start_line":200,"start_character":0,"end_line":202,"end_character":53},"updated":"2018-04-17 08:30:32.000000000","message":"this is covering only get server schema. can you do update, rebuild and then list details also here","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"fd96a15433de29fac9e95cdee2cade798c3816c8","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":199,"context_line":"    def test_show_server(self):"},{"line_number":200,"context_line":"        server \u003d self.create_test_server("},{"line_number":201,"context_line":"            trusted_image_certificates\u003d[\u0027test-cert-1\u0027, \u0027test-cert-2\u0027])"},{"line_number":202,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_ee85b9ae","line":202,"range":{"start_line":200,"start_character":0,"end_line":202,"end_character":53},"in_reply_to":"9f6a8fd7_92e9c981","updated":"2018-04-17 14:53:05.000000000","message":"Done","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"b446917a44db0e313da0feb98de53f663504a92d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Update the server"},{"line_number":218,"context_line":"        self.servers_client.update_server(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        waiters.wait_for_server_status(self.client, server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Verify that the updated server still contains the original trusted"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_8eb50bd0","line":218,"updated":"2018-04-18 04:16:13.000000000","message":"This currently fails because [1]:\n\n  HTTP response body is invalid (Additional properties are not allowed (u\u0027locked\u0027, u\u0027tags\u0027 were unexpected)\n\nI think an update schema needs to be added to the 2.9 (locked) and 2.26 (tags) compute response schema. Should that be added in a separate patch prior to this patch merging?\n\n[1] http://logs.openstack.org/85/526485/24/check/tempest-full/a298020/testr_results.html.gz","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae6f2c132cf218501023cf7ec847a8d37c099f57","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Update the server"},{"line_number":218,"context_line":"        self.servers_client.update_server(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        waiters.wait_for_server_status(self.client, server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Verify that the updated server still contains the original trusted"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_1c3331f8","line":218,"in_reply_to":"9f6a8fd7_8eb50bd0","updated":"2018-04-20 08:24:25.000000000","message":"yea, update_schema are too out dated. let me fix it quickly.","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"b446917a44db0e313da0feb98de53f663504a92d","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # List servers with the specified trusted image certificate IDs"},{"line_number":275,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":276,"context_line":"        body \u003d self.servers_client.list_servers(detail\u003dTrue, **params)"},{"line_number":277,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Assert that our server is in the list of servers"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_ce3463fe","line":276,"updated":"2018-04-18 04:16:13.000000000","message":"This currently fails because [1]:\n\n  HTTP response body is invalid (\u0027id\u0027 is a required property\n  .\n  .\n  .\n  On instance[\u0027servers\u0027][0][\u0027flavor\u0027]:\n    {u\u0027disk\u0027: 0,\n     u\u0027ephemeral\u0027: 0,\n     u\u0027extra_specs\u0027: {},\n     u\u0027original_name\u0027: u\u0027m1.nano\u0027,\n     u\u0027ram\u0027: 64,\n     u\u0027swap\u0027: 0,\n     u\u0027vcpus\u0027: 1})\n\nIt looks like microversion 2.52 never updated tempest\u0027s compute response schemas to reflect the changes made to the flavor parameter. Should that be added in a separate patch before this one is merged?\n\n[1] http://logs.openstack.org/85/526485/24/check/tempest-full/a298020/testr_results.html.gz\n[2] https://github.com/openstack/nova/blob/master/doc/api_samples/servers/v2.52/servers-details-resp.json","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"efe896cb74983a7057d00e3e904b50d0785261cd","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # List servers with the specified trusted image certificate IDs"},{"line_number":275,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":276,"context_line":"        body \u003d self.servers_client.list_servers(detail\u003dTrue, **params)"},{"line_number":277,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Assert that our server is in the list of servers"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_53aaea70","line":276,"in_reply_to":"9f6a8fd7_3c5e3512","updated":"2018-04-20 18:06:29.000000000","message":"I think this will still fail. Microversion 2.52\u0027s list_servers_detail needs to be updated.","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bc722876e6af5db604906e280e3c466f85717ab1","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # List servers with the specified trusted image certificate IDs"},{"line_number":275,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":276,"context_line":"        body \u003d self.servers_client.list_servers(detail\u003dTrue, **params)"},{"line_number":277,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Assert that our server is in the list of servers"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_77d4ac20","line":276,"in_reply_to":"9f6a8fd7_53aaea70","updated":"2018-04-22 10:57:39.000000000","message":"yeah, filling those one by one. actually we should do those at the end of each cycle but did not do in queens. But before your nova patch, we will fix all schema in tempest.","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37eed2537870a7e451df374b6284a7fbdd52fabc","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # List servers with the specified trusted image certificate IDs"},{"line_number":275,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":276,"context_line":"        body \u003d self.servers_client.list_servers(detail\u003dTrue, **params)"},{"line_number":277,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Assert that our server is in the list of servers"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_6ce37eda","line":276,"in_reply_to":"9f6a8fd7_77d4ac20","updated":"2018-04-23 03:22:01.000000000","message":"2.52 only added tag in POST servers API request. Response things are all handled in 2.26 schema.","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae6f2c132cf218501023cf7ec847a8d37c099f57","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # List servers with the specified trusted image certificate IDs"},{"line_number":275,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":276,"context_line":"        body \u003d self.servers_client.list_servers(detail\u003dTrue, **params)"},{"line_number":277,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Assert that our server is in the list of servers"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f6a8fd7_3c5e3512","line":276,"in_reply_to":"9f6a8fd7_ce3463fe","updated":"2018-04-20 08:24:25.000000000","message":"I think it is rebuild right? fixing this too","commit_id":"501ff0af6fc7b7429f67753605d5e7089594e437"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4aaafb4cf4b9360ba149375918b09121c76ae531","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    min_microversion \u003d \u00272.62\u0027"},{"line_number":196,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u002771b8e3d5-11d2-494f-b917-b094a4afed3c\u0027)"},{"line_number":199,"context_line":"    def test_show_server(self):"},{"line_number":200,"context_line":"        trusted_certs \u003d [\u0027test-cert-1\u0027, \u0027test-cert-2\u0027]"},{"line_number":201,"context_line":"        server \u003d self.create_test_server("},{"line_number":202,"context_line":"            trusted_image_certificates\u003dtrusted_certs,"},{"line_number":203,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":204,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Verify that server shows correct trusted image certificate IDs"},{"line_number":207,"context_line":"        self.assertEqual(trusted_certs, server[\u0027trusted_image_certificates\u0027])"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u002753a8dfa0-a9cc-4d14-b536-2d289dca9ab6\u0027)"},{"line_number":210,"context_line":"    def test_update_server(self):"},{"line_number":211,"context_line":"        trusted_certs \u003d [\u0027test-cert-1\u0027, \u0027test-cert-2\u0027]"},{"line_number":212,"context_line":"        server \u003d self.create_test_server("},{"line_number":213,"context_line":"            trusted_image_certificates\u003dtrusted_certs,"},{"line_number":214,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # Update the server"},{"line_number":217,"context_line":"        self.servers_client.update_server(server[\u0027id\u0027])"},{"line_number":218,"context_line":"        waiters.wait_for_server_status(self.client, server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Verify that updated server shows original trusted certificate IDs"},{"line_number":221,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":222,"context_line":"        self.assertEqual(trusted_certs, server[\u0027trusted_image_certificates\u0027])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u00277580e321-3123-4c80-bf7f-e2ceaa201909\u0027)"},{"line_number":225,"context_line":"    def test_rebuild_server(self):"},{"line_number":226,"context_line":"        trusted_certs \u003d [\u0027test-cert-1\u0027, \u0027test-cert-2\u0027]"},{"line_number":227,"context_line":"        server \u003d self.create_test_server("},{"line_number":228,"context_line":"            trusted_image_certificates\u003dtrusted_certs,"},{"line_number":229,"context_line":"            image_id\u003dself.image_ref_alt,"},{"line_number":230,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        # Rebuild the server"},{"line_number":233,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":234,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":235,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Verify that rebuilt server shows original trusted certificate IDs"},{"line_number":238,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":239,"context_line":"        self.assertEqual(trusted_certs, server[\u0027trusted_image_certificates\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00278612c015-6564-43cc-9ecb-077f8f571f27\u0027)"},{"line_number":242,"context_line":"    def test_rebuild_server_with_new_trusted_certs(self):"},{"line_number":243,"context_line":"        orig_trusted_certs \u003d [\u0027orig-test-cert-1\u0027, \u0027orig-test-cert-2\u0027]"},{"line_number":244,"context_line":"        new_trusted_certs \u003d [\u0027new-test-cert-1\u0027, \u0027new-test-cert-2\u0027]"},{"line_number":245,"context_line":"        server \u003d self.create_test_server("},{"line_number":246,"context_line":"            trusted_image_certificates\u003dorig_trusted_certs,"},{"line_number":247,"context_line":"            image_id\u003dself.image_ref_alt,"},{"line_number":248,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Rebuild the server with new trusted image certificate IDs"},{"line_number":251,"context_line":"        self.servers_client.rebuild_server("},{"line_number":252,"context_line":"            server[\u0027id\u0027], self.image_ref_alt,"},{"line_number":253,"context_line":"            trusted_image_certificates\u003dnew_trusted_certs)"},{"line_number":254,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":255,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # Verify that the trusted image certificate IDs have been updated"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f6a8fd7_5cfbe977","line":254,"range":{"start_line":198,"start_character":1,"end_line":254,"end_character":59},"updated":"2018-04-20 08:52:50.000000000","message":"let\u0027s just add single test here to cover the schema part only as we are not testing the integrated functionality here. something like - https://review.openstack.org/#/c/562989/1/tempest/api/compute/servers/test_servers.py\n\nif you are planing any integrated test then those can be separate tests.","commit_id":"8844f208e4171d26ac5a0bab345171a93ecdaa7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"caa0a3030a5e47b42eeec05476084683f121be7c","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Check update API response schema"},{"line_number":229,"context_line":"        self.servers_client.update_server(server[\u0027id\u0027])"},{"line_number":230,"context_line":"        waiters.wait_for_server_status(self.client, server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        # Check rebuild API response schema"},{"line_number":233,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9f6a8fd7_45b9adc9","line":230,"range":{"start_line":230,"start_character":44,"end_line":230,"end_character":50},"updated":"2018-04-23 08:17:37.000000000","message":"servers_client","commit_id":"5724c9402255448421455580533db4367fdeae01"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"55e2f291932d203db4826a3b68e85d7a0e40f2b2","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        # Check rebuild API response schema"},{"line_number":234,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":235,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":236,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9f6a8fd7_d4e1df9c","line":234,"updated":"2018-04-23 17:36:13.000000000","message":"This fails [1] because we\u0027re missing `user_data` (added in 2.57 [2]) and `key_name` (added in 2.54 [3]) from the rebuild response schema.\n\n[1] http://logs.openstack.org/85/526485/30/check/tempest-full/2385d5d/testr_results.html.gz\n\n[2] https://github.com/openstack/nova/blob/master/releasenotes/notes/bp-deprecate-file-injection-feaf490524d10b3d.yaml\n\n[3] https://github.com/openstack/nova/blob/master/releasenotes/notes/bp-rebuild-keypair-reset-9ed45744bd85e358.yaml","commit_id":"3cd17bf1691a41efff6874cce4c9dcf4672c7b23"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"9da828b58c811dcb0aedb278ba66fca948203edd","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        # Check rebuild API response schema"},{"line_number":234,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":235,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":236,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9f6a8fd7_62536318","line":234,"in_reply_to":"9f6a8fd7_3892804d","updated":"2018-04-24 12:52:17.000000000","message":"Perfect, thanks!","commit_id":"3cd17bf1691a41efff6874cce4c9dcf4672c7b23"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a4565515d4bafeb06cb1b2ba0ff5e4199e27659","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        # Check rebuild API response schema"},{"line_number":234,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":235,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":236,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9f6a8fd7_3892804d","line":234,"in_reply_to":"9f6a8fd7_d4e1df9c","updated":"2018-04-24 08:43:04.000000000","message":"yeah, added here - https://review.openstack.org/#/c/563856/","commit_id":"3cd17bf1691a41efff6874cce4c9dcf4672c7b23"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1aa4e222bde222bdf7dd39110a753514a4fdd23e","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Check list details API response schema"},{"line_number":239,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":240,"context_line":"        self.servers_client.list_servers(detail\u003dTrue, **params)"}],"source_content_type":"text/x-python","patch_set":37,"id":"5f7c97a3_85b51781","line":240,"updated":"2018-06-05 02:12:00.000000000","message":"Why not add an assertion here to check the servers returned isn\u0027t empty, i.e.:\n\n    servers \u003d self.servers_client.list_servers(detail\u003dTrue, **params)[\u0027servers\u0027]\n    self.assertNotEmpty(servers)\n\nAs I think the schema just checks the attributes of each object, not whether the actual list contains objects.","commit_id":"a2dded90d81575f579982acee9ba88aeae68d25c"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"b42a01847154723d9da16f62b2ec9fad86764958","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Check list details API response schema"},{"line_number":239,"context_line":"        params \u003d {\u0027trusted_image_certificates\u0027: trusted_certs}"},{"line_number":240,"context_line":"        self.servers_client.list_servers(detail\u003dTrue, **params)"}],"source_content_type":"text/x-python","patch_set":37,"id":"5f7c97a3_8f2f893d","line":240,"in_reply_to":"5f7c97a3_85b51781","updated":"2018-06-14 20:24:23.000000000","message":"Done","commit_id":"a2dded90d81575f579982acee9ba88aeae68d25c"}],"tempest/lib/api_schema/response/compute/v2_62/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ecb24b06de2eeb2fca1f8e21733c0909f53127d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_19 import servers as servers219"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_26 import servers as servers226"},{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_48 import servers as servers248"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Nova microversion 2.62 adds \u0027trusted_image_certificates\u0027 (a list of"},{"line_number":20,"context_line":"# certificate IDs) to the server rebuild and servers details responses."}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_920ea9e3","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":50},"updated":"2018-04-17 08:30:32.000000000","message":"there is no change in get_server in v2_48, you can use v2_47 here which is latest schema for get_server","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"fd96a15433de29fac9e95cdee2cade798c3816c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_19 import servers as servers219"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_26 import servers as servers226"},{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_48 import servers as servers248"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Nova microversion 2.62 adds \u0027trusted_image_certificates\u0027 (a list of"},{"line_number":20,"context_line":"# certificate IDs) to the server rebuild and servers details responses."}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_2e2df142","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":50},"in_reply_to":"9f6a8fd7_920ea9e3","updated":"2018-04-17 14:53:05.000000000","message":"Got it, thanks for pointing that out!","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5ecb24b06de2eeb2fca1f8e21733c0909f53127d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":43,"context_line":"    \u0027properties\u0027].update({\u0027trusted_image_certificates\u0027: trusted_certs})"},{"line_number":44,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":45,"context_line":"    \u0027required\u0027].append(\u0027trusted_image_certificates\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":48,"context_line":"    servers219.rebuild_server_with_admin_pass)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_52d011f8","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":52},"updated":"2018-04-17 08:30:32.000000000","message":"you need to add update_server schema also as 2.62 change response of PUT servers/ API also","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"fd96a15433de29fac9e95cdee2cade798c3816c8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":43,"context_line":"    \u0027properties\u0027].update({\u0027trusted_image_certificates\u0027: trusted_certs})"},{"line_number":44,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":45,"context_line":"    \u0027required\u0027].append(\u0027trusted_image_certificates\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":48,"context_line":"    servers219.rebuild_server_with_admin_pass)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_8e775d3b","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":52},"in_reply_to":"9f6a8fd7_52d011f8","updated":"2018-04-17 14:53:05.000000000","message":"Good catch. I\u0027ll add in the next patch.","commit_id":"4b71c36ba3e7f3abdc4459138a4e8d20d09ded1a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4aaafb4cf4b9360ba149375918b09121c76ae531","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_19 import servers as servers219"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_26 import servers as servers226"},{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_47 import servers as servers247"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Nova microversion 2.62 adds \u0027trusted_image_certificates\u0027 (a list of"},{"line_number":20,"context_line":"# certificate IDs) to the server rebuild and servers details responses."}],"source_content_type":"text/x-python","patch_set":26,"id":"9f6a8fd7_dc2cd903","line":17,"range":{"start_line":17,"start_character":69,"end_line":17,"end_character":79},"updated":"2018-04-20 08:52:50.000000000","message":"this should be base schema after this patch - https://review.openstack.org/#/c/562989/","commit_id":"8844f208e4171d26ac5a0bab345171a93ecdaa7a"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"289bca1763b43411ec08ac770e18d37ee3f50dd3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        {\u0027min\u0027: \u00272.19\u0027, \u0027max\u0027: \u00272.25\u0027, \u0027schema\u0027: schemav219},"},{"line_number":49,"context_line":"        {\u0027min\u0027: \u00272.26\u0027, \u0027max\u0027: \u00272.46\u0027, \u0027schema\u0027: schemav226},"},{"line_number":50,"context_line":"        {\u0027min\u0027: \u00272.47\u0027, \u0027max\u0027: \u00272.47\u0027, \u0027schema\u0027: schemav247},"},{"line_number":51,"context_line":"        {\u0027min\u0027: \u00272.48\u0027, \u0027max\u0027: \u00272.53\u0027, \u0027schema\u0027: schemav248},"},{"line_number":52,"context_line":"        {\u0027min\u0027: \u00272.57\u0027, \u0027max\u0027: None, \u0027schema\u0027: schemav257}]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, auth_provider, service, region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_4b8c7635","line":51,"range":{"start_line":51,"start_character":32,"end_line":51,"end_character":36},"updated":"2017-12-07 19:35:41.000000000","message":"This should be 2.56. This will be fixed in the next patch.","commit_id":"5ffe8e9346d269d975b8592165bc765ad9db9a36"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"8512310ff9d7befb1881f86e6b1bfef02fe06008","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            url +\u003d \u0027/detail\u0027"},{"line_number":164,"context_line":"            _schema \u003d schema.list_servers_detail"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            _schema \u003d schema.list_servers"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if params:"},{"line_number":169,"context_line":"            url +\u003d \u0027?%s\u0027 % urllib.urlencode(params)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f6a8fd7_73042518","line":166,"updated":"2018-04-17 21:43:25.000000000","message":"This had to be moved into an else-block because we were error-ing out if a list_servers_detail schema exists without a list_servers schema:\nhttp://logs.openstack.org/85/526485/21/check/tempest-full/3ac1f45/testr_results.html.gz\n\nAlternatively, we could split this out into a different patch.","commit_id":"01178846a75d462ae6374f334bb572444ea3da4c"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"8af985f9d75c00c53af9b41bf92497a89b80782f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            url +\u003d \u0027/detail\u0027"},{"line_number":164,"context_line":"            _schema \u003d schema.list_servers_detail"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            _schema \u003d schema.list_servers"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if params:"},{"line_number":169,"context_line":"            url +\u003d \u0027?%s\u0027 % urllib.urlencode(params)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f6a8fd7_bf9effb5","line":166,"in_reply_to":"9f6a8fd7_73042518","updated":"2018-04-17 21:49:08.000000000","message":"Oops, nevermind! I just updated the api_schema in tempest.lib.api_schema. This change has been reverted.","commit_id":"01178846a75d462ae6374f334bb572444ea3da4c"}]}