)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"347d48c2ce6ed27b580635ce2118f6fe0a6c9e67","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    clients.servers_client, server[\u0027id\u0027], wait_until)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"                # Multiple validatable servers are not supported for now. Their"},{"line_number":232,"context_line":"                # creation will fail with the condition above (l.58)."},{"line_number":233,"context_line":"                if CONF.validation.run_validation and validatable:"},{"line_number":234,"context_line":"                    if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":235,"context_line":"                        _setup_validation_fip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_f6ce8558","side":"PARENT","line":232,"range":{"start_line":232,"start_character":62,"end_line":232,"end_character":67},"updated":"2017-12-08 09:14:26.000000000","message":"Yeah, it\u0027s really confusing.\nAnd I am also confused with all these two lines, since in Line 129 we have raised ValueError, why we need the comment here?","commit_id":"6dd6fc66d8a04bdba8063f34244e7db2f70a7251"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"efa240320acb0555db905304a45cb27c8cf5bc25","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    clients.servers_client, server[\u0027id\u0027], wait_until)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"                # Multiple validatable servers are not supported for now. Their"},{"line_number":232,"context_line":"                # creation will fail with the condition above (l.58)."},{"line_number":233,"context_line":"                if CONF.validation.run_validation and validatable:"},{"line_number":234,"context_line":"                    if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":235,"context_line":"                        _setup_validation_fip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_d7d2845c","side":"PARENT","line":232,"range":{"start_line":232,"start_character":62,"end_line":232,"end_character":67},"in_reply_to":"df87a7cf_f6ce8558","updated":"2017-12-18 08:06:09.000000000","message":"I guess this comment indicate that we don\u0027t need to care about multiple_create_request or not here because we already checked it above. I think this comment style is not good because we may remove the above code in the future.\n\nSo, I feel a better way is refactoring this create_test_server() method to remove the dependency. But it\u0027s not so easy. So, here, just removing the line number of the code at least.","commit_id":"6dd6fc66d8a04bdba8063f34244e7db2f70a7251"}]}
