)]}'
{"tempest/api/volume/admin/test_snapshot_manage.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8f2536d9fc14016be0c4655aed5226dc86d9c326","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(SnapshotManageAdminTest, cls).skip_checks()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if not CONF.volume_feature_enabled.snapshot:"},{"line_number":39,"context_line":"            raise cls.skipException(\"Cinder volume snapshots are disabled\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if not CONF.volume_feature_enabled.manage_snapshot:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_784a9327","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":51},"updated":"2017-12-18 05:17:13.000000000","message":"Will someone set snapshot \u003d False while setting manage_snapshot \u003d True?","commit_id":"b134589333c9c0793454a5082b095d38152f22f2"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6ec6231aa441518c49b04b57cbca5287c74c6014","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(SnapshotManageAdminTest, cls).skip_checks()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if not CONF.volume_feature_enabled.snapshot:"},{"line_number":39,"context_line":"            raise cls.skipException(\"Cinder volume snapshots are disabled\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if not CONF.volume_feature_enabled.manage_snapshot:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_fa652db6","line":38,"updated":"2017-12-18 09:00:30.000000000","message":"Yeah, I think it might be a misconfiguration of Tempest. So, I feel it should be failed not skipped.. But it shouldn\u0027t be checked here but in config.py or the other suitable place.","commit_id":"b134589333c9c0793454a5082b095d38152f22f2"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"2219e2639d6fabc5484799f4ce4786a44e8d230a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(SnapshotManageAdminTest, cls).skip_checks()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if not CONF.volume_feature_enabled.snapshot:"},{"line_number":39,"context_line":"            raise cls.skipException(\"Cinder volume snapshots are disabled\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if not CONF.volume_feature_enabled.manage_snapshot:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_51e76413","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":51},"in_reply_to":"df87a7cf_784a9327","updated":"2017-12-18 05:49:57.000000000","message":"It may be, as they are two different settings, although setting like this is not reasonable.","commit_id":"b134589333c9c0793454a5082b095d38152f22f2"}]}