)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"aef36a074aae4850e6c152d84aea02de1f68ed37","unresolved":false,"context_lines":[{"line_number":10,"context_line":"while trying to delete a cg-snapshot that is based on an"},{"line_number":11,"context_line":"updated volume group the cg-snapshot stuck in deleting status."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://bugs.launchpad.net/cinder/+bug/1739031"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I70997acdf5d0e962ba863c3410ef0b13c195807e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_4fe4670d","line":13,"updated":"2017-12-20 01:39:35.000000000","message":"I guess you wanted to use \u0027Related-Bug:\u0027 directive here.","commit_id":"8d1b30eb9c410fe29a98202b1b32d26ab4dfb2bb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d73bc14b66f354260ec863726e1d764791825442","unresolved":false,"context_lines":[{"line_number":10,"context_line":"while trying to delete a cg-snapshot that is based on an"},{"line_number":11,"context_line":"updated volume group the cg-snapshot stuck in deleting status."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://bugs.launchpad.net/cinder/+bug/1739031"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I70997acdf5d0e962ba863c3410ef0b13c195807e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_ba0a0ecf","line":13,"in_reply_to":"df87a7cf_4fe4670d","updated":"2017-12-20 10:39:02.000000000","message":"Right, thanks","commit_id":"8d1b30eb9c410fe29a98202b1b32d26ab4dfb2bb"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"476c5b4e53cb70262c4c4ee90617aacf7538cdca","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: When dealing with consistency groups all volumes must"},{"line_number":14,"context_line":"reside on the same backend. Adding volumes to the same consistency"},{"line_number":15,"context_line":"group from multiple backends isn\u0027t supported. In order to insure all"},{"line_number":16,"context_line":"volumes share the same backend, all volumes must share same"},{"line_number":17,"context_line":"volume-type and group id."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f7c97a3_e9024b6f","line":15,"range":{"start_line":15,"start_character":58,"end_line":15,"end_character":64},"updated":"2018-05-24 07:02:53.000000000","message":"You probably mean \"ensure\" [1]\n\n[1] https://www.vocabulary.com/articles/chooseyourwords/assure-ensure-insure/","commit_id":"2e937f282dc23fbfe248896189dae8269713f352"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"501b0e8d1ad50afe9ff03a4abc3e68d12bfac3cc","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: When dealing with consistency groups all volumes must"},{"line_number":14,"context_line":"reside on the same backend. Adding volumes to the same consistency"},{"line_number":15,"context_line":"group from multiple backends isn\u0027t supported. In order to insure all"},{"line_number":16,"context_line":"volumes share the same backend, all volumes must share same"},{"line_number":17,"context_line":"volume-type and group id."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f7c97a3_2966032b","line":15,"range":{"start_line":15,"start_character":58,"end_line":15,"end_character":64},"in_reply_to":"5f7c97a3_e9024b6f","updated":"2018-05-24 07:30:29.000000000","message":"You\u0027re right thanks :)","commit_id":"2e937f282dc23fbfe248896189dae8269713f352"}],"tempest/api/volume/admin/test_group_snapshots.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"aef36a074aae4850e6c152d84aea02de1f68ed37","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":158,"context_line":"            self.groups_client, grp2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00277d7fc000-0b4c-4376-a372-544116d2e127\u0027)"},{"line_number":161,"context_line":"    def test_delete_group_snapshots_following_updated_volumes(self):"},{"line_number":162,"context_line":"        # Create volume type"},{"line_number":163,"context_line":"        volume_type \u003d self.create_volume_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_8fdeef3b","line":160,"updated":"2017-12-20 01:39:35.000000000","message":"We actually have \u0027@decorators.related_bug()\u0027 decorator. I think we can use it here.","commit_id":"8d1b30eb9c410fe29a98202b1b32d26ab4dfb2bb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d73bc14b66f354260ec863726e1d764791825442","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":158,"context_line":"            self.groups_client, grp2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00277d7fc000-0b4c-4376-a372-544116d2e127\u0027)"},{"line_number":161,"context_line":"    def test_delete_group_snapshots_following_updated_volumes(self):"},{"line_number":162,"context_line":"        # Create volume type"},{"line_number":163,"context_line":"        volume_type \u003d self.create_volume_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_5a0bc2d3","line":160,"in_reply_to":"df87a7cf_8fdeef3b","updated":"2017-12-20 10:39:02.000000000","message":"Done","commit_id":"8d1b30eb9c410fe29a98202b1b32d26ab4dfb2bb"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"aef36a074aae4850e6c152d84aea02de1f68ed37","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # Create group type"},{"line_number":166,"context_line":"        group_type \u003d self.create_group_type()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # Create Group"},{"line_number":169,"context_line":"        grp \u003d self.create_group(group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":170,"context_line":"                                volume_types\u003d[volume_type[\u0027id\u0027]])"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_2fe7a314","line":168,"updated":"2017-12-20 01:39:35.000000000","message":"I feel these three comments are just duplicated to the method names.","commit_id":"8d1b30eb9c410fe29a98202b1b32d26ab4dfb2bb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8f0eb6916b99241d00629b4ad886a120b12c0d9b","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00277d7fc000-0b4c-4376-a372-544116d2e127\u0027)"},{"line_number":161,"context_line":"    @decorators.related_bug(\u00271739031\u0027)"},{"line_number":162,"context_line":"    def test_delete_group_snapshots_following_updated_volumes(self):"},{"line_number":163,"context_line":"        volume_type \u003d self.create_volume_type()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        group_type \u003d self.create_group_type()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_127dcab0","line":162,"range":{"start_line":162,"start_character":13,"end_line":162,"end_character":61},"updated":"2017-12-21 01:28:07.000000000","message":"Sorry a silly question: where is the \"delete\" operation in this testcase? and what does \"updated volumes\" mean?","commit_id":"6d889bf1de774ccfaa8db1ac472930394f9c2432"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"33fbfec16d86728d7be3f9ba708fb916d0ef8230","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00277d7fc000-0b4c-4376-a372-544116d2e127\u0027)"},{"line_number":161,"context_line":"    @decorators.related_bug(\u00271739031\u0027)"},{"line_number":162,"context_line":"    def test_delete_group_snapshots_following_updated_volumes(self):"},{"line_number":163,"context_line":"        volume_type \u003d self.create_volume_type()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        group_type \u003d self.create_group_type()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_01749634","line":162,"range":{"start_line":162,"start_character":13,"end_line":162,"end_character":61},"in_reply_to":"bf8cb3f7_127dcab0","updated":"2017-12-21 06:29:45.000000000","message":"\"updated volumes\" means associate volumes to group(L177-L178).\nThe \"_create_group_snapshot\"(L189) method preforms the \"delete\" operation(L49).\nIf you could suggest a better name for the testcase I\u0027ll be happy to change.","commit_id":"6d889bf1de774ccfaa8db1ac472930394f9c2432"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d7729b1871b419ff151b9b3a58aedf3f7158d12d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            grp_params \u003d {\u0027add_volumes\u0027: volume_list[vol][\u0027id\u0027]}"},{"line_number":178,"context_line":"            self.groups_client.update_group(grp[\u0027id\u0027], **grp_params)"},{"line_number":179,"context_line":"            # Wait for group status to become available"},{"line_number":180,"context_line":"            waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_95d9c084","line":177,"range":{"start_line":177,"start_character":41,"end_line":177,"end_character":63},"updated":"2018-03-08 01:58:03.000000000","message":"nit: How about just\n\n volume[\u0027id\u0027]\n\ninstead of using volume_list[vol][\u0027id\u0027]?\nIt was a little difficult to read for me.","commit_id":"600333ac474d7dfa4a298a517bb0669e530fdda4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14e1e8ebab1177f195c81c4312bf9bee2448e301","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            grp_params \u003d {\u0027add_volumes\u0027: volume_list[vol][\u0027id\u0027]}"},{"line_number":178,"context_line":"            self.groups_client.update_group(grp[\u0027id\u0027], **grp_params)"},{"line_number":179,"context_line":"            # Wait for group status to become available"},{"line_number":180,"context_line":"            waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_4f02adb6","line":177,"range":{"start_line":177,"start_character":41,"end_line":177,"end_character":63},"in_reply_to":"df7087c5_95d9c084","updated":"2018-03-08 09:28:49.000000000","message":"Thanks for your comments,\nI\u0027ll do it","commit_id":"600333ac474d7dfa4a298a517bb0669e530fdda4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d7729b1871b419ff151b9b3a58aedf3f7158d12d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_95c22085","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":48},"updated":"2018-03-08 01:58:03.000000000","message":"Isn\u0027t an error if this condition is not?\nThat means I guessed\n\n else:\n\ncondition should raise an exception, is that wrong?","commit_id":"600333ac474d7dfa4a298a517bb0669e530fdda4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14e1e8ebab1177f195c81c4312bf9bee2448e301","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_6fff71aa","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":48},"in_reply_to":"df7087c5_95c22085","updated":"2018-03-08 09:28:49.000000000","message":"I don\u0027t sure, because in case there are some snapshots from other tests that somehow have not been deleted, the test will fail.\nWhat do you think?","commit_id":"600333ac474d7dfa4a298a517bb0669e530fdda4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"cb707d8863a451e9f7bf59fda3fcf7a7b3cda472","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Create 2 volumes and add them to the newly created consistency group"},{"line_number":172,"context_line":"        volume_list \u003d []"},{"line_number":173,"context_line":"        for vol in range(2):"},{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_563f8124","line":173,"range":{"start_line":173,"start_character":12,"end_line":173,"end_character":15},"updated":"2018-03-27 11:09:53.000000000","message":"Please use _ as a name for unused variables.\n\n  for _ in range(2):","commit_id":"50156c16a2f78e2077b754c83d1edef7fbdc24c4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9230736bcd7b506d06eb5f6e06005ad7560e9838","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Create 2 volumes and add them to the newly created consistency group"},{"line_number":172,"context_line":"        volume_list \u003d []"},{"line_number":173,"context_line":"        for vol in range(2):"},{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_d8173b45","line":173,"range":{"start_line":173,"start_character":12,"end_line":173,"end_character":15},"in_reply_to":"bf659307_563f8124","updated":"2018-03-27 13:56:38.000000000","message":"Thanks for your comments,\nDone","commit_id":"50156c16a2f78e2077b754c83d1edef7fbdc24c4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"cb707d8863a451e9f7bf59fda3fcf7a7b3cda472","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            grp_params \u003d {\u0027add_volumes\u0027: volume[\u0027id\u0027]}"},{"line_number":178,"context_line":"            self.groups_client.update_group(grp[\u0027id\u0027], **grp_params)"},{"line_number":179,"context_line":"            # Wait for group status to become available"},{"line_number":180,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":181,"context_line":"                self.groups_client, grp[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_76688520","line":178,"range":{"start_line":177,"start_character":12,"end_line":178,"end_character":68},"updated":"2018-03-27 11:09:53.000000000","message":"Grp params looks to be used only here. Below code looks simpler to me:\n\n  self.groups_client.update_group(grp[\u0027id\u0027], add_volumes\u003dvolume[\u0027id\u0027])","commit_id":"50156c16a2f78e2077b754c83d1edef7fbdc24c4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9230736bcd7b506d06eb5f6e06005ad7560e9838","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027])"},{"line_number":175,"context_line":"            volume_list.append(volume)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            grp_params \u003d {\u0027add_volumes\u0027: volume[\u0027id\u0027]}"},{"line_number":178,"context_line":"            self.groups_client.update_group(grp[\u0027id\u0027], **grp_params)"},{"line_number":179,"context_line":"            # Wait for group status to become available"},{"line_number":180,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":181,"context_line":"                self.groups_client, grp[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_78286f85","line":178,"range":{"start_line":177,"start_character":12,"end_line":178,"end_character":68},"in_reply_to":"bf659307_76688520","updated":"2018-03-27 13:56:38.000000000","message":"Done","commit_id":"50156c16a2f78e2077b754c83d1edef7fbdc24c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa755a5bb54cd1e3562df1263ce121e86d7571b1","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class GroupSnapshotsV319Test(BaseGroupSnapshotsTest):"},{"line_number":199,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f6a8fd7_f7567c5c","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":0},"updated":"2018-04-22 12:37:12.000000000","message":"as test is mainly for deleting the cg-snapshot, can you try to delete the created snapshot here explicitly using _delete_group_snapshot(). testing snapshot using addCleanup is not perfect way.","commit_id":"aafa91a66f6bc4f00b2b350b088ce52b97194202"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d86e5c0810b9d31daaeb1d88b5230c9253d42b04","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class GroupSnapshotsV319Test(BaseGroupSnapshotsTest):"},{"line_number":199,"context_line":"    _api_version \u003d 3"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f6a8fd7_321f225c","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":0},"in_reply_to":"9f6a8fd7_f7567c5c","updated":"2018-04-22 13:15:01.000000000","message":"Done","commit_id":"aafa91a66f6bc4f00b2b350b088ce52b97194202"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"b044e64de6e34ea6eb83a9873975ea8118f68b84","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f6a8fd7_9b6ac27e","line":193,"range":{"start_line":193,"start_character":15,"end_line":193,"end_character":47},"updated":"2018-04-23 09:35:30.000000000","message":"I guess volume_list contains dictionaries and not volumes IDs, therefore this is going to be always false. I am wrong?","commit_id":"c9e1620054986096fc71db3ba8f87f3353c81430"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87bf2a29256759d71a7109826103d39285497a3e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f6a8fd7_b671dd46","line":193,"range":{"start_line":193,"start_character":15,"end_line":193,"end_character":47},"in_reply_to":"9f6a8fd7_9b6ac27e","updated":"2018-04-23 10:26:58.000000000","message":"Right, thanks for your vigilance :)","commit_id":"c9e1620054986096fc71db3ba8f87f3353c81430"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"b044e64de6e34ea6eb83a9873975ea8118f68b84","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Delete a snapshot group"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f6a8fd7_9bbc0207","line":194,"updated":"2018-04-23 09:35:30.000000000","message":"Are you sure it even enter here? Can you please somehow check it happens?","commit_id":"c9e1620054986096fc71db3ba8f87f3353c81430"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87bf2a29256759d71a7109826103d39285497a3e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":192,"context_line":"        for snap in snapshots:"},{"line_number":193,"context_line":"            if snap[\u0027volume_id\u0027] in volume_list:"},{"line_number":194,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":195,"context_line":"                    self.snapshots_client, snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Delete a snapshot group"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f6a8fd7_160be97c","line":194,"in_reply_to":"9f6a8fd7_9bbc0207","updated":"2018-04-23 10:26:58.000000000","message":"After the code repair it enters here, I verified it","commit_id":"c9e1620054986096fc71db3ba8f87f3353c81430"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"476c5b4e53cb70262c4c4ee90617aacf7538cdca","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Note: When dealing with consistency groups all volumes must"},{"line_number":172,"context_line":"        # reside on the same backend. Adding volumes to the same consistency"},{"line_number":173,"context_line":"        # group from multiple backends isn\u0027t supported. In order to insure all"},{"line_number":174,"context_line":"        # volumes share the same backend, all volumes must share same"},{"line_number":175,"context_line":"        # volume-type and group id."},{"line_number":176,"context_line":"        volume_list \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_a939b33f","line":173,"range":{"start_line":173,"start_character":68,"end_line":173,"end_character":74},"updated":"2018-05-24 07:02:53.000000000","message":"Assure, ensure or insure [1]?\n\n[1] https://www.vocabulary.com/articles/chooseyourwords/assure-ensure-insure/","commit_id":"2e937f282dc23fbfe248896189dae8269713f352"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"501b0e8d1ad50afe9ff03a4abc3e68d12bfac3cc","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Note: When dealing with consistency groups all volumes must"},{"line_number":172,"context_line":"        # reside on the same backend. Adding volumes to the same consistency"},{"line_number":173,"context_line":"        # group from multiple backends isn\u0027t supported. In order to insure all"},{"line_number":174,"context_line":"        # volumes share the same backend, all volumes must share same"},{"line_number":175,"context_line":"        # volume-type and group id."},{"line_number":176,"context_line":"        volume_list \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_c96c2f0a","line":173,"range":{"start_line":173,"start_character":68,"end_line":173,"end_character":74},"in_reply_to":"5f7c97a3_a939b33f","updated":"2018-05-24 07:30:29.000000000","message":"Done","commit_id":"2e937f282dc23fbfe248896189dae8269713f352"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"77053d458acede66dffade149c4703a19b8124ab","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":191,"context_line":"                self.groups_client, grp[\u0027id\u0027], \u0027available\u0027)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # Verify the created volumes are associate to the consistency group"},{"line_number":194,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":195,"context_line":"        grp_vols \u003d [v for v in vols if v[\u0027group_id\u0027] \u003d\u003d grp[\u0027id\u0027]]"},{"line_number":196,"context_line":"        self.assertEqual(2, len(grp_vols))"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f7c97a3_321acb7c","line":193,"range":{"start_line":193,"start_character":41,"end_line":193,"end_character":53},"updated":"2018-06-11 04:37:16.000000000","message":"associated with","commit_id":"481bcea96e12e96fab120bccc57e907298247bc5"}]}