)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a4835fc0c221e12c89432ce5629cb6a653184e51","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add tests for show and update of Flavor Extra Spec API extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this adds positive and negative  tests for show and update atctions"},{"line_number":10,"context_line":"of FlavorExtra Spec API extension."},{"line_number":11,"context_line":"this checks the extends response attribute that added by all flavor"},{"line_number":12,"context_line":"extension API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FseM%3D","line":9,"updated":"2013-10-30 10:46:02.000000000","message":"atctions -\u003e actions","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"}],"tempest/api/compute/admin/test_flavors.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"72329ef14fdcf3121b7ef3354f569c0e09b56ed4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            self.assertEqual(int(flavor[\u0027rxtx_factor\u0027]), 1)"},{"line_number":165,"context_line":"            self.assertEqual(int(flavor[\u0027OS-FLV-EXT-DATA:ephemeral\u0027]), 0)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            if self._interface \u003d\u003d \"xml\":"},{"line_number":168,"context_line":"                XMLNS_OS_FLV_ACCESS \u003d \"http://docs.openstack.org/compute/ext/\"\\"},{"line_number":169,"context_line":"                    \"flavor_access/api/v2\""},{"line_number":170,"context_line":"                key \u003d \"{\" + XMLNS_OS_FLV_ACCESS + \"}is_public\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F7uY%3D","line":167,"updated":"2013-10-25 00:47:23.000000000","message":"Shouldn\u0027t this transformation be done in the xml client? Then we wouldn\u0027t need to have separate a json/xml path here","commit_id":"43ea730f58bf553a71099132c688138372424553"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"35e2b3e84a9e10746357bb26f17e57205bc1f3f4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            self.assertEqual(int(flavor[\u0027rxtx_factor\u0027]), 1)"},{"line_number":165,"context_line":"            self.assertEqual(int(flavor[\u0027OS-FLV-EXT-DATA:ephemeral\u0027]), 0)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            if self._interface \u003d\u003d \"xml\":"},{"line_number":168,"context_line":"                XMLNS_OS_FLV_ACCESS \u003d \"http://docs.openstack.org/compute/ext/\"\\"},{"line_number":169,"context_line":"                    \"flavor_access/api/v2\""},{"line_number":170,"context_line":"                key \u003d \"{\" + XMLNS_OS_FLV_ACCESS + \"}is_public\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F7aI%3D","line":167,"in_reply_to":"AAAATn%2F%2F7uY%3D","updated":"2013-10-25 03:38:41.000000000","message":"just copy it. will fix it","commit_id":"43ea730f58bf553a71099132c688138372424553"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a4835fc0c221e12c89432ce5629cb6a653184e51","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        verify_flavor_response_extension(flavor)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Verify flavor is retrieved"},{"line_number":179,"context_line":"        resp, flavor \u003d self.user_client.get_flavor_details(new_flavor_id)"},{"line_number":180,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":181,"context_line":"        self.assertEqual(flavor[\u0027name\u0027], flavor_name)"},{"line_number":182,"context_line":"        verify_flavor_response_extension(flavor)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FseQ%3D","line":179,"updated":"2013-10-30 10:46:02.000000000","message":"Can you explain why the change was made from the admin client to non admin client here?","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3069f40c138e7af3b1cd06a08ec282d17aad714e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        verify_flavor_response_extension(flavor)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Verify flavor is retrieved"},{"line_number":179,"context_line":"        resp, flavor \u003d self.user_client.get_flavor_details(new_flavor_id)"},{"line_number":180,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":181,"context_line":"        self.assertEqual(flavor[\u0027name\u0027], flavor_name)"},{"line_number":182,"context_line":"        verify_flavor_response_extension(flavor)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Frrk%3D","line":179,"in_reply_to":"AAAATn%2F%2FseQ%3D","updated":"2013-10-30 13:51:01.000000000","message":"I thought this needn\u0027t require admin privilege. But I forgot this is in the admin directory:)","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"}],"tempest/api/compute/admin/test_flavors_extra_specs.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"72329ef14fdcf3121b7ef3354f569c0e09b56ed4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(get_resp.status, 200)"},{"line_number":102,"context_line":"        self.assertEqual(get_body, {\"key1\": \"value\", \"key2\": \"value2\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # UNSET extra specs that were set in this test"},{"line_number":105,"context_line":"        unset_resp, _ \u003d \\"},{"line_number":106,"context_line":"            self.client.unset_flavor_extra_spec(self.flavor[\u0027id\u0027], \"key1\")"},{"line_number":107,"context_line":"        self.assertEqual(unset_resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F7us%3D","line":104,"updated":"2013-10-25 00:47:23.000000000","message":"This comment seems to be wrong know. Should we also be unsetting key2?","commit_id":"43ea730f58bf553a71099132c688138372424553"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"35e2b3e84a9e10746357bb26f17e57205bc1f3f4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(get_resp.status, 200)"},{"line_number":102,"context_line":"        self.assertEqual(get_body, {\"key1\": \"value\", \"key2\": \"value2\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # UNSET extra specs that were set in this test"},{"line_number":105,"context_line":"        unset_resp, _ \u003d \\"},{"line_number":106,"context_line":"            self.client.unset_flavor_extra_spec(self.flavor[\u0027id\u0027], \"key1\")"},{"line_number":107,"context_line":"        self.assertEqual(unset_resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F7aQ%3D","line":104,"in_reply_to":"AAAATn%2F%2F7us%3D","updated":"2013-10-25 03:38:41.000000000","message":"done","commit_id":"43ea730f58bf553a71099132c688138372424553"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a4835fc0c221e12c89432ce5629cb6a653184e51","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(get_resp.status, 200)"},{"line_number":102,"context_line":"        self.assertEqual(get_body, {\"key1\": \"value\", \"key2\": \"value2\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # UNSET extra specs that were set in this test"},{"line_number":105,"context_line":"        unset_resp, _ \u003d \\"},{"line_number":106,"context_line":"            self.client.unset_flavor_extra_spec(self.flavor[\u0027id\u0027], \"key1\")"},{"line_number":107,"context_line":"        self.assertEqual(unset_resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FsdU%3D","line":104,"updated":"2013-10-30 10:46:02.000000000","message":"Sorry probably should have mentioned this last time, but if this is cleanup then it should be added in an addCleanup just after setting it...","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3069f40c138e7af3b1cd06a08ec282d17aad714e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertEqual(get_resp.status, 200)"},{"line_number":102,"context_line":"        self.assertEqual(get_body, {\"key1\": \"value\", \"key2\": \"value2\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # UNSET extra specs that were set in this test"},{"line_number":105,"context_line":"        unset_resp, _ \u003d \\"},{"line_number":106,"context_line":"            self.client.unset_flavor_extra_spec(self.flavor[\u0027id\u0027], \"key1\")"},{"line_number":107,"context_line":"        self.assertEqual(unset_resp.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FrsI%3D","line":104,"in_reply_to":"AAAATn%2F%2FsdU%3D","updated":"2013-10-30 13:51:01.000000000","message":"but we want to check the unset in this test as the test name. So I think it\u0027s ok","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a4835fc0c221e12c89432ce5629cb6a653184e51","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.assertEqual(\"value1\", get_body)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for key in specs:"},{"line_number":129,"context_line":"            self.assertEqual(body[key], specs[key])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class FlavorsExtraSpecsTestXML(FlavorsExtraSpecsTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fsb8%3D","line":129,"updated":"2013-10-30 10:46:02.000000000","message":"Perhaps should leave this chunk of code next to the request its testing?","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3069f40c138e7af3b1cd06a08ec282d17aad714e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.assertEqual(\"value1\", get_body)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for key in specs:"},{"line_number":129,"context_line":"            self.assertEqual(body[key], specs[key])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class FlavorsExtraSpecsTestXML(FlavorsExtraSpecsTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Frq4%3D","line":129,"in_reply_to":"AAAATn%2F%2Fsb8%3D","updated":"2013-10-30 13:51:01.000000000","message":"sorry, mistake","commit_id":"8631aeb223b09a5d5ce733d5ffeca827cdaf809c"}]}
