)]}'
{"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fd7ae1a25aff63fdcbbf50213a36580ede35941","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class VolumesListTestJSON(base.BaseVolumeTest):"},{"line_number":29,"context_line":"    # NOTE: This test creates a number of 1G volumes. To run successfully,"},{"line_number":30,"context_line":"    # ensure that the backing file for the volume group that Nova uses"},{"line_number":31,"context_line":"    # has space for at least 3 1G volumes!"},{"line_number":32,"context_line":"    # If you are running a Devstack environment, ensure that the"},{"line_number":33,"context_line":"    # VOLUME_BACKING_FILE_SIZE is at least 4G in your localrc"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_3c320af3","line":30,"range":{"start_line":30,"start_character":61,"end_line":30,"end_character":65},"updated":"2017-12-21 23:55:10.000000000","message":"heh, is this test that old that it means nova-volume?","commit_id":"8daf6ca22503b5d0d0d9d9683cb8055390d41429"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"9257361e9fd3f8a5b10d72f062e306bd4123ead8","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class VolumesListTestJSON(base.BaseVolumeTest):"},{"line_number":29,"context_line":"    # NOTE: This test creates a number of 1G volumes. To run successfully,"},{"line_number":30,"context_line":"    # ensure that the backing file for the volume group that Nova uses"},{"line_number":31,"context_line":"    # has space for at least 3 1G volumes!"},{"line_number":32,"context_line":"    # If you are running a Devstack environment, ensure that the"},{"line_number":33,"context_line":"    # VOLUME_BACKING_FILE_SIZE is at least 4G in your localrc"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_dc619e3b","line":30,"range":{"start_line":30,"start_character":61,"end_line":30,"end_character":65},"in_reply_to":"bf8cb3f7_3c320af3","updated":"2017-12-22 00:43:02.000000000","message":"Looks like it...  Fix proposed as a separate commit.","commit_id":"8daf6ca22503b5d0d0d9d9683cb8055390d41429"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fd7ae1a25aff63fdcbbf50213a36580ede35941","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def removeVolatileFields(cls, fetched_list, fields\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Remove fields that should not be compared."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        This method makes sure that Tempest does not compare e.g."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_fc510210","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":28},"updated":"2017-12-21 23:55:10.000000000","message":"no camel-case\n\nremove_volatile_fields","commit_id":"8daf6ca22503b5d0d0d9d9683cb8055390d41429"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"9257361e9fd3f8a5b10d72f062e306bd4123ead8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def removeVolatileFields(cls, fetched_list, fields\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Remove fields that should not be compared."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        This method makes sure that Tempest does not compare e.g."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_7c697223","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":28},"in_reply_to":"bf8cb3f7_fc510210","updated":"2017-12-22 00:43:02.000000000","message":"Done","commit_id":"8daf6ca22503b5d0d0d9d9683cb8055390d41429"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2cc1540ec6d4278a0149189a0e76fad5dd6729a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def remove_volatile_fields(cls, fetched_list, fields\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Remove fields that should not be compared."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        This method makes sure that Tempest does not compare e.g."}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_48e1489a","line":39,"range":{"start_line":39,"start_character":50,"end_line":39,"end_character":61},"updated":"2017-12-22 07:39:54.000000000","message":"fields is not used anywhere, so maybe we can add it when needed for simplification","commit_id":"7fe1fdf22b0df18e961b8701d1f352c2ae749ca1"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"99c44f0abf5efd4cb0bd797dbb19b40d3b61783d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def remove_volatile_fields(cls, fetched_list, fields\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"Remove fields that should not be compared."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        This method makes sure that Tempest does not compare e.g."}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_0270f8a4","line":39,"range":{"start_line":39,"start_character":50,"end_line":39,"end_character":61},"in_reply_to":"bf8cb3f7_48e1489a","updated":"2017-12-22 13:54:52.000000000","message":"Done","commit_id":"7fe1fdf22b0df18e961b8701d1f352c2ae749ca1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2cc1540ec6d4278a0149189a0e76fad5dd6729a3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if fields is None:"},{"line_number":47,"context_line":"            fields \u003d cls.VOLATILE_FIELDS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for item in fetched_list:"},{"line_number":50,"context_line":"            for field in fields:"},{"line_number":51,"context_line":"                if field in item:"},{"line_number":52,"context_line":"                    del item[field]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_48a8681e","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":16},"updated":"2017-12-22 07:39:54.000000000","message":"will the name volume or volume_info be more specific?","commit_id":"7fe1fdf22b0df18e961b8701d1f352c2ae749ca1"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"99c44f0abf5efd4cb0bd797dbb19b40d3b61783d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if fields is None:"},{"line_number":47,"context_line":"            fields \u003d cls.VOLATILE_FIELDS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for item in fetched_list:"},{"line_number":50,"context_line":"            for field in fields:"},{"line_number":51,"context_line":"                if field in item:"},{"line_number":52,"context_line":"                    del item[field]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_2275fc95","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":16},"in_reply_to":"bf8cb3f7_48a8681e","updated":"2017-12-22 13:54:52.000000000","message":"Done","commit_id":"7fe1fdf22b0df18e961b8701d1f352c2ae749ca1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"cfbc5fd3af428f2b72962d3ee94a22a0893c6161","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # VOLUME_BACKING_FILE_SIZE is at least 4G in your localrc"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    VOLUME_FIELDS \u003d (\u0027id\u0027, \u0027name\u0027)"},{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def _remove_volatile_fields(cls, fetched_list):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_12214d4e","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":36},"updated":"2017-12-29 01:54:58.000000000","message":"this can be removed?","commit_id":"b26e2413c66538024a322548937ed6e60397dd52"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ad38759cdb37cfe93fecba9a75e821a9de93e443","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # VOLUME_BACKING_FILE_SIZE is at least 4G in your localrc"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    VOLUME_FIELDS \u003d (\u0027id\u0027, \u0027name\u0027)"},{"line_number":36,"context_line":"    VOLATILE_FIELDS \u003d (\u0027updated_at\u0027,)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"},{"line_number":39,"context_line":"    def _remove_volatile_fields(cls, fetched_list):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_f447f4bb","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":36},"in_reply_to":"9f91af0f_12214d4e","updated":"2017-12-29 09:15:35.000000000","message":"Done","commit_id":"b26e2413c66538024a322548937ed6e60397dd52"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"cfbc5fd3af428f2b72962d3ee94a22a0893c6161","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        fields \u003d cls.VOLATILE_FIELDS"},{"line_number":47,"context_line":"        for volume in fetched_list:"},{"line_number":48,"context_line":"            for field in fields:"},{"line_number":49,"context_line":"                if field in volume:"},{"line_number":50,"context_line":"                    del volume[field]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_b232e1a6","line":48,"range":{"start_line":48,"start_character":25,"end_line":48,"end_character":31},"updated":"2017-12-29 01:54:58.000000000","message":"here can put cls.VOLATILE_FIELDS directly?","commit_id":"b26e2413c66538024a322548937ed6e60397dd52"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ad38759cdb37cfe93fecba9a75e821a9de93e443","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        fields \u003d cls.VOLATILE_FIELDS"},{"line_number":47,"context_line":"        for volume in fetched_list:"},{"line_number":48,"context_line":"            for field in fields:"},{"line_number":49,"context_line":"                if field in volume:"},{"line_number":50,"context_line":"                    del volume[field]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_1445b8b3","line":48,"range":{"start_line":48,"start_character":25,"end_line":48,"end_character":31},"in_reply_to":"9f91af0f_b232e1a6","updated":"2017-12-29 09:15:35.000000000","message":"Done","commit_id":"b26e2413c66538024a322548937ed6e60397dd52"}]}