)]}'
{"tempest/api/volume/test_volumes_negative.py":[{"author":{"_account_id":8286,"name":"zhangyanzi","email":"yanzi.zhang@samsung.com","username":"zhangyanzi"},"change_message_id":"1bab1cd47d3e6c9a933bc6110c21505b883d7171","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FKNU%3D","line":156,"updated":"2013-10-22 09:48:55.000000000","message":"You want to test \"Extend volume with smaller size than original size\"\nBut ,the param \"extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5\" is not \ninteger\nThis will get the reponse info : \"New volume size must be specified as an integer.\"","commit_id":"cb9711c797a5639a6e2303fb3b3f0c513f0b7de7"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"707fdefcbfc21e18ec3d09edeab910335f6f2026","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FHTc%3D","line":156,"in_reply_to":"AAAATH%2F%2FKNU%3D","updated":"2013-10-23 00:26:25.000000000","message":"hi~. I have tested this case using rest api, then the response is \"Invalid input received: New size for extend must be greater than current size. (current: 1, extended: 0.5)\"","commit_id":"cb9711c797a5639a6e2303fb3b3f0c513f0b7de7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3f891f5fa4f6f851581f9d0576f70630351e5294","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2F9A%3D","line":156,"updated":"2013-10-23 04:01:34.000000000","message":"I think here should be \"int(self.volume[\u0027size\u0027]) - 1\", because new_size of extend api should be integer as zhangyanzi said in previous review.","commit_id":"a715422e617dc522dec6f3b39eb688c3a7a21aae"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"a382800f25ab91cd74fcf5b7c657e52c108a5da2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2Fbo%3D","line":156,"in_reply_to":"AAAATX%2F%2F%2F9A%3D","updated":"2013-10-23 07:40:23.000000000","message":"Thanks, I checked this situation in my openstack, the python function \u0027int()\u0027 will change 0.5 to 0, so it do not throw exception as  zhangyanzi said. But if the extend_size is like \u0027abc\u0027 , this exception will be throwed.","commit_id":"a715422e617dc522dec6f3b39eb688c3a7a21aae"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3956978d03862d75d36c73ca5eab42de284225c6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2FJ0%3D","line":156,"in_reply_to":"AAAATX%2F%2F%2FLc%3D","updated":"2013-10-23 08:58:12.000000000","message":"You are right.\n\nit should be \"int(str(body[\u0027os-extend\u0027][\u0027new_size\u0027]))\"( adding str()). then we can validate it as integer.","commit_id":"a715422e617dc522dec6f3b39eb688c3a7a21aae"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d81730c2fe671990c0dc9f333c91b760c3982fc2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2FLc%3D","line":156,"in_reply_to":"AAAATX%2F%2F%2FYM%3D","updated":"2013-10-23 08:52:16.000000000","message":"It is reasonable. I will fix it. By the way, the cinder has validation date type by \u0027_val \u003d int(body[\u0027os-extend\u0027][\u0027new_size\u0027])\u0027, but it will change 0.5 to integer 0 (it will do not throw BadRequest). So maybe it need more validation to judge floating number.","commit_id":"a715422e617dc522dec6f3b39eb688c3a7a21aae"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b34640259963ac964e8d66c03e072903431b3759","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d int(self.volume[\u0027size\u0027]) - 0.5"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2FYM%3D","line":156,"in_reply_to":"AAAATX%2F%2F%2Fbo%3D","updated":"2013-10-23 07:54:30.000000000","message":"I think that cinder should validate the passed \"new_size\" is a integer. If \"new_size\" is 1.5 etc, cinder should return BadRequest response due to invalid data type(not integer).\n\n(I will try to add the validation to cinder.)\n\nOn the other hand, the purpose of this test checks that cinder returns a BadRequest response due to the smaller size. (not invalid data type).\nCurrent test is the combination of the smaller size and invalid data type. I feel it is better to separate them and this test checks the smaller size only.","commit_id":"a715422e617dc522dec6f3b39eb688c3a7a21aae"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9787acc7148b1dc9730832051f82706ef256032c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d 0"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2FDQ%3D","line":156,"updated":"2013-10-23 09:26:36.000000000","message":"Actually 0 looks ambiguous to me but the volume in setUp is just 1G so size - 1 wouldn\u0027t work here. Please, if someone asks for further changes, add a comment  about it in the test case.","commit_id":"5b98175e45c429f0eed4c557849cd74e67c47c17"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00a70af630de8bfe51f062aa1c1ed040e0f7ed3b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d 0"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F8GY%3D","line":156,"in_reply_to":"AAAATX%2F%2F%2FDQ%3D","updated":"2013-10-23 23:00:28.000000000","message":"good point. I also get the same feeling.\n\nIf the test name would be current one, I prefer \"extend_size \u003d int(self.volume[\u0027size\u0027]) - 1\" for showing the test behavior clearly.\n\nOf the test name would be changed to test_volume_extend_with_size_zero or something, this implementation is reasonable.","commit_id":"5b98175e45c429f0eed4c557849cd74e67c47c17"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8f78ea687ef4e0c2209903b0f9d730f88aaad8c4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":154,"context_line":"    def test_volume_extend_with_size_smaller_than_original_size(self):"},{"line_number":155,"context_line":"        # Extend volume with smaller size than original size."},{"line_number":156,"context_line":"        extend_size \u003d 0"},{"line_number":157,"context_line":"        self.assertRaises(exceptions.BadRequest, self.client.extend_volume,"},{"line_number":158,"context_line":"                          self.volume[\u0027id\u0027], extend_size)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F%2FVI%3D","line":156,"in_reply_to":"AAAATX%2F%2F8GY%3D","updated":"2013-10-24 06:49:13.000000000","message":"Thanks Giulio Fidente and \tKen\u0027ichi Ohmichi. I will improve it by adding some comment after merge it.","commit_id":"5b98175e45c429f0eed4c557849cd74e67c47c17"}],"tempest/services/volume/json/volumes_client.py":[{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"bc1183be295b02ac066c11cf84a0e5a0703eb2f8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return False"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def extend_volume(self, volume_id, extend_size):"},{"line_number":159,"context_line":"        \"\"\"Extend a volume.\"\"\""},{"line_number":160,"context_line":"        post_body \u003d {"},{"line_number":161,"context_line":"            \u0027new_size\u0027: extend_size"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F%2FLI%3D","line":159,"updated":"2013-10-24 08:04:13.000000000","message":"1. How about this docstring :\"Extend a volume with a new size\"\n2. \"new_size\" is better than \"extend_size\" as parameter.\nI do not know the exact meaning of \"extend_size\" (It is new size or delta), \nuntil i see \npost_body \u003d {\n   \u0027new_size\u0027: extend_size\n}\nWhat do you think about it?","commit_id":"5b98175e45c429f0eed4c557849cd74e67c47c17"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9bbcd9c85b7d7da30d65c9fd08c1b6b384e8acb9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return False"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def extend_volume(self, volume_id, extend_size):"},{"line_number":159,"context_line":"        \"\"\"Extend a volume.\"\"\""},{"line_number":160,"context_line":"        post_body \u003d {"},{"line_number":161,"context_line":"            \u0027new_size\u0027: extend_size"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F%2B0c%3D","line":159,"in_reply_to":"AAAATn%2F%2F%2FLI%3D","updated":"2013-10-24 09:50:40.000000000","message":"en,it is reasonable. I will change it in next patch.","commit_id":"5b98175e45c429f0eed4c557849cd74e67c47c17"}]}