)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"92a437cd244a0a41e10ef0ca3625400de48045c9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        v2_37_version \u003d api_version_request.APIVersionRequest(\u00272.37\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # NOTE(snikitin): since microversion v2.37 \u0027networks\u0027 field is required"},{"line_number":180,"context_line":"        if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs:"},{"line_number":181,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        tenant_network \u003d cls.get_tenant_network()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_337c25b4","line":180,"range":{"start_line":180,"start_character":49,"end_line":180,"end_character":57},"updated":"2018-01-06 02:46:07.000000000","message":"Shouldn\u0027t this be \u0027force_networks\u0027?","commit_id":"4d0d38ea68b7d65803bccdb1be58c3978937d8d6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aa16f958688c71638d1c943e2e902f5211c5eba5","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        v2_37_version \u003d api_version_request.APIVersionRequest(\u00272.37\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # NOTE(snikitin): since microversion v2.37 \u0027networks\u0027 field is required"},{"line_number":180,"context_line":"        if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs:"},{"line_number":181,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        tenant_network \u003d cls.get_tenant_network()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_2c8b5a6e","line":180,"range":{"start_line":180,"start_character":49,"end_line":180,"end_character":57},"in_reply_to":"9f91af0f_337c25b4","updated":"2018-01-08 03:39:31.000000000","message":"Thanks Felipe, please see the comment I\u0027ve put in the new patch:)","commit_id":"4d0d38ea68b7d65803bccdb1be58c3978937d8d6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"92a437cd244a0a41e10ef0ca3625400de48045c9","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        # NOTE(snikitin): since microversion v2.37 \u0027networks\u0027 field is required"},{"line_number":180,"context_line":"        if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs:"},{"line_number":181,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        tenant_network \u003d cls.get_tenant_network()"},{"line_number":184,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":185,"context_line":"            cls.os_primary,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_135a414e","line":182,"updated":"2018-01-06 02:46:07.000000000","message":"nit: It\u0027s not clear what \u0027force_networks\u0027 is for because you have to look at it alongside common.compute module to make sense of it. And you can\u0027t look up documentation for it because it\u0027s only used internally here. Would be good to explain what it\u0027s for.","commit_id":"4d0d38ea68b7d65803bccdb1be58c3978937d8d6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aa16f958688c71638d1c943e2e902f5211c5eba5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        # NOTE(snikitin): since microversion v2.37 \u0027networks\u0027 field is required"},{"line_number":180,"context_line":"        if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs:"},{"line_number":181,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        tenant_network \u003d cls.get_tenant_network()"},{"line_number":184,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":185,"context_line":"            cls.os_primary,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_cc7bce78","line":182,"in_reply_to":"9f91af0f_135a414e","updated":"2018-01-08 03:39:31.000000000","message":"Yes I\u0027ve added comment for it","commit_id":"4d0d38ea68b7d65803bccdb1be58c3978937d8d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6c8c50d81342e3176410038bbaf5aaa0893f303","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        v2_37_version \u003d api_version_request.APIVersionRequest(\u00272.37\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # NOTE(snikitin): since microversion v2.37 \u0027networks\u0027 field is required"},{"line_number":180,"context_line":"        if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs:"},{"line_number":181,"context_line":"            # \u0027force_networks\u0027 is not a valid api interface field, it\u0027s just"},{"line_number":182,"context_line":"            # a flag that indicates \u0027networks\u0027 field should be present"},{"line_number":183,"context_line":"            # eventually. we will pop it from kwargs later in"},{"line_number":184,"context_line":"            # compute.create_test_server."},{"line_number":185,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        tenant_network \u003d cls.get_tenant_network()"},{"line_number":188,"context_line":"        body, servers \u003d compute.create_test_server("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_f6b3c6e7","line":185,"range":{"start_line":180,"start_character":0,"end_line":185,"end_character":43},"updated":"2018-01-09 23:52:00.000000000","message":"adding force_network is confusing here. it took time for me to understand the issue and purpose of force_network. how about setting network to None if no tenant_network. like below comment-","commit_id":"f08b4ec65e4dfe213d1130cba8b920996b04b17b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6c8c50d81342e3176410038bbaf5aaa0893f303","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            # compute.create_test_server."},{"line_number":185,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        tenant_network \u003d cls.get_tenant_network()"},{"line_number":188,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":189,"context_line":"            cls.os_primary,"},{"line_number":190,"context_line":"            validatable,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_36e36edb","line":187,"range":{"start_line":187,"start_character":47,"end_line":187,"end_character":49},"updated":"2018-01-09 23:52:00.000000000","message":"if request_version \u003e\u003d v2_37_version and \u0027networks\u0027 not in kwargs and tenant_network is None:\n            kwargs[\u0027networks\u0027] \u003d \u0027none\u0027","commit_id":"f08b4ec65e4dfe213d1130cba8b920996b04b17b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"264f1d77d9746c8759b48df36f516875bb1e612f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            # compute.create_test_server."},{"line_number":185,"context_line":"            kwargs[\u0027force_networks\u0027] \u003d True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        tenant_network \u003d cls.get_tenant_network()"},{"line_number":188,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":189,"context_line":"            cls.os_primary,"},{"line_number":190,"context_line":"            validatable,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_5cc89172","line":187,"range":{"start_line":187,"start_character":47,"end_line":187,"end_character":49},"in_reply_to":"9f91af0f_36e36edb","updated":"2018-01-10 02:30:54.000000000","message":"Thanks, good suggestion!","commit_id":"f08b4ec65e4dfe213d1130cba8b920996b04b17b"}]}