)]}'
{"tools/verify_tempest_config.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c2b2422a3fbacb94e8935090611791abb525d327","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.glance_feature_group.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FHXA%3D","line":34,"updated":"2013-10-22 23:47:35.000000000","message":"This method looks like only for glance api.\nSo how about verify_glance_api_versions or verify_image_api_versions?","commit_id":"ba21e35620f49cc19a3dece698109af7b5da140d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7ed443ecccdfca46ebca028b052a7e76bf7a226b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.glance_feature_group.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F87o%3D","line":34,"in_reply_to":"AAAATH%2F%2FHHQ%3D","updated":"2013-10-23 18:51:38.000000000","message":"That was my plan, but I guess that I can make this a glance specific function for now and when we add other api version checks we can add a separate method to do that.","commit_id":"ba21e35620f49cc19a3dece698109af7b5da140d"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"7cd13a360a9ae6f2f3a748142d2353a1f1c79eba","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.glance_feature_group.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FHHQ%3D","line":34,"in_reply_to":"AAAATH%2F%2FHXA%3D","updated":"2013-10-23 02:46:03.000000000","message":"Just my 2c - If the intent is to add non glance api checks in the future I\u0027d be happy with the current naming.","commit_id":"ba21e35620f49cc19a3dece698109af7b5da140d"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"89894c96f29f4bfc6cc79619a2d1b9660b57290a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_group.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"},{"line_number":38,"context_line":"                                           versions):"},{"line_number":39,"context_line":"        print \u0027Config option image api_v1 should be change to: %s\u0027 % ("},{"line_number":40,"context_line":"            not CONF.image_feature_group.api_v1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fx34%3D","line":37,"updated":"2013-10-29 07:18:44.000000000","message":"s/image_feature_group/image_feature_enabled","commit_id":"17c05d2f11db5c2c814961ecc4da5b701c3ca7b0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c8f3230420df67bad0fee4b732fa8fd033f0871f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_group.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"},{"line_number":38,"context_line":"                                           versions):"},{"line_number":39,"context_line":"        print \u0027Config option image api_v1 should be change to: %s\u0027 % ("},{"line_number":40,"context_line":"            not CONF.image_feature_group.api_v1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FwD0%3D","line":37,"in_reply_to":"AAAATn%2F%2Fx34%3D","updated":"2013-10-29 15:14:17.000000000","message":"Done","commit_id":"17c05d2f11db5c2c814961ecc4da5b701c3ca7b0"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"47a75e0195138562d878a519e98b88adb99928f5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_enabled.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FpZE%3D","line":34,"updated":"2013-10-30 22:50:39.000000000","message":"maybe we shouldn\u0027t enforce people to enable the config parameter if available but just make sure it is disabled if *not* available","commit_id":"99afd075241f344d33697ceef176b35e44fd1340"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f524978af30291d931b2dabd6333b768567b5970","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_enabled.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FoDM%3D","line":34,"in_reply_to":"AAAATn%2F%2FpUs%3D","updated":"2013-10-31 08:43:03.000000000","message":"Thanks I see your point now. I agree we could just update the printed message a bit. Maybe prepend it with something suggesting clearly it is the autodiscovery suggesting the change: \"AUTODISCOVERY: config option should be changed to ...\"","commit_id":"99afd075241f344d33697ceef176b35e44fd1340"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"383c33adf26e2fb292c7ec557eb7d2f9eee7447a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_enabled.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FpUs%3D","line":34,"in_reply_to":"AAAATn%2F%2FpVw%3D","updated":"2013-10-30 23:15:11.000000000","message":"Sorry I misread/misinterpreted your original comment, I think there is value in showing things both ways. This script is just a way of showing where your tempest config file differs from how the openstack services are configured. It intentionally isn\u0027t making changes to the config file for the case where things are explicitly disabled. This is just a tool for informing the user where their config file differs.\n\nMaybe I should change the output from \u0027should be change to\u0027 to something different?","commit_id":"99afd075241f344d33697ceef176b35e44fd1340"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c933b9aefd8abf0f0001f65ed817cb24f52fca11","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def verify_glance_api_versions(os):"},{"line_number":35,"context_line":"    # Check glance api versions"},{"line_number":36,"context_line":"    __, versions \u003d os.image_client.get_versions()"},{"line_number":37,"context_line":"    if CONF.image_feature_enabled.api_v1 !\u003d (\u0027v1.1\u0027 in versions or \u0027v1.0\u0027 in"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FpVw%3D","line":34,"in_reply_to":"AAAATn%2F%2FpZE%3D","updated":"2013-10-30 23:08:34.000000000","message":"So these options default true, if you look at: https://review.openstack.org/#/c/53181/ where I add them, they\u0027re on by default. In that patch it also changes things from auto-detection to be explicitly set with a config. If you look at this mailing list post I explained the reasoning why we\u0027re moving away from auto-detection of these things: http://lists.openstack.org/pipermail/openstack-dev/2013-October/016859.html\n\nThis script is meant as a replacement for auto-configuration like we used to. In places were things that can be auto-detected this script checks the service against the config. But, we still want to be explicit up front about what features are expected to be running so a misconfiguration or bugs don\u0027t mask the issues because we auto-detected differently then what is expected.","commit_id":"99afd075241f344d33697ceef176b35e44fd1340"}]}