)]}'
{"tempest/api/compute/servers/test_disk_config.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"ccd7a05847b558f5c998f540e1c176432fa49300","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # A server should be rebuilt using the manual disk config option"},{"line_number":39,"context_line":"        resp, server \u003d self.create_server(disk_config\u003d\u0027AUTO\u0027,"},{"line_number":40,"context_line":"                                          wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        self.addCleanup(self.client.delete_server, server[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Verify the specified attributes are set correctly"},{"line_number":44,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F0t0%3D","side":"PARENT","line":41,"updated":"2013-10-28 13:05:52.000000000","message":"Although the cleanup is not required, the cleanup of the server will not occur until tearDownClass rather than tearDown meaning there will be more servers running in parallel at the same time. I\u0027m not sure how big an issue this is, but perhaps there could be some sharing of servers across these tests?","commit_id":"771b9506c3de0f99551c136a3691d7c96fa32360"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"d42347a18727d3804efaa9f2dee05d7ce5530f12","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # A server should be rebuilt using the manual disk config option"},{"line_number":39,"context_line":"        resp, server \u003d self.create_server(disk_config\u003d\u0027AUTO\u0027,"},{"line_number":40,"context_line":"                                          wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        self.addCleanup(self.client.delete_server, server[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Verify the specified attributes are set correctly"},{"line_number":44,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FyeA%3D","side":"PARENT","line":41,"in_reply_to":"AAAATn%2F%2F0t0%3D","updated":"2013-10-29 02:13:33.000000000","message":"I don\u0027t see how these servers can be shared when run in parallel given these kinds of actions. But you are right that this changes the behavior.  One idea would be to give create_test_server an argument that could say if the server should be delete in tearDown instead of tearDownClass. But perhaps it would be easier to just leave the addCleanups.","commit_id":"771b9506c3de0f99551c136a3691d7c96fa32360"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"452040e695eb55a0b13f3a97cc395a573f5c787c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # A server should be rebuilt using the manual disk config option"},{"line_number":39,"context_line":"        resp, server \u003d self.create_server(disk_config\u003d\u0027AUTO\u0027,"},{"line_number":40,"context_line":"                                          wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        self.addCleanup(self.client.delete_server, server[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Verify the specified attributes are set correctly"},{"line_number":44,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fx7M%3D","side":"PARENT","line":41,"in_reply_to":"AAAATn%2F%2Fyaw%3D","updated":"2013-10-29 07:07:58.000000000","message":"I have posted a new patch I1e1f03df3b0d7840b6af666dbb412a7fea2ccbba for reusing a server instance in this test class.\n\nI\u0027m glad if you reviewing it also.","commit_id":"771b9506c3de0f99551c136a3691d7c96fa32360"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9bdda1a4698e3ba1e65e3e08650d664054dc47f1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # A server should be rebuilt using the manual disk config option"},{"line_number":39,"context_line":"        resp, server \u003d self.create_server(disk_config\u003d\u0027AUTO\u0027,"},{"line_number":40,"context_line":"                                          wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        self.addCleanup(self.client.delete_server, server[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Verify the specified attributes are set correctly"},{"line_number":44,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fyaw%3D","side":"PARENT","line":41,"in_reply_to":"AAAATn%2F%2FyeA%3D","updated":"2013-10-29 02:51:56.000000000","message":"Hi Christopher, David,\n\nThat is a nice catch, here and the following should be reverted in this patch. I will do it.\n\nAlso \"there could be some sharing of servers across these tests\" is a good idea.\nI will try it with another patch.\n\nThank you so much for your good reviews!","commit_id":"771b9506c3de0f99551c136a3691d7c96fa32360"}],"tempest/api/compute/servers/test_list_server_filters.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a237aed9cd330a965202015947e739f67f8c7f99","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cls.s1_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"},{"line_number":61,"context_line":"        resp, cls.s1 \u003d cls.create_test_server(name\u003dcls.s1_name,"},{"line_number":62,"context_line":"                                              image_id\u003dcls.image_ref,"},{"line_number":63,"context_line":"                                              flavor\u003dcls.flavor_ref,"},{"line_number":64,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        cls.s2_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2Fek%3D","line":63,"updated":"2013-10-23 07:24:50.000000000","message":"The flavor and image_id a default value. we can remove them.","commit_id":"9f22724cb2dee6483dafa0f745adabd0594d1e65"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a237aed9cd330a965202015947e739f67f8c7f99","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        cls.s2_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"},{"line_number":67,"context_line":"        resp, cls.s2 \u003d cls.create_test_server(name\u003dcls.s2_name,"},{"line_number":68,"context_line":"                                              image_id\u003dcls.image_ref_alt,"},{"line_number":69,"context_line":"                                              flavor\u003dcls.flavor_ref,"},{"line_number":70,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        cls.s3_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2Feg%3D","line":69,"updated":"2013-10-23 07:24:50.000000000","message":"This flavor is a default value. we can remove this.","commit_id":"9f22724cb2dee6483dafa0f745adabd0594d1e65"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a237aed9cd330a965202015947e739f67f8c7f99","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        cls.s3_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"},{"line_number":73,"context_line":"        resp, cls.s3 \u003d cls.create_test_server(name\u003dcls.s3_name,"},{"line_number":74,"context_line":"                                              image_id\u003dcls.image_ref,"},{"line_number":75,"context_line":"                                              flavor\u003dcls.flavor_ref_alt,"},{"line_number":76,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2Fec%3D","line":74,"updated":"2013-10-23 07:24:50.000000000","message":"This image_id is a default value. we can remove this.","commit_id":"9f22724cb2dee6483dafa0f745adabd0594d1e65"}],"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a237aed9cd330a965202015947e739f67f8c7f99","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Server for positive tests"},{"line_number":65,"context_line":"        resp, server \u003d cls.create_test_server(image_id\u003dcls.image_ref,"},{"line_number":66,"context_line":"                                              flavor\u003dcls.flavor_ref,"},{"line_number":67,"context_line":"                                              wait_until\u003d\u0027BUILD\u0027)"},{"line_number":68,"context_line":"        resp, resc_server \u003d cls.create_test_server(image_id\u003dcls.image_ref,"},{"line_number":69,"context_line":"                                                   flavor\u003dcls.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2FfM%3D","line":66,"updated":"2013-10-23 07:24:50.000000000","message":"The image_id and flavor are default values at base.py.\nso we can remove these arguments for more clean-up.","commit_id":"9f22724cb2dee6483dafa0f745adabd0594d1e65"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a237aed9cd330a965202015947e739f67f8c7f99","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                              flavor\u003dcls.flavor_ref,"},{"line_number":67,"context_line":"                                              wait_until\u003d\u0027BUILD\u0027)"},{"line_number":68,"context_line":"        resp, resc_server \u003d cls.create_test_server(image_id\u003dcls.image_ref,"},{"line_number":69,"context_line":"                                                   flavor\u003dcls.flavor_ref,"},{"line_number":70,"context_line":"                                                   wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":71,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":72,"context_line":"        cls.password \u003d server[\u0027adminPass\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATX%2F%2F%2FfE%3D","line":69,"updated":"2013-10-23 07:24:50.000000000","message":"ditto","commit_id":"9f22724cb2dee6483dafa0f745adabd0594d1e65"}]}