)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"c4ca5926625f26fb5cc9ba571c1dcc1c7a51e2f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Noam Angel \u003cnoama@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-16 07:06:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create port with port_vnic_type and port_profile from config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id7e4e3c7543498c84d815dccf16dc168d45b6a62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_5483e155","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"updated":"2018-07-16 10:47:39.000000000","message":"It\u0027s better to add description for the patch too.","commit_id":"c25684e4f46230866e9b957dca5a759723b7427d"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d403c0972a8c50aa7522a920de8054e879ef8457","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":96,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":97,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":98,"context_line":"        result \u003d client.create_port("},{"line_number":99,"context_line":"            name\u003dname,"},{"line_number":100,"context_line":"            network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4108cfd7","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":69},"updated":"2018-07-05 08:31:22.000000000","message":"It can be explicitly pass by tests using this method with valid value checks like [1]. Defaulting it to configured value can create issue and hard to debug. \n\nor this attribute is default for port? please give more information about why this needs to be present by default with configured value.  config option \u0027port_vnic_type\u0027 is for booting the instances with precreated port and this method can be used for other case also. \n\n[1] https://github.com/openstack/tempest/blob/c961a656ccdc0f1242b4ff3237a16d4a7cdf4e07/tempest/scenario/test_security_groups_basic_ops.py#L136","commit_id":"42d2831f66608cbfd14154604c18b5d3e90055ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"99fe669f0a33208392ac703f3f928337583af1b3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":96,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":97,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":98,"context_line":"        result \u003d client.create_port("},{"line_number":99,"context_line":"            name\u003dname,"},{"line_number":100,"context_line":"            network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4815cbe5","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":69},"in_reply_to":"5f7c97a3_3a433413","updated":"2018-07-24 02:43:14.000000000","message":"Thanks. We do not have default for port_vnic_type so we are good in term of existing behaviour. \n\nlgtm.","commit_id":"42d2831f66608cbfd14154604c18b5d3e90055ca"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e55a3c7210028a95f525e22c44bb0de75a16d29b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":96,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":97,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":98,"context_line":"        result \u003d client.create_port("},{"line_number":99,"context_line":"            name\u003dname,"},{"line_number":100,"context_line":"            network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5ecabb4e","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":69},"in_reply_to":"5f7c97a3_4108cfd7","updated":"2018-07-09 07:07:13.000000000","message":"we don\u0027t want to validate the port_vnic_type we want to allow to use different vnic_type in the same tests.","commit_id":"42d2831f66608cbfd14154604c18b5d3e90055ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"050230233137bec5c2a7dabb54642b3980077aef","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":96,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":97,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":98,"context_line":"        result \u003d client.create_port("},{"line_number":99,"context_line":"            name\u003dname,"},{"line_number":100,"context_line":"            network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9110385a","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":69},"in_reply_to":"5f7c97a3_5ecabb4e","updated":"2018-07-20 02:32:01.000000000","message":"that you can do by passing conf value explicitly in tests. \n\nMy question is that is there any side effect of passing \u0027binding:vnic_type\u0027 to port POST request all the time ? and is it default param in port POST request ?","commit_id":"42d2831f66608cbfd14154604c18b5d3e90055ca"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"90e66e277eae2b9d09cc4913c9eef1441466d069","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":96,"context_line":"        if CONF.network.port_vnic_type and \u0027binding:vnic_type\u0027 not in kwargs:"},{"line_number":97,"context_line":"            kwargs[\u0027binding:vnic_type\u0027] \u003d CONF.network.port_vnic_type"},{"line_number":98,"context_line":"        result \u003d client.create_port("},{"line_number":99,"context_line":"            name\u003dname,"},{"line_number":100,"context_line":"            network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3a433413","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":69},"in_reply_to":"5f7c97a3_9110385a","updated":"2018-07-20 09:48:08.000000000","message":"There should be no problem with passing it always as long as it has one of acceptable values which are \"normal\", \"macvtap\", \"direct\", \"baremetal\", \"direct-physical\" and \"virtio-forwarder\" according to neutron API docs.\nDefault value is \"normal\" in neutron so if You not pass it in POST request \"normal\" will be chosen always.","commit_id":"42d2831f66608cbfd14154604c18b5d3e90055ca"}]}