)]}'
{"tempest/api/compute/servers/test_create_server_multi_nic.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a9ad1e4b63f6b859718af59809e06e9bce08ded6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        default_cidr \u003d CONF.compute.default_network_cidr"},{"line_number":62,"context_line":"        net1 \u003d self._create_net_subnet_ret_net_from_cidr(default_cidr)"},{"line_number":63,"context_line":"        net2 \u003d self._create_net_subnet_ret_net_from_cidr(default_cidr)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        networks \u003d [{\u0027uuid\u0027: net1[\u0027network\u0027][\u0027id\u0027]},"},{"line_number":66,"context_line":"                    {\u0027uuid\u0027: net2[\u0027network\u0027][\u0027id\u0027]}]"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_83a927de","line":64,"updated":"2018-01-24 05:35:46.000000000","message":"I feel it\u0027s good to add this as a comment on this code. This might be confusing.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4a171faa2dcf835a6ebd2eb6a4e2629cb560ff69","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        default_cidr \u003d CONF.compute.default_network_cidr"},{"line_number":62,"context_line":"        net1 \u003d self._create_net_subnet_ret_net_from_cidr(default_cidr)"},{"line_number":63,"context_line":"        net2 \u003d self._create_net_subnet_ret_net_from_cidr(default_cidr)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        networks \u003d [{\u0027uuid\u0027: net1[\u0027network\u0027][\u0027id\u0027]},"},{"line_number":66,"context_line":"                    {\u0027uuid\u0027: net2[\u0027network\u0027][\u0027id\u0027]}]"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_345d9a14","line":64,"updated":"2018-01-18 01:27:56.000000000","message":"No worry. This test just test the order list and the instance will own 2 vnics by repeat --nic option. And in neutron sight, the different networks are different l2 domain. So there is no issue for this test, even though the cidr is the same, that\u0027s all about the network plan by tenants.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4a171faa2dcf835a6ebd2eb6a4e2629cb560ff69","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     [\u0027addresses\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # Sometimes the assigned addresses are [\u002719.80.0.2\u0027, \u002719.86.0.2\u0027], at"},{"line_number":84,"context_line":"        # other times [\u002719.80.0.3\u0027, \u002719.86.0.3\u0027]. So we check if the first"},{"line_number":85,"context_line":"        # address is in first network, similarly second address is in second"},{"line_number":86,"context_line":"        # network."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_94a34e00","line":83,"range":{"start_line":83,"start_character":48,"end_line":83,"end_character":72},"updated":"2018-01-18 01:27:56.000000000","message":"o","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"91b597bc5a487762abf4edee3dc91729ef097236","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     [\u0027addresses\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # Sometimes the assigned addresses are [\u002719.80.0.2\u0027, \u002719.86.0.2\u0027], at"},{"line_number":84,"context_line":"        # other times [\u002719.80.0.3\u0027, \u002719.86.0.3\u0027]. So we check if the first"},{"line_number":85,"context_line":"        # address is in first network, similarly second address is in second"},{"line_number":86,"context_line":"        # network."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_3b0102b0","line":83,"range":{"start_line":83,"start_character":48,"end_line":83,"end_character":72},"in_reply_to":"7f96bb07_94a34e00","updated":"2018-01-18 06:47:51.000000000","message":"yep, needs update.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4a171faa2dcf835a6ebd2eb6a4e2629cb560ff69","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # Sometimes the assigned addresses are [\u002719.80.0.2\u0027, \u002719.86.0.2\u0027], at"},{"line_number":84,"context_line":"        # other times [\u002719.80.0.3\u0027, \u002719.86.0.3\u0027]. So we check if the first"},{"line_number":85,"context_line":"        # address is in first network, similarly second address is in second"},{"line_number":86,"context_line":"        # network."},{"line_number":87,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d49d56bc","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":47},"updated":"2018-01-18 01:27:56.000000000","message":"o","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"91b597bc5a487762abf4edee3dc91729ef097236","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # Sometimes the assigned addresses are [\u002719.80.0.2\u0027, \u002719.86.0.2\u0027], at"},{"line_number":84,"context_line":"        # other times [\u002719.80.0.3\u0027, \u002719.86.0.3\u0027]. So we check if the first"},{"line_number":85,"context_line":"        # address is in first network, similarly second address is in second"},{"line_number":86,"context_line":"        # network."},{"line_number":87,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_5bfc0eb4","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":47},"in_reply_to":"7f96bb07_d49d56bc","updated":"2018-01-18 06:47:51.000000000","message":"ditto","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ec2070ae69bf73014ce2e9b8ced2fd1932480af3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":116,"context_line":"                addresses[net2[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":117,"context_line":"                addresses[net1[\u0027network\u0027][\u0027name\u0027]][1][\u0027addr\u0027]]"},{"line_number":118,"context_line":"        networks \u003d [netaddr.IPNetwork(default_cidr),"},{"line_number":119,"context_line":"                    netaddr.IPNetwork(default_cidr),"},{"line_number":120,"context_line":"                    netaddr.IPNetwork(default_cidr)]"},{"line_number":121,"context_line":"        for address, network in zip(addr, networks):"},{"line_number":122,"context_line":"            self.assertIn(address, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_294e9b37","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":52},"updated":"2018-01-18 06:01:38.000000000","message":"1. Does it really make no difference whether to use same cidr or not?\n2. If so, then why three networks are needed?","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"91b597bc5a487762abf4edee3dc91729ef097236","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":116,"context_line":"                addresses[net2[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":117,"context_line":"                addresses[net1[\u0027network\u0027][\u0027name\u0027]][1][\u0027addr\u0027]]"},{"line_number":118,"context_line":"        networks \u003d [netaddr.IPNetwork(default_cidr),"},{"line_number":119,"context_line":"                    netaddr.IPNetwork(default_cidr),"},{"line_number":120,"context_line":"                    netaddr.IPNetwork(default_cidr)]"},{"line_number":121,"context_line":"        for address, network in zip(addr, networks):"},{"line_number":122,"context_line":"            self.assertIn(address, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_3b6262d9","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":52},"in_reply_to":"7f96bb07_294e9b37","updated":"2018-01-18 06:47:51.000000000","message":"\u003e 1. Does it really make no difference whether to use same cidr or not?\n\u003e 2. If so, then why three networks are needed?\n\nAs @zhaobo said above, the different networks are different l2 domains in neutron view.\n\n`test_verify_multiple_nics_order` is the testcase have 2 different networks, and one nic per network.\n\n`test_verify_duplicate_network_nics` is the testcase have 2 different networks, and net1 have 2 nics, net2 have 1 nic.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dee9afa098c170714b64f909f8100e6b659ea85b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":116,"context_line":"                addresses[net2[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":117,"context_line":"                addresses[net1[\u0027network\u0027][\u0027name\u0027]][1][\u0027addr\u0027]]"},{"line_number":118,"context_line":"        networks \u003d [netaddr.IPNetwork(default_cidr),"},{"line_number":119,"context_line":"                    netaddr.IPNetwork(default_cidr),"},{"line_number":120,"context_line":"                    netaddr.IPNetwork(default_cidr)]"},{"line_number":121,"context_line":"        for address, network in zip(addr, networks):"},{"line_number":122,"context_line":"            self.assertIn(address, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_a2582ffa","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":52},"in_reply_to":"7f96bb07_3b6262d9","updated":"2018-01-22 03:58:31.000000000","message":"This conflicts with the previous testcase design, so I just want to see more evidence of this kined of change to make sure of it","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5668d7fbafa069327443c9cf9db18612defcdec","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        addresses \u003d (self.client.list_addresses(server_multi_nics[\u0027id\u0027])"},{"line_number":80,"context_line":"                     [\u0027addresses\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # So we check if the first address is in first network, similarly"},{"line_number":84,"context_line":"        # second address is in second network."},{"line_number":85,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":86,"context_line":"                addresses[net2[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027]]"},{"line_number":87,"context_line":"        networks \u003d [netaddr.IPNetwork(default_cidr),"},{"line_number":88,"context_line":"                    netaddr.IPNetwork(default_cidr)]"},{"line_number":89,"context_line":"        for address, network in zip(addr, networks):"},{"line_number":90,"context_line":"            self.assertIn(address, network)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_576d1630","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":52},"updated":"2018-01-24 10:28:31.000000000","message":"how we will make sure now? Now both network cidr are same and ip allocated from each network are in same range and L90 does not confirm the behavior whether server preserve the order of requested net.\n\nin nova it is always in requested order which this test was checking -\n-  https://github.com/openstack/nova/blob/a40c00957ef4552681c172913bae1135a1614bbc/nova/network/neutronv2/api.py#L951","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"f5b36cad737cce632ea5c840e327e375f1ab7ffd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        addresses \u003d (self.client.list_addresses(server_multi_nics[\u0027id\u0027])"},{"line_number":80,"context_line":"                     [\u0027addresses\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # We can\u0027t predict the ip addresses assigned to the server on networks."},{"line_number":83,"context_line":"        # So we check if the first address is in first network, similarly"},{"line_number":84,"context_line":"        # second address is in second network."},{"line_number":85,"context_line":"        addr \u003d [addresses[net1[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027],"},{"line_number":86,"context_line":"                addresses[net2[\u0027network\u0027][\u0027name\u0027]][0][\u0027addr\u0027]]"},{"line_number":87,"context_line":"        networks \u003d [netaddr.IPNetwork(default_cidr),"},{"line_number":88,"context_line":"                    netaddr.IPNetwork(default_cidr)]"},{"line_number":89,"context_line":"        for address, network in zip(addr, networks):"},{"line_number":90,"context_line":"            self.assertIn(address, network)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_d1e1a6d2","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":52},"in_reply_to":"7f96bb07_576d1630","updated":"2018-01-25 03:08:21.000000000","message":"hi, @gmann, thanks for comment. : )\n\nActually, I don\u0027t know the original case how to verify the networks order.\n\n1. first, we create network using [net1, net2]\n2. then we get the server address\n{\n  \"addresses\": {\n    \"net1\": [{\n      \"addr\": \"19.80.0.2\",\n      \"version\": 4\n    }],\n    \"net2\": [{\n      \"addr\": \"19.86.0.2\",\n      \"version\": 4\n    }]\n  }\n}\nthese addresses are gather by a dict, so, the order is random.\n3. we get the addr by net1/net2 name, and then assert the address in their own cidr, the only thing we can verify in here is net address in their own cidr, but unrelated to order, right?\n\nI find the original submit: https://review.openstack.org/#/c/122434/, and also I couldn\u0027t catch the main point of this case.","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b72cc11e7abbc25b204c9757a3d8752c3a306ae2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_032e77f9","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"updated":"2018-01-24 06:02:18.000000000","message":"With this patch test_verify_duplicate_network_nics will be of no difference with test_verify_multiple_nics_order,\nand \"# Verify that the networks order given at the server creation is preserved within the server\" can no longer be tested,\nso maybe we can delete test_verify_duplicate_network_nics, and rename test_verify_multiple_nics_order as test_verify_duplicate_network_nics.","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"71a5fcbe5fe4f287a09c503d6289b8f59c811704","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_14f30fa0","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"in_reply_to":"7f96bb07_032e77f9","updated":"2018-01-24 08:07:37.000000000","message":"Sorry, I don\u0027t think they are same..Please see L65 and L102.\nL65 means creating vm with different networks(1 from net1, 1 from net2).\nL102 means creating vm with different networks(2 from net1, 1 from net2).\n\nAlso see comments in L59 and L96, the purpose of these 2 tests are different. Thought?","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8339d88f63f79c719d404dbd5822e584799748c9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5488b7c4","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"in_reply_to":"7f96bb07_14f30fa0","updated":"2018-01-24 08:18:26.000000000","message":"Oh, then can test_verify_duplicate_network_nics cover test_verify_multiple_nics_order?","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"910953b11f16028dc53b571b8bbfbb62c717cdb1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_ce9bd3c6","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"in_reply_to":"7f96bb07_5488b7c4","updated":"2018-01-24 08:39:37.000000000","message":"Thanks for your review, @zhufl. : )\n\nI think your mean is remove test_verify_multiple_nics_order, and leave this test_verify_duplicate_network_nics case?\n\nBut I would prefer to think test_verify_multiple_nics_order is basic case. (1 from net1, 1 from net2)\n\nAfter this, we add test_verify_duplicate_network_nics, we regards it as a advanced case, or to say as a supplementary case. (2 from net1, 1 from net2), to check this logic point: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L374 \n\nright? and your idea?","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f89e09f6de2dff90fac720a7fb6f4e4379bcfab0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_743a00e8","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"in_reply_to":"7f96bb07_57e75613","updated":"2018-01-25 03:48:40.000000000","message":"Yes if they really are for different purposes.\nI don\u0027t understand how to test \"Verify that the networks order given at the server creation is preserved within the server.\",\nso I think test_verify_multiple_nics_order seems just a subset of test_verify_duplicate_network_nics(though I don\u0027t know what\u0027s\nthe test purpose of test_verify_multiple_nics_order)","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5668d7fbafa069327443c9cf9db18612defcdec","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":93,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":94,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":95,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":96,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":97,"context_line":"        # is created on the same network."},{"line_number":98,"context_line":"        default_cidr \u003d CONF.network.project_network_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_57e75613","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":42},"in_reply_to":"7f96bb07_ce9bd3c6","updated":"2018-01-24 10:28:31.000000000","message":"i agree with that we should not merge or delete these tests as both have their own purpose. \n\ntest_verify_duplicate_network_nics - make sure the duplicate nic are allowed \n\ntest_verify_multiple_nics_order - order of requested network are honored in created server.","commit_id":"38f6878b86aa42d0462e41a8b3be9b506ab85e52"}],"tempest/config.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ec2070ae69bf73014ce2e9b8ced2fd1932480af3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                    \"If both values are not specified, Tempest avoids tests \""},{"line_number":334,"context_line":"                    \"which require a microversion. Valid values are string \""},{"line_number":335,"context_line":"                    \"with format \u0027X.Y\u0027 or string \u0027latest\u0027\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027default_network_cidr\u0027,"},{"line_number":337,"context_line":"               default\u003d\"19.80.0.0/24\","},{"line_number":338,"context_line":"               help\u003d\"The default network cidr block to allocate project ipv4 \""},{"line_number":339,"context_line":"                    \"subnets from.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_e9899374","line":336,"range":{"start_line":336,"start_character":4,"end_line":336,"end_character":37},"updated":"2018-01-18 06:01:38.000000000","message":"what\u0027s the difference between this and CONF.network.project_network_cidr?","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"91b597bc5a487762abf4edee3dc91729ef097236","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                    \"If both values are not specified, Tempest avoids tests \""},{"line_number":334,"context_line":"                    \"which require a microversion. Valid values are string \""},{"line_number":335,"context_line":"                    \"with format \u0027X.Y\u0027 or string \u0027latest\u0027\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027default_network_cidr\u0027,"},{"line_number":337,"context_line":"               default\u003d\"19.80.0.0/24\","},{"line_number":338,"context_line":"               help\u003d\"The default network cidr block to allocate project ipv4 \""},{"line_number":339,"context_line":"                    \"subnets from.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_dbe81eb4","line":336,"range":{"start_line":336,"start_character":4,"end_line":336,"end_character":37},"in_reply_to":"7f96bb07_e9899374","updated":"2018-01-18 06:47:51.000000000","message":"It is no difference, but I\u0027m not sure a network config can be used in compute test case, so I separate it in compute group.\n\nAfter your reminder, I found many network configs are used in compute testcase, So, we can use network.project_network_cidr directly.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4a171faa2dcf835a6ebd2eb6a4e2629cb560ff69","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    \"which require a microversion. Valid values are string \""},{"line_number":335,"context_line":"                    \"with format \u0027X.Y\u0027 or string \u0027latest\u0027\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027default_network_cidr\u0027,"},{"line_number":337,"context_line":"               default\u003d\"19.80.0.0/24\","},{"line_number":338,"context_line":"               help\u003d\"The default network cidr block to allocate project ipv4 \""},{"line_number":339,"context_line":"                    \"subnets from.\"),"},{"line_number":340,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_34b27a4a","line":337,"range":{"start_line":337,"start_character":24,"end_line":337,"end_character":36},"updated":"2018-01-18 01:27:56.000000000","message":"why not a private cidr?","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"91b597bc5a487762abf4edee3dc91729ef097236","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    \"which require a microversion. Valid values are string \""},{"line_number":335,"context_line":"                    \"with format \u0027X.Y\u0027 or string \u0027latest\u0027\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027default_network_cidr\u0027,"},{"line_number":337,"context_line":"               default\u003d\"19.80.0.0/24\","},{"line_number":338,"context_line":"               help\u003d\"The default network cidr block to allocate project ipv4 \""},{"line_number":339,"context_line":"                    \"subnets from.\"),"},{"line_number":340,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_1bc446f4","line":337,"range":{"start_line":337,"start_character":24,"end_line":337,"end_character":36},"in_reply_to":"7f96bb07_34b27a4a","updated":"2018-01-18 06:47:51.000000000","message":"My first mind is keeping same with original case.","commit_id":"0a8189943cac5b3d2d5e37175748dfe5d70cfd3b"}]}