)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5c6de709dd24067afad2a9fa6bd900eabfea5291","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Remove redundant volume backed LM test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes the redundant test_iscsi_volume from the set of"},{"line_number":10,"context_line":"admin compute API live mirgration tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic166d425fb9a71ff8e77967ff28edefc011945c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_0c183cd1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":40},"updated":"2018-01-22 02:32:30.000000000","message":"Would you please put more details about where the test steps in test_iscsi_volume are covered?","commit_id":"b01cad8cceb69c44533b6d51d1c7acd09bce6cea"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"988a3230d2937f620ae608af7f35e9f87632c41a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Remove redundant volume backed LM test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes the redundant test_iscsi_volume from the set of"},{"line_number":10,"context_line":"admin compute API live mirgration tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic166d425fb9a71ff8e77967ff28edefc011945c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f93b717_32cefa62","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":40},"updated":"2018-02-02 02:16:20.000000000","message":"need more details of why test_iscsi_volume is redundant","commit_id":"618c79ca7c914d43f2746f9a5bc599e6a26d86d6"}],"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9dccffcc1ff8396a11b1f054a6c3843a4e7923da","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        volume_id2 \u003d server[\"os-extended-volumes:volumes_attached\"][0][\"id\"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assertEqual(target_host, self.get_host_for_server(server_id))"},{"line_number":169,"context_line":"        self.assertEqual(volume_id1, volume_id2)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class LiveMigrationRemoteConsolesV26Test(LiveMigrationTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_4b6bc8ef","side":"PARENT","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":48},"updated":"2018-02-02 10:42:07.000000000","message":"This isn\u0027t tested anymore, IMHO it\u0027s a useless test.","commit_id":"47022c1a2856e48c8b8f70387410f824297824b7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e3f09d6a89dd6debe484d31d731a149a878edb8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        volume_id2 \u003d server[\"os-extended-volumes:volumes_attached\"][0][\"id\"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assertEqual(target_host, self.get_host_for_server(server_id))"},{"line_number":169,"context_line":"        self.assertEqual(volume_id1, volume_id2)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class LiveMigrationRemoteConsolesV26Test(LiveMigrationTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_2ce65446","side":"PARENT","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":48},"in_reply_to":"3fa0c359_9d6c7809","updated":"2018-02-06 10:19:33.000000000","message":"There\u0027s no attempt to switch volumes here, only to migrate the instance to another node that would never result in a volume being attached with a new id on the destination.","commit_id":"47022c1a2856e48c8b8f70387410f824297824b7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2d75d03b63050d6082b08baadeaf33b81b5ce990","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        volume_id2 \u003d server[\"os-extended-volumes:volumes_attached\"][0][\"id\"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assertEqual(target_host, self.get_host_for_server(server_id))"},{"line_number":169,"context_line":"        self.assertEqual(volume_id1, volume_id2)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class LiveMigrationRemoteConsolesV26Test(LiveMigrationTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_9d6c7809","side":"PARENT","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":48},"in_reply_to":"5f93b717_4b6bc8ef","updated":"2018-02-06 06:28:45.000000000","message":"why?","commit_id":"47022c1a2856e48c8b8f70387410f824297824b7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2d75d03b63050d6082b08baadeaf33b81b5ce990","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":153,"context_line":"                          block_migration_for_live_migration,"},{"line_number":154,"context_line":"                          \u0027Block Live migration not available\u0027)"},{"line_number":155,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":156,"context_line":"                          volume_backed_live_migration,"},{"line_number":157,"context_line":"                          \u0027Volume-backed live migration not available\u0027)"},{"line_number":158,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":159,"context_line":"                          block_migrate_cinder_iscsi,"},{"line_number":160,"context_line":"                          \u0027Block Live migration not configured for iSCSI\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_9de6b8e8","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":71},"updated":"2018-02-06 06:28:45.000000000","message":"why add this?","commit_id":"d8f03f4ca3de1789688d6a5382651cab30093ac6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e3f09d6a89dd6debe484d31d731a149a878edb8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":153,"context_line":"                          block_migration_for_live_migration,"},{"line_number":154,"context_line":"                          \u0027Block Live migration not available\u0027)"},{"line_number":155,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":156,"context_line":"                          volume_backed_live_migration,"},{"line_number":157,"context_line":"                          \u0027Volume-backed live migration not available\u0027)"},{"line_number":158,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":159,"context_line":"                          block_migrate_cinder_iscsi,"},{"line_number":160,"context_line":"                          \u0027Block Live migration not configured for iSCSI\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_4c5160d8","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":71},"in_reply_to":"3fa0c359_9de6b8e8","updated":"2018-02-06 10:19:33.000000000","message":"I was going to suggest deprecating block_migrate_cinder_iscsi and just using volume_backed_live_migration as they are really control the same thing, live migration with volumes attached.","commit_id":"d8f03f4ca3de1789688d6a5382651cab30093ac6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2d75d03b63050d6082b08baadeaf33b81b5ce990","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                          block_migrate_cinder_iscsi,"},{"line_number":160,"context_line":"                          \u0027Block Live migration not configured for iSCSI\u0027)"},{"line_number":161,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":162,"context_line":"    def test_live_block_migration_with_volume_attached(self):"},{"line_number":163,"context_line":"        self._test_live_migration(volume_attached\u003dTrue)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_dd620017","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":54},"updated":"2018-02-06 06:28:45.000000000","message":"This new name looks better, and if the testcase name no longer contains \"iscsi\", \nshould CONF.compute_feature_enabled.block_migrate_cinder_iscsi keep nochange?\nTo tell the truth, I don\u0027t understand the difference between block_migration_for_live_migration\nand block_migrate_cinder_iscsi","commit_id":"d8f03f4ca3de1789688d6a5382651cab30093ac6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e3f09d6a89dd6debe484d31d731a149a878edb8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                          block_migrate_cinder_iscsi,"},{"line_number":160,"context_line":"                          \u0027Block Live migration not configured for iSCSI\u0027)"},{"line_number":161,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":162,"context_line":"    def test_live_block_migration_with_volume_attached(self):"},{"line_number":163,"context_line":"        self._test_live_migration(volume_attached\u003dTrue)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_2c02d4b5","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":54},"in_reply_to":"3fa0c359_dd620017","updated":"2018-02-06 10:19:33.000000000","message":"As above I think we can deprecate it now and just use volume_backed_live_migration.\n\nblock_migration_for_live_migration allows the live migration of instances without shared storage, AKA block migration. This results in this storage being copied from the source to the destination during the migration.\n\nhttps://docs.openstack.org/nova/latest/admin/configuring-migrations.html#section-configuring-compute-migrations\n\ntest_iscsi_volume and now test_live_block_migration_with_volume_attached both cover live migration with block migration of local disks _and_ volume migration.","commit_id":"d8f03f4ca3de1789688d6a5382651cab30093ac6"}]}