)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef92050bd705a12472b59e7cc2b0316951a34516","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def test_live_block_migration_paused(self):"},{"line_number":143,"context_line":"        self._test_live_migration(state\u003d\u0027PAUSED\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":146,"context_line":"                          volume_backed_live_migration,"},{"line_number":147,"context_line":"                          \u0027Volume-backed live migration not available\u0027)"},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u00275071cf17-3004-4257-ae61-73a84e28badd\u0027)"},{"line_number":149,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":150,"context_line":"    def test_volume_backed_live_migration(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_d703e40e","line":147,"range":{"start_line":145,"start_character":4,"end_line":147,"end_character":71},"updated":"2018-01-24 19:06:51.000000000","message":"You also need this on your new volume-backed test.","commit_id":"59b1314d924766870e8edc5e0828ca7f7ad1fd17"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5fb2144dc657462d2f29f5c61344438ab1c88a5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # live migrated would be a nice test wrinkle addition."},{"line_number":57,"context_line":"        cls.set_network_resources(network\u003dTrue, subnet\u003dTrue)"},{"line_number":58,"context_line":"        super(LiveMigrationTest, cls).setup_credentials()"},{"line_number":59,"context_line":"        cls.admin_volume_types_client \u003d cls.os_admin.volume_types_v2_client"},{"line_number":60,"context_line":"        cls.admin_encryption_types_client \u003d\\"},{"line_number":61,"context_line":"            cls.os_admin.encryption_types_v2_client"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_f2cd4e31","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":51},"updated":"2018-03-13 02:58:06.000000000","message":"These should not be placed here. Maybe you can put them in BaseV2ComputeAdminTest.setup_clients","commit_id":"23c5251c796003d209dc654c0d4930bcbb93ebf1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5fb2144dc657462d2f29f5c61344438ab1c88a5","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                          block_migration_for_live_migration,"},{"line_number":178,"context_line":"                          \u0027Block Live migration not available\u0027)"},{"line_number":179,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":180,"context_line":"                          volume_backed_live_migration,"},{"line_number":181,"context_line":"                          \u0027Volume-backed live migration not available\u0027)"},{"line_number":182,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":183,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_f2f6ae63","line":180,"range":{"start_line":180,"start_character":26,"end_line":180,"end_character":55},"updated":"2018-03-13 02:58:06.000000000","message":"is this needed?","commit_id":"23c5251c796003d209dc654c0d4930bcbb93ebf1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5fb2144dc657462d2f29f5c61344438ab1c88a5","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.attach_encrypted_volume,"},{"line_number":196,"context_line":"                          \u0027Encrypted volume attach is not supported\u0027)"},{"line_number":197,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":198,"context_line":"    def test_encrypted_and_unencrypted_volume_attached_live_migration(self):"},{"line_number":199,"context_line":"        self._test_live_migration(volume_backed\u003dTrue,"},{"line_number":200,"context_line":"                                  encrypted_volume_attached\u003dTrue)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_52267ad0","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":69},"updated":"2018-03-13 02:58:06.000000000","message":"1. The testcase name is a bit confusing\n2. We have testcase for volume_backed\u003dTrue and testcase for encrypted_volume_attached\u003dTrue, so do we need testcase for both volume_backed\u003dTrue and encrypted_volume_attached\u003dTrue?","commit_id":"23c5251c796003d209dc654c0d4930bcbb93ebf1"}],"tempest/api/compute/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5fb2144dc657462d2f29f5c61344438ab1c88a5","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        if not name:"},{"line_number":463,"context_line":"            class_name \u003d cls.__class__.__name__"},{"line_number":464,"context_line":"            name \u003d data_utils.rand_name(class_name + \u0027-volume-type\u0027)"},{"line_number":465,"context_line":"        randomized_name \u003d data_utils.rand_name(\u0027scenario-type-\u0027 + name)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        LOG.debug(\"Creating a volume type: %s on backend %s\","},{"line_number":468,"context_line":"                  randomized_name, backend_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_929c120f","line":465,"range":{"start_line":465,"start_character":8,"end_line":465,"end_character":71},"updated":"2018-03-13 02:58:06.000000000","message":"This is not needed, name is already a random name","commit_id":"23c5251c796003d209dc654c0d4930bcbb93ebf1"}]}
