)]}'
{"tempest/api/image/admin/test_images.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e18bea27e399310f10100e3a2d696bfb870088ea","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BasicOperationsImagesAdminTest(base.BaseV2ImageAdminTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @decorators.related_bug(\u00271420008\u0027)"},{"line_number":24,"context_line":"    @decorators.idempotent_id(\u0027646a6eaa-135f-4493-a0af-12583021224e\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_74e8e1b1","line":21,"updated":"2018-02-13 23:57:43.000000000","message":"Could you create this test module under tempest/api/image/v2/admin because of base.BaseV2ImageAdminTest :-)","commit_id":"14ea14e086a40527dd9e5bc0ec57d797a69d7a8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5b5943ec9fb48582b61c2deba902889237afffe3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BasicOperationsImagesAdminTest(base.BaseV2ImageAdminTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @decorators.related_bug(\u00271420008\u0027)"},{"line_number":24,"context_line":"    @decorators.idempotent_id(\u0027646a6eaa-135f-4493-a0af-12583021224e\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_ce8a8162","line":21,"in_reply_to":"3fa0c359_74e8e1b1","updated":"2018-02-14 07:12:21.000000000","message":"Done","commit_id":"14ea14e086a40527dd9e5bc0ec57d797a69d7a8d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e18bea27e399310f10100e3a2d696bfb870088ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @decorators.related_bug(\u00271420008\u0027)"},{"line_number":24,"context_line":"    @decorators.idempotent_id(\u0027646a6eaa-135f-4493-a0af-12583021224e\u0027)"},{"line_number":25,"context_line":"    def test_create_image_owner_param(self):"},{"line_number":26,"context_line":"        random_id \u003d data_utils.rand_uuid_hex()"},{"line_number":27,"context_line":"        image \u003d self.admin_client.create_image("},{"line_number":28,"context_line":"            container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027raw\u0027, owner\u003drandom_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_54336562","line":25,"updated":"2018-02-13 23:57:43.000000000","message":"Could you add some NOTE to explain why we need admin credential for this operation here?\nMaybe admin user only can create/update images with *owner* parameter, right?","commit_id":"14ea14e086a40527dd9e5bc0ec57d797a69d7a8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5b5943ec9fb48582b61c2deba902889237afffe3","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @decorators.related_bug(\u00271420008\u0027)"},{"line_number":24,"context_line":"    @decorators.idempotent_id(\u0027646a6eaa-135f-4493-a0af-12583021224e\u0027)"},{"line_number":25,"context_line":"    def test_create_image_owner_param(self):"},{"line_number":26,"context_line":"        random_id \u003d data_utils.rand_uuid_hex()"},{"line_number":27,"context_line":"        image \u003d self.admin_client.create_image("},{"line_number":28,"context_line":"            container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027raw\u0027, owner\u003drandom_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa0c359_6eeb2d12","line":25,"in_reply_to":"3fa0c359_54336562","updated":"2018-02-14 07:12:21.000000000","message":"Done","commit_id":"14ea14e086a40527dd9e5bc0ec57d797a69d7a8d"}],"tempest/api/image/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"445a46efe52b67a8b2d62dd41ccbce9608bc6eb6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return image[\u0027id\u0027]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class BaseV2ImageAdminTest(BaseImageTest):"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    credentials \u003d [\u0027admin\u0027, \u0027primary\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_e5e21ad5","line":188,"range":{"start_line":188,"start_character":27,"end_line":188,"end_character":40},"updated":"2018-02-13 06:20:30.000000000","message":"should be BaseV2ImageTest?","commit_id":"f96a09d4548f797851dc91930fa02fee53fe95ae"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4f655f44e1e338fe08da4fafa6c580fa66bb4adc","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return image[\u0027id\u0027]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class BaseV2ImageAdminTest(BaseImageTest):"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    credentials \u003d [\u0027admin\u0027, \u0027primary\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_2bde93d9","line":188,"range":{"start_line":188,"start_character":27,"end_line":188,"end_character":40},"in_reply_to":"3fa0c359_e5e21ad5","updated":"2018-02-13 08:13:44.000000000","message":"Thanks,\nDone","commit_id":"f96a09d4548f797851dc91930fa02fee53fe95ae"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"445a46efe52b67a8b2d62dd41ccbce9608bc6eb6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    @classmethod"},{"line_number":193,"context_line":"    def setup_clients(cls):"},{"line_number":194,"context_line":"        super(BaseV2ImageAdminTest, cls).setup_clients()"},{"line_number":195,"context_line":"        cls.client \u003d cls.os_primary.image_client_v2"},{"line_number":196,"context_line":"        cls.admin_client \u003d cls.os_admin.image_client_v2"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_05d94620","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":51},"updated":"2018-02-13 06:20:30.000000000","message":"this can be removed","commit_id":"f96a09d4548f797851dc91930fa02fee53fe95ae"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4f655f44e1e338fe08da4fafa6c580fa66bb4adc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    @classmethod"},{"line_number":193,"context_line":"    def setup_clients(cls):"},{"line_number":194,"context_line":"        super(BaseV2ImageAdminTest, cls).setup_clients()"},{"line_number":195,"context_line":"        cls.client \u003d cls.os_primary.image_client_v2"},{"line_number":196,"context_line":"        cls.admin_client \u003d cls.os_admin.image_client_v2"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_ebf50b58","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":51},"in_reply_to":"3fa0c359_05d94620","updated":"2018-02-13 08:13:44.000000000","message":"Done","commit_id":"f96a09d4548f797851dc91930fa02fee53fe95ae"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"62b1a0e36a6ae87d1df098a42e07745720bbbb7d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def test_create_image_owner_param(self):"},{"line_number":164,"context_line":"        image \u003d self.create_image(container_format\u003d\u0027bare\u0027,"},{"line_number":165,"context_line":"                                  disk_format\u003d\u0027raw\u0027,"},{"line_number":166,"context_line":"                                  owner\u003dself.client.tenant_id)"},{"line_number":167,"context_line":"        image_info \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":168,"context_line":"        self.assertEqual(self.client.tenant_id, image_info[\u0027owner\u0027])"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_37d79fc2","line":166,"updated":"2018-02-05 09:42:14.000000000","message":"I\u0027m actually not sure that the bug is for create_image(). I just only see \"update\" not create on the bug report[0]. So, why should we test for \"create_image\" instead of \"update_image\" here?\n\n[0] https://bugs.launchpad.net/glance/+bug/1420008","commit_id":"fb9bf4d9570829c944c905fbb1aec32665cc01f1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"729e1599c6d4f2901845712bc6fba08b049d95aa","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def test_create_image_owner_param(self):"},{"line_number":164,"context_line":"        image \u003d self.create_image(container_format\u003d\u0027bare\u0027,"},{"line_number":165,"context_line":"                                  disk_format\u003d\u0027raw\u0027,"},{"line_number":166,"context_line":"                                  owner\u003dself.client.tenant_id)"},{"line_number":167,"context_line":"        image_info \u003d self.client.show_image(image[\u0027id\u0027])"},{"line_number":168,"context_line":"        self.assertEqual(self.client.tenant_id, image_info[\u0027owner\u0027])"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_32ab2dd7","line":166,"in_reply_to":"3fa0c359_37d79fc2","updated":"2018-02-05 09:55:14.000000000","message":"Thanks for your comment,\nThere is also bug related to image create, as you can see in  \nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1387467\nWe should also test \"update_image\"","commit_id":"fb9bf4d9570829c944c905fbb1aec32665cc01f1"}]}