)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":6578,"name":"Tal Kammer","email":"tkammer@redhat.com","username":"tkammer"},"change_message_id":"c3ffff349e582a286ae3ebccdc1c5ac74e85a2d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Options defined in tempest.openstack.common.lockutils"},{"line_number":5,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAATn%2F%2FGx0%3D","line":2,"updated":"2013-11-14 11:15:49.000000000","message":"Why is all the default values commented out?\nSince this file is suppose to be a template style file, I believe the defaults should be empty istead of the \u003cNone\u003e\nso for example:\nuri\u003d\ninstead of\n#uri\u003d\u003cNone\u003e","commit_id":"b5538bacd2c603258fecb845e2a80aaedd39af63"}],"tools/config/check_uptodate.sh":[{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"f689b5c62378cdd4d8a82551a9eae4c55cbbae3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"TEMPDIR\u003d`mktemp -d`"},{"line_number":3,"context_line":"CFGFILE\u003dtempest.conf.sample"},{"line_number":4,"context_line":"tools/config/generate_sample.sh -b ./ -p tempest -o $TEMPDIR"},{"line_number":5,"context_line":"if ! diff $TEMPDIR/$CFGFILE etc/$CFGFILE"},{"line_number":6,"context_line":"then"},{"line_number":7,"context_line":"    echo \"E: tempest.conf.sample is not up to date, please run:\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAATn%2F%2FtBI%3D","line":4,"updated":"2013-10-30 08:05:26.000000000","message":"It seems as if we can use a variable to store \"tempest\", and then use the variable in line 3 and line 4. \n\nMaybe we can use a argument to store \"tempest\" and then pass it to \ntools/config/check_uptodate.sh.","commit_id":"b5538bacd2c603258fecb845e2a80aaedd39af63"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"9459a711e2bccc7a7b476b75a98ff9ba199590e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"TEMPDIR\u003d`mktemp -d`"},{"line_number":3,"context_line":"CFGFILE\u003dtempest.conf.sample"},{"line_number":4,"context_line":"tools/config/generate_sample.sh -b ./ -p tempest -o $TEMPDIR"},{"line_number":5,"context_line":"if ! diff $TEMPDIR/$CFGFILE etc/$CFGFILE"},{"line_number":6,"context_line":"then"},{"line_number":7,"context_line":"    echo \"E: tempest.conf.sample is not up to date, please run:\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAATn%2F%2FozQ%3D","line":4,"in_reply_to":"AAAATn%2F%2Frfs%3D","updated":"2013-10-31 03:55:31.000000000","message":"Hi Matthew Treinish,\n1. Firstly, this code change LGTM.\n\"Do not change any of the values here\". I agree.\n\n2. I just want to do deep discussion.\n\"check_uptodate.sh\" can be enhanced to become a common code.\n\n\"CFGFILE\u003dtempest.conf.sample\" and \"-p tempest\" are dependent.\n\nI pick up some code from tools/config/generate_sample.sh:\n\t-p|--package-name)\n            PACKAGENAME\u003d`echo $1`\n            ...\n\tOUTPUTFILE\u003d$OUTPUTDIR/$PACKAGENAME.conf.sample\n        ...\ngenerate_sample.sh will use \"$PACKAGENAME\" to create \"$PACKAGENAME.conf.sample\"  and put it to \"$TEMPDIR/\"\n\nOn line 5, we will compare \"$TEMPDIR/$CFGFILE\" and \"etc/$CFGFILE\". \nSo \"$PACKAGENAME.conf.sample\" has to equal \"$CFGFILE\"","commit_id":"b5538bacd2c603258fecb845e2a80aaedd39af63"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd4412efd8c8204e51213a0674a4893a42b9290e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"TEMPDIR\u003d`mktemp -d`"},{"line_number":3,"context_line":"CFGFILE\u003dtempest.conf.sample"},{"line_number":4,"context_line":"tools/config/generate_sample.sh -b ./ -p tempest -o $TEMPDIR"},{"line_number":5,"context_line":"if ! diff $TEMPDIR/$CFGFILE etc/$CFGFILE"},{"line_number":6,"context_line":"then"},{"line_number":7,"context_line":"    echo \"E: tempest.conf.sample is not up to date, please run:\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAATn%2F%2Frfs%3D","line":4,"in_reply_to":"AAAATn%2F%2FtBI%3D","updated":"2013-10-30 14:26:33.000000000","message":"No, just because tempest is part of the config file name and the project name that doesn\u0027t mean that they are shared values that should have a common variable, they are independent.\n\nThis script is just a quick wrapper (that is based on the one in nova) that is being used for the tox pep8 job to just make sure the sample file (which is in tree) is up to date. There isn\u0027t any reason to change any of the values here.","commit_id":"b5538bacd2c603258fecb845e2a80aaedd39af63"}]}