)]}'
{"tempest/api/compute/servers/test_disk_config.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"5205893646945214eed7940d840cd0bb9171d5eb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fs8I%3D","line":42,"updated":"2013-10-30 08:21:13.000000000","message":"I think this change just make we can share server when OS-DCF:diskConfig is that expected.\nwhy not update the disk_config of the server, when OS-DCF:diskConfig is not that we expected? \nyour change is ok, I\u0027m not sure which will increase more load between update the old sever and create a new one. I guess create:)","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"7e301d1f448177380c6ff297b5881980cd805ba7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FsUg%3D","line":42,"updated":"2013-10-30 11:18:09.000000000","message":"Maybe we will delete the server and create a new server duo to self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])\n\nCan we make sure that disk_config awalys equals server[\u0027OS-DCF:diskConfig\u0027] ?\nAll test_* should be no dependence.","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"40468d9a02dbdd2842d48d49fc5c5857e2530a30","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fo1o%3D","line":42,"in_reply_to":"AAAATn%2F%2Fo3s%3D","updated":"2013-10-31 03:14:20.000000000","message":"\u003e Maybe we will \"delete the server and create a new one\" or \"reuse the server\". It depends on the previous test.\n\nYou are right.\nThe preparing behavior for each test depends on its previous test.\n\nDo you mean the preparation also should depend on the previous test?","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"40468d9a02dbdd2842d48d49fc5c5857e2530a30","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fo2I%3D","line":42,"in_reply_to":"AAAATn%2F%2Fo5A%3D","updated":"2013-10-31 03:14:20.000000000","message":"Thanks for your help.\nI see his comment.\n\nI will change here to compute-client\u0027s update_server() call after this discussion.","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3e80f3d2a38e6f14d698cb86d5355e19299f2107","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FsOU%3D","line":42,"in_reply_to":"AAAATn%2F%2Fs8I%3D","updated":"2013-10-30 11:39:55.000000000","message":"Hi Ivan-Zhu,\n\nThanks for your reviewing. That is an interesting idea :-)\nI think both costs are not so different because \"rebuild a server\" destroys the existing server and creates a new server.\nThat is almost the same as here\u0027s re-creation behavior.\n\nin addition, I feel the combination of both delete_server() and create_server() is safer than rebuild(). This is not strong opinion, just feeling.","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"20c850f57f49e3e520baddc11465a57af9120bd0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fo5A%3D","line":42,"in_reply_to":"AAAATn%2F%2FsOU%3D","updated":"2013-10-31 02:59:21.000000000","message":"Hi Ken\u0027ichi Ohmichi,\nI think Ivan-Zhu\u0027s meaning is that \"update\" vs \"create\".","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"20c850f57f49e3e520baddc11465a57af9120bd0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fo3s%3D","line":42,"in_reply_to":"AAAATn%2F%2FsSc%3D","updated":"2013-10-31 02:59:21.000000000","message":"Hi Ken\u0027ichi Ohmichi,\nThank you for your response.\n1. Please correct me, if I am wrong.\nWe can reuse the server, only when the current test need \"XXX\" status of server and the server is \"XXX\" after the previous test.\n\nWe will delete the server and create a new one, if the current test need \"XXX\" status of server, but the server is \"YYY\" after the previous test.\n\nMaybe we will \"delete the server and create a new one\" or \"reuse the server\". It depends on the previous test.\n\n\n2.\nTo reuse the server always, Can we \"update\" the server to \"XXX\", when the current test need \"XXX\" status of server.\nOf course this will depends on the \"update\" function.","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3e80f3d2a38e6f14d698cb86d5355e19299f2107","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":40,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":42,"context_line":"            self.assertEqual(disk_config, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            if self.server_id is not None:"},{"line_number":45,"context_line":"                self.client.delete_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FsSc%3D","line":42,"in_reply_to":"AAAATn%2F%2FsUg%3D","updated":"2013-10-30 11:39:55.000000000","message":"Hi YangLei,\n\nSorry, I\u0027m not sure I understand your comment correctly.\n\ndisk_config is checked always by comparing server[\u0027OS-DCF:diskConfig\u0027] in this patch.\nSo I feel current code makes each test independent.","commit_id":"e53afdd699e89b32faa2673fdcd5a3d0d7872411"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"882e3935a02334cacdc8d1e7222c7b7b260709d0","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Verify the disk_config attribute is set correctly"},{"line_number":126,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027AUTO\u0027, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Update the disk_config attribute to manual"},{"line_number":130,"context_line":"        resp, server \u003d self.client.update_server(server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FklI%3D","line":127,"updated":"2013-11-01 04:59:24.000000000","message":"This verification has already been done in the _rebuild_server_with_disk_config I think","commit_id":"50969629f634e81656c7edb0a2395bc6780ba85d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8614881a488ecd761975ae4b7e35656b747de3c1","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Verify the disk_config attribute is set correctly"},{"line_number":126,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027AUTO\u0027, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Update the disk_config attribute to manual"},{"line_number":130,"context_line":"        resp, server \u003d self.client.update_server(server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fkkk%3D","line":127,"in_reply_to":"AAAATn%2F%2FklI%3D","updated":"2013-11-01 05:01:22.000000000","message":"Thanks for catching this.\n\nI will fix this soon.","commit_id":"50969629f634e81656c7edb0a2395bc6780ba85d"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3d58833ef2918925d6680d77e6e9f0122fc62184","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(\u0027MANUAL\u0027, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":121,"context_line":"    def test_update_server_from_auto_to_manual(self):"},{"line_number":122,"context_line":"        # A server should be updated from auto to manual disk config"},{"line_number":123,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027AUTO\u0027)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FhhY%3D","line":121,"updated":"2013-11-02 13:23:26.000000000","message":"now, this tests is redundant. I think.","commit_id":"889690d45fd5fc4bff9b7e42362b75d9f093566b"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"83e45435a11d7f347ec9fc187a74680643260c4a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(\u0027MANUAL\u0027, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":121,"context_line":"    def test_update_server_from_auto_to_manual(self):"},{"line_number":122,"context_line":"        # A server should be updated from auto to manual disk config"},{"line_number":123,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027AUTO\u0027)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FZlk%3D","line":121,"in_reply_to":"AAAATn%2F%2FeqA%3D","updated":"2013-11-07 07:50:04.000000000","message":"It\u0027s ok, not strongly.","commit_id":"889690d45fd5fc4bff9b7e42362b75d9f093566b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"63bd54105793176dd388317e84814f04a24d3393","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(\u0027MANUAL\u0027, server[\u0027OS-DCF:diskConfig\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":121,"context_line":"    def test_update_server_from_auto_to_manual(self):"},{"line_number":122,"context_line":"        # A server should be updated from auto to manual disk config"},{"line_number":123,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027AUTO\u0027)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FeqA%3D","line":121,"in_reply_to":"AAAATn%2F%2FhhY%3D","updated":"2013-11-05 04:48:27.000000000","message":"You mean that this test is executed in _rebuild_server_with_disk_config() already and we should remove this test. right?\n\nin my opinion, it is better to keep this test case because update_server() would not be executed in _rebuild_server_with_disk_config() if adding some tests to this class and they could make necessary disk_config status.\nI know that is kind of miracle :-) but it would be good to execute the test clearly.","commit_id":"889690d45fd5fc4bff9b7e42362b75d9f093566b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cae7d4a507896fc9f0fec0eaee2ef6836bf85508","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                                   wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            self.server_id \u003d server[\u0027id\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":45,"context_line":"                                               \u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FIHw%3D","line":43,"updated":"2013-11-14 04:23:05.000000000","message":"I don\u0027t think the try/catch + assert is good here I would instead:\n\n  1. create a server in setUpClass\n  2. modify this to just rebuild with the passed disk_config","commit_id":"e3d8ca8a4f064bd1ef9a249771d095ae126c2422"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cae7d4a507896fc9f0fec0eaee2ef6836bf85508","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":57,"context_line":"    def test_rebuild_server_with_manual_disk_config(self):"},{"line_number":58,"context_line":"        # A server should be rebuilt using the manual disk config option"},{"line_number":59,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027AUTO\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        resp, server \u003d self.client.rebuild(self.server_id,"},{"line_number":62,"context_line":"                                           self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FIIE%3D","line":59,"updated":"2013-11-14 04:23:05.000000000","message":"you don\u0027t need this here, just rebuild regardless","commit_id":"e3d8ca8a4f064bd1ef9a249771d095ae126c2422"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cae7d4a507896fc9f0fec0eaee2ef6836bf85508","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":73,"context_line":"    def test_rebuild_server_with_auto_disk_config(self):"},{"line_number":74,"context_line":"        # A server should be rebuilt using the auto disk config option"},{"line_number":75,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027MANUAL\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        resp, server \u003d self.client.rebuild(self.server_id,"},{"line_number":78,"context_line":"                                           self.image_ref_alt,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FIIA%3D","line":75,"updated":"2013-11-14 04:23:05.000000000","message":"same as line 59","commit_id":"e3d8ca8a4f064bd1ef9a249771d095ae126c2422"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cae7d4a507896fc9f0fec0eaee2ef6836bf85508","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @testtools.skipUnless(compute.RESIZE_AVAILABLE, \u0027Resize not available.\u0027)"},{"line_number":89,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":90,"context_line":"    def test_resize_server_from_manual_to_auto(self):"},{"line_number":91,"context_line":"        # A server should be resized from manual to auto disk config"},{"line_number":92,"context_line":"        self._rebuild_server_with_disk_config(disk_config\u003d\u0027MANUAL\u0027)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FIHs%3D","line":90,"updated":"2013-11-14 04:23:05.000000000","message":"I think this test and the next one really should just be merged so you implement the transition from one state into another","commit_id":"e3d8ca8a4f064bd1ef9a249771d095ae126c2422"}]}