)]}'
{"tempest/api/image/v1/test_image_members.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"f2821dc0a1f5dee95ab2cd566c0d70465d73769c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.alt_manager \u003d cls.get_client_manager("},{"line_number":32,"context_line":"            \u0027alt\u0027,"},{"line_number":33,"context_line":"            alt_manager\u003dclients.AltManager)"},{"line_number":34,"context_line":"        cls.alt_client \u003d cls.alt_manager.images_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if cls.config.compute.allow_tenant_isolation:"},{"line_number":37,"context_line":"            creds \u003d cls.isolated_creds.get_alt_creds()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FgD0%3D","line":34,"updated":"2013-11-04 09:08:13.000000000","message":"What is this? Not used. Perhaps the code right below was supposed to be replaced.","commit_id":"fdc1eff7a16dc8c9c4e7aeaa5bba14eb75a7bf91"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"dd5e0cbc2b03be22ef5130bcab567b5d1e4d7e85","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.alt_manager \u003d cls.get_client_manager("},{"line_number":32,"context_line":"            \u0027alt\u0027,"},{"line_number":33,"context_line":"            alt_manager\u003dclients.AltManager)"},{"line_number":34,"context_line":"        cls.alt_client \u003d cls.alt_manager.images_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if cls.config.compute.allow_tenant_isolation:"},{"line_number":37,"context_line":"            creds \u003d cls.isolated_creds.get_alt_creds()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Ffck%3D","line":34,"in_reply_to":"AAAATn%2F%2FgD0%3D","updated":"2013-11-04 17:13:59.000000000","message":"Done","commit_id":"fdc1eff7a16dc8c9c4e7aeaa5bba14eb75a7bf91"}],"tempest/test.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a4ad3c02d1f75d474cd5e625dbe3a225c565f7d9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if (cls.config.compute.allow_tenant_isolation or"},{"line_number":248,"context_line":"            force_tenant_isolation):"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            get_creds \u003d {"},{"line_number":251,"context_line":"                \u0027primary\u0027: cls.isolated_creds.get_primary_creds,"},{"line_number":252,"context_line":"                \u0027admin\u0027: cls.isolated_creds.get_admin_creds,"},{"line_number":253,"context_line":"                \u0027alt\u0027: cls.isolated_creds.get_alt_creds"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FgkE%3D","line":250,"updated":"2013-11-03 21:52:20.000000000","message":"instead of doing this with the fall through dictionary, can we just make it a private method instead? A typo on user_type is going to generate a key error here, which is going to tend to throw people down the wrong path on debug. I\u0027d rather have the handing of this be a little more straight forward on fail.","commit_id":"a76280c9379f0c6fa31d3508b0ec17d3a9ee8b42"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"657fef4ad8e9775d382381a7b8fbca9a3a72bfb8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if (cls.config.compute.allow_tenant_isolation or"},{"line_number":248,"context_line":"            force_tenant_isolation):"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            get_creds \u003d {"},{"line_number":251,"context_line":"                \u0027primary\u0027: cls.isolated_creds.get_primary_creds,"},{"line_number":252,"context_line":"                \u0027admin\u0027: cls.isolated_creds.get_admin_creds,"},{"line_number":253,"context_line":"                \u0027alt\u0027: cls.isolated_creds.get_alt_creds"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fgig%3D","line":250,"in_reply_to":"AAAATn%2F%2FgkE%3D","updated":"2013-11-03 23:34:56.000000000","message":"Done","commit_id":"a76280c9379f0c6fa31d3508b0ec17d3a9ee8b42"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"9ccfc37aec695feb53b9054d9538855fcff929de","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                                   level\u003dNone))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @classmethod"},{"line_number":228,"context_line":"    def get_client_manager(cls, user_type\u003d\u0027primary\u0027, manager\u003dNone,"},{"line_number":229,"context_line":"                           alt_manager\u003dNone):"},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        Returns an Openstack client manager"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FGyY%3D","line":228,"updated":"2013-11-14 11:10:57.000000000","message":"The user_type seams enough to pick credentials and \u0027manger\u0027.\nDo we really need a manager and alt_manager arguments ?\n\n(BTW IMHO we have more manger than it is really reqiured)","commit_id":"8fb6ef502d4d481d968d93b0a5bd0d0e91b4c744"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"353a42d3f59ecd2693e5df87bd8a6b69a3726f8b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                                   level\u003dNone))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @classmethod"},{"line_number":228,"context_line":"    def get_client_manager(cls, user_type\u003d\u0027primary\u0027, manager\u003dNone,"},{"line_number":229,"context_line":"                           alt_manager\u003dNone):"},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        Returns an Openstack client manager"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FFSc%3D","line":228,"in_reply_to":"AAAATn%2F%2FGyY%3D","updated":"2013-11-14 16:27:15.000000000","message":"I thought that was enough at first but it seems some tests are mixing and matching the manager and alt manager (e.g. test_image_members.py). When I didn\u0027t account for that, these tests would not pass. My gut feeling is also that there really shouldn\u0027t be that many managers but we may need to make that change on a test-by-test basis. Thoughts?","commit_id":"8fb6ef502d4d481d968d93b0a5bd0d0e91b4c744"}]}