)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00b559daa0fa45c358362b4651e5a29dd279e394","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tal Kammer \u003ctkammer@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-10 10:07:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added images auto config support and using an existing config file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the support of auto configuring images to be used by"},{"line_number":10,"context_line":"tempest by either using existing images in glance or in case they"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FP6w%3D","line":7,"updated":"2013-11-12 09:46:38.000000000","message":"The title is too long, should be under 50 chars.\nAlslo \"and using an existing config file\" would be unnecessary.\nso how about removing it?\n\nhttps://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes","commit_id":"a0015cdf0459997470e49eaa9a76f8ce173de94e"}],"tools/tempest_auto_config.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0f49944472e9c344b6e6474716c60d232f6636a8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            format \u003d \"ami\""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if file_obj.name.endswith(\"initrd\"):"},{"line_number":323,"context_line":"            format \u003d \"ami\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # Register images in image client"},{"line_number":326,"context_line":"        image_client.images.create(name\u003dfile_obj.name, disk_format\u003dformat,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FYCw%3D","line":323,"updated":"2013-11-07 22:25:16.000000000","message":"Here should be \"ari\" instead of \"ami\"?","commit_id":"b56b5777c4b4dcc2ed9ce5910e11a6d00bdad223"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00b559daa0fa45c358362b4651e5a29dd279e394","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_image_client(self, version, *args, **kwargs):"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        This method returns Openstack glance python client"},{"line_number":94,"context_line":"        :param version: a string representing the version of the glance client"},{"line_number":95,"context_line":"        to use."},{"line_number":96,"context_line":"        :param string endpoint: A user-supplied endpoint URL for the glance"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FP8c%3D","line":93,"updated":"2013-11-12 09:46:38.000000000","message":"nit: To fit the other methods, how about changing\n\n Returns the openstack image python client","commit_id":"a0015cdf0459997470e49eaa9a76f8ce173de94e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"00b559daa0fa45c358362b4651e5a29dd279e394","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                            service."},{"line_number":98,"context_line":"        :param string token: Token for authentication."},{"line_number":99,"context_line":"        :param integer timeout: Allows customization of the timeout for client"},{"line_number":100,"context_line":"                                http requests. (optional)"},{"line_number":101,"context_line":"        :return: a Client object representing the glance client"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        if not self.image_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FP70%3D","line":100,"updated":"2013-11-12 09:46:38.000000000","message":"nit: At line 96-99, both \"string\" and \"integer\" would be unnecessary to fit the other places.","commit_id":"a0015cdf0459997470e49eaa9a76f8ce173de94e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ea7ce2fd4a75868ed09dba5f4e14b58b372ec35a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import keystoneclient.exceptions as keystone_exception"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TEMPEST_TEMP_FOLDER \u003d os.getenv(\"TEMPEST_TEMP_FOLDER\", \"/tmp\").rstrip(\u0027/\u0027)"},{"line_number":40,"context_line":"TEMPEST_ROOT_FOLDER \u003d os.getenv(\"TEMPEST_ROOT_FOLDER\","},{"line_number":41,"context_line":"                                \"/root/tempest\").rstrip(\u0027/\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FOLA%3D","line":39,"updated":"2013-11-12 17:40:53.000000000","message":"call these two *_DIR so the naming matches TEMPEST_CONFIG_DIR","commit_id":"f54005c79fb9e218fd15b3ae8386c908c9eb6bd1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ea7ce2fd4a75868ed09dba5f4e14b58b372ec35a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TEMPEST_TEMP_FOLDER \u003d os.getenv(\"TEMPEST_TEMP_FOLDER\", \"/tmp\").rstrip(\u0027/\u0027)"},{"line_number":40,"context_line":"TEMPEST_ROOT_FOLDER \u003d os.getenv(\"TEMPEST_ROOT_FOLDER\","},{"line_number":41,"context_line":"                                \"/root/tempest\").rstrip(\u0027/\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Environment variables override defaults"},{"line_number":44,"context_line":"TEMPEST_CONFIG_DIR \u003d os.getenv(\"TEMPEST_CONFIG_DIR\","}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FOKs%3D","line":41,"updated":"2013-11-12 17:40:53.000000000","message":"I would not assume this will be launched by the root user, maybe you can use ~ or $HOME","commit_id":"f54005c79fb9e218fd15b3ae8386c908c9eb6bd1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ea7ce2fd4a75868ed09dba5f4e14b58b372ec35a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"IMAGE_UEC_SOURCE_URL \u003d os.getenv(\"IMAGE_UEC_SOURCE_URL\","},{"line_number":56,"context_line":"                                 \"http://download.cirros-cloud.net/0.3.1/\""},{"line_number":57,"context_line":"                                 \"cirros-0.3.1-x86_64-uec.tar.gz\")"},{"line_number":58,"context_line":"IMAGE_ID \u003d os.getenv(\u0027IMAGE_ID\u0027)"},{"line_number":59,"context_line":"IMAGE_ID_ALT \u003d os.getenv(\u0027IMAGE_ID_ALT\u0027)"},{"line_number":60,"context_line":"IMAGE_STATUS_ACTIVE \u003d \u0027active\u0027"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FOKI%3D","line":58,"updated":"2013-11-12 17:40:53.000000000","message":"I\u0027d prefix the env variable with TEMPEST_","commit_id":"f54005c79fb9e218fd15b3ae8386c908c9eb6bd1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ea7ce2fd4a75868ed09dba5f4e14b58b372ec35a","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        return self.identity_client"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_image_client(self, version, *args, **kwargs):"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        This method returns Openstack glance python client"},{"line_number":94,"context_line":"        :param version: a string representing the version of the glance client"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FOKA%3D","line":91,"updated":"2013-11-12 17:40:53.000000000","message":"I\u0027d set some default for version here and drop it from get_image_client_kwargs","commit_id":"f54005c79fb9e218fd15b3ae8386c908c9eb6bd1"}]}