)]}'
{"tempest/api/image/v2/test_images_negative.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"6606c1a9f7e685544d08768ee69fbb67c8aea0b3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUNg%3D","line":33,"updated":"2013-11-11 05:32:32.000000000","message":"maybe need change the name. denote it\u0027s a negative test.","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQn0%3D","line":33,"in_reply_to":"AAAATn%2F%2FUNg%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"c36438635dce6a6a945f13d10384b8a6e16c5dcd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUMQ%3D","line":33,"in_reply_to":"AAAATn%2F%2FUNg%3D","updated":"2013-11-11 05:41:08.000000000","message":"Thanx Ivan-Zhu ,, I can rename it to \" test_get_delete_images_negative \"","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"cc209ff049d55df3e0738f3dd1f142535af70465","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGY%3D","line":36,"updated":"2013-11-11 06:23:33.000000000","message":"How about\n\"get image with image_id\u003dNULL\"","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQnw%3D","line":36,"in_reply_to":"AAAATn%2F%2FUGY%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"af36640b9e3e3745757b067d1754a81875b4adf8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_get_delete_image(self):"},{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUDc%3D","line":36,"in_reply_to":"AAAATn%2F%2FUGY%3D","updated":"2013-11-11 06:33:51.000000000","message":"YangLei Thanx for review,, Yep i can change to your suggestions,, yours is more clear !!","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"cc209ff049d55df3e0738f3dd1f142535af70465","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGU%3D","line":37,"updated":"2013-11-11 06:23:33.000000000","message":"How about \"get the deleted image\"","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Tests"},{"line_number":35,"context_line":"            ** get non-existent image"},{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQns%3D","line":37,"in_reply_to":"AAAATn%2F%2FUGU%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"cc209ff049d55df3e0738f3dd1f142535af70465","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # get non-existent image"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGM%3D","line":39,"updated":"2013-11-11 06:23:33.000000000","message":"ditto","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            ** get image image_id\u003dNULL"},{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # get non-existent image"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQno%3D","line":39,"in_reply_to":"AAAATn%2F%2FUGM%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"cc209ff049d55df3e0738f3dd1f142535af70465","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # get non-existent image"},{"line_number":43,"context_line":"        non_existent_id \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGE%3D","line":40,"updated":"2013-11-11 06:23:33.000000000","message":"ditto","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            ** get deleted image"},{"line_number":38,"context_line":"            ** delete non-existent image"},{"line_number":39,"context_line":"            ** delete image image_id\u003dNULL"},{"line_number":40,"context_line":"            ** delete already deleted image"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # get non-existent image"},{"line_number":43,"context_line":"        non_existent_id \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQnk%3D","line":40,"in_reply_to":"AAAATn%2F%2FUGE%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"cc209ff049d55df3e0738f3dd1f142535af70465","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete, deleted image"},{"line_number":52,"context_line":"        # create and delete image"},{"line_number":53,"context_line":"        resp, body \u003d self.create_image(name\u003d\u0027test\u0027, container_format\u003d\u0027bare\u0027,"},{"line_number":54,"context_line":"                                       disk_format\u003d\u0027raw\u0027)"},{"line_number":55,"context_line":"        image_id \u003d body[\u0027id\u0027]"},{"line_number":56,"context_line":"        self.assertEqual(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUEw%3D","line":53,"updated":"2013-11-11 06:23:33.000000000","message":"deleting image action will be called twice.\n1. line 57.\n2. \"cls.client.delete_image(image_id)\" will be called in \"tearDownClass(cls)\"\ndue to self.create_image() usage.\n\nMaybe we can call cls.client.create_image() here.\nOr we can see other reviewers\u0027 suggestions.","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"904f13e9376455cb8ac070122f5d869a60a3c5f1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete, deleted image"},{"line_number":52,"context_line":"        # create and delete image"},{"line_number":53,"context_line":"        resp, body \u003d self.create_image(name\u003d\u0027test\u0027, container_format\u003d\u0027bare\u0027,"},{"line_number":54,"context_line":"                                       disk_format\u003d\u0027raw\u0027)"},{"line_number":55,"context_line":"        image_id \u003d body[\u0027id\u0027]"},{"line_number":56,"context_line":"        self.assertEqual(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FQng%3D","line":53,"in_reply_to":"AAAATn%2F%2FUEw%3D","updated":"2013-11-12 05:02:02.000000000","message":"Done","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"af36640b9e3e3745757b067d1754a81875b4adf8","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete, deleted image"},{"line_number":52,"context_line":"        # create and delete image"},{"line_number":53,"context_line":"        resp, body \u003d self.create_image(name\u003d\u0027test\u0027, container_format\u003d\u0027bare\u0027,"},{"line_number":54,"context_line":"                                       disk_format\u003d\u0027raw\u0027)"},{"line_number":55,"context_line":"        image_id \u003d body[\u0027id\u0027]"},{"line_number":56,"context_line":"        self.assertEqual(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUCc%3D","line":53,"in_reply_to":"AAAATn%2F%2FUEw%3D","updated":"2013-11-11 06:33:51.000000000","message":"yangLie,, may be i should prefer your suggestion,, i\u0027ll call like self.client.create_image(),, I think it must be fine !!","commit_id":"d8710e3d93fbb239a123a0a769027374d9508ad4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ec61d3dc5fddfbfa4fc907b9d59c40d0aac0c570","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # get image with image_id \u003d NULL"},{"line_number":48,"context_line":"        image_id \u003d \"\""},{"line_number":49,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.get_image, image_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete the deleted image"},{"line_number":52,"context_line":"        # create and delete image"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FQZ8%3D","line":49,"updated":"2013-11-12 06:51:28.000000000","message":"The test of line 47 - 49 is the same as test_get_image_by_null_id() in tempest/api/image/v2/test_images.py.\n\nSo please move the method to this negative test file.","commit_id":"b7bfc69975b7349c2675bdff692e7fbad3f3d075"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"e00ff5cec7e7ee6370e140f7a972aced2a19d679","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # get image with image_id \u003d NULL"},{"line_number":48,"context_line":"        image_id \u003d \"\""},{"line_number":49,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.get_image, image_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete the deleted image"},{"line_number":52,"context_line":"        # create and delete image"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FE6k%3D","line":49,"in_reply_to":"AAAATn%2F%2FQZ8%3D","updated":"2013-11-14 18:15:41.000000000","message":"Done","commit_id":"b7bfc69975b7349c2675bdff692e7fbad3f3d075"},{"author":{"_account_id":7039,"name":"Hoisaleshwara Madan V S","email":"hoisalvs@in.ibm.com","username":"Madan"},"change_message_id":"486fe21783b51fdba4c3be8c5994032d53b000b2","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # get image with image_id \u003d NULL"},{"line_number":48,"context_line":"        image_id \u003d \"\""},{"line_number":49,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.get_image, image_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # get and delete the deleted image"},{"line_number":52,"context_line":"        # create and delete image"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FPd4%3D","line":49,"in_reply_to":"AAAATn%2F%2FQZ8%3D","updated":"2013-11-12 11:49:52.000000000","message":"Ken\u0027ichi Ohmichi, Thanx for your suggestion,, I\u0027ll make this change","commit_id":"b7bfc69975b7349c2675bdff692e7fbad3f3d075"}]}