)]}'
{"tempest/api/compute/servers/test_novnc.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d4b6b5712c4786fabbd48b043868772bd9ad0fc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":61,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        request_version \u003d api_version_request.APIVersionRequest("},{"line_number":64,"context_line":"            cls.request_microversion)"},{"line_number":65,"context_line":"        v2_6_version \u003d api_version_request.APIVersionRequest(\u00272.6\u0027)"},{"line_number":66,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":67,"context_line":"        if request_version \u003e\u003d v2_6_version:"},{"line_number":68,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_04c977aa","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":43},"updated":"2018-03-30 08:31:10.000000000","message":"ditto https://review.openstack.org/#/c/557280/2/tempest/api/compute/admin/test_quotas.py","commit_id":"dbbe8f385928b2f5f17cca09e4d79e902c1c73ed"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"545e0f69791538c034fec1a05cd89913de24c1a4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def resource_setup(cls):"},{"line_number":59,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_ad3a7531","line":61,"range":{"start_line":61,"start_character":37,"end_line":61,"end_character":42},"updated":"2018-04-27 19:17:37.000000000","message":"I think this should be True","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0a4216b20a78be71ee02094a63d777bede3abf27","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_affae9b7","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":14},"updated":"2018-07-18 01:41:04.000000000","message":"@Felipe, here is a \"not\":)","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a9381abd8ea6c12288d73ab6ebf7f10f366581b3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_84c05e7f","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":14},"in_reply_to":"5f7c97a3_68ea07a1","updated":"2018-07-26 19:03:08.000000000","message":"No lgtm","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ccfeaced0abe6f241f3add0d35b0ef61667ad615","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_68ea07a1","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":14},"in_reply_to":"5f7c97a3_6f8b7116","updated":"2018-07-24 02:55:01.000000000","message":"And any other opinion?:)","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5750e89fccf102f95a7a2575d27762d570311774","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(NoVNCConsoleTestJSON, cls).resource_setup()"},{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6f8b7116","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":14},"in_reply_to":"5f7c97a3_affae9b7","updated":"2018-07-18 01:50:30.000000000","message":"Ok makes sense now, missed this","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"545e0f69791538c034fec1a05cd89913de24c1a4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\"ACTIVE\")"},{"line_number":61,"context_line":"        cls.use_get_remote_console \u003d False"},{"line_number":62,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.5\u0027):"},{"line_number":63,"context_line":"            cls.use_get_remote_console \u003d True"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_novnc_html(self, vnc_url):"},{"line_number":66,"context_line":"        \"\"\"Verify we can connect to novnc and get back the javascript.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_4d4719be","line":63,"range":{"start_line":63,"start_character":41,"end_line":63,"end_character":45},"updated":"2018-04-27 19:17:37.000000000","message":"This False, see comments below","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"545e0f69791538c034fec1a05cd89913de24c1a4","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @decorators.idempotent_id(\u0027c640fdff-8ab4-45a4-a5d8-7e6146cbd0dc\u0027)"},{"line_number":175,"context_line":"    def test_novnc(self):"},{"line_number":176,"context_line":"        if self.use_get_remote_console:"},{"line_number":177,"context_line":"            body \u003d self.client.get_remote_console("},{"line_number":178,"context_line":"                self.server[\u0027id\u0027], console_type\u003d\u0027novnc\u0027,"},{"line_number":179,"context_line":"                protocol\u003d\u0027vnc\u0027)[\u0027remote_console\u0027]"},{"line_number":180,"context_line":"        else:"},{"line_number":181,"context_line":"            body \u003d self.client.get_vnc_console(self.server[\u0027id\u0027],"},{"line_number":182,"context_line":"                                               type\u003d\u0027novnc\u0027)[\u0027console\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_ed386d3e","line":179,"range":{"start_line":176,"start_character":8,"end_line":179,"end_character":49},"updated":"2018-04-27 19:17:37.000000000","message":"So here you\u0027re saying:\n\n   If microversion \u003c\u003d 2.5, then:\n       get_remote_console(...)\n\nBut the min_microversion for this is 2.6: https://developer.openstack.org/api-ref/compute/#create-remote-console\n\nSo I think this should be:\n\n     if microversion \u003c\u003d 2.5, then:\n         gen_vnc_console(...)\n     else:\n         get_remote_console(...)\n\nBecause is_request_microversion_compatible(\u00272.5\u0027) is this: \"Compatible means if selected request microversion is in the range(\u003c\u003d) of \u0027max_version\u0027.\"","commit_id":"c32ee7d3f0535bcf8190c115e2a76d5b741a1662"}]}