)]}'
{"tempest/api/compute/servers/test_novnc.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e485a126595f3c2fcc82691149f516538d1204bd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertTrue("},{"line_number":154,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":155,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":156,"context_line":"            \u0027Did not get the expected 101 on the websockify call: \u0027"},{"line_number":157,"context_line":"            + six.text_type(self._websocket.response))"},{"line_number":158,"context_line":"        _desired_header \u003d \"server: {0}\".format("},{"line_number":159,"context_line":"            CONF.compute_feature_enabled.nova_vnc_server_header"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_4b7c3eeb","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":59},"updated":"2018-04-02 18:08:33.000000000","message":"also this error message might be misleading with other than websockify servers","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"028eb4088adc97433341732b158f240911663aae","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertTrue("},{"line_number":154,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":155,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":156,"context_line":"            \u0027Did not get the expected 101 on the websockify call: \u0027"},{"line_number":157,"context_line":"            + six.text_type(self._websocket.response))"},{"line_number":158,"context_line":"        _desired_header \u003d \"server: {0}\".format("},{"line_number":159,"context_line":"            CONF.compute_feature_enabled.nova_vnc_server_header"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_2159e933","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":59},"in_reply_to":"bf659307_4b7c3eeb","updated":"2018-04-02 19:46:44.000000000","message":"Done","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5aa4d1289f9cac94c9533e45c61ad0a773031e14","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."},{"line_number":163,"context_line":"        _desired_header \u003d _desired_header.lower()"},{"line_number":164,"context_line":"        # It is good idea not to touch original response with lower()"},{"line_number":165,"context_line":"        _response \u003d deepcopy(self._websocket.response)"},{"line_number":166,"context_line":"        _response \u003d six.text_type(_response).lower()"},{"line_number":167,"context_line":"        self.assertTrue("},{"line_number":168,"context_line":"            _response.find(_desired_header) \u003e 0,"},{"line_number":169,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_2b378a4f","line":166,"range":{"start_line":165,"start_character":6,"end_line":166,"end_character":52},"updated":"2018-04-02 18:06:10.000000000","message":"not sure if it is really needed, both six.text_type and .lower do not change the strings in place but return new copies.","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"028eb4088adc97433341732b158f240911663aae","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."},{"line_number":163,"context_line":"        _desired_header \u003d _desired_header.lower()"},{"line_number":164,"context_line":"        # It is good idea not to touch original response with lower()"},{"line_number":165,"context_line":"        _response \u003d deepcopy(self._websocket.response)"},{"line_number":166,"context_line":"        _response \u003d six.text_type(_response).lower()"},{"line_number":167,"context_line":"        self.assertTrue("},{"line_number":168,"context_line":"            _response.find(_desired_header) \u003e 0,"},{"line_number":169,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_e13e91b6","line":166,"range":{"start_line":165,"start_character":6,"end_line":166,"end_character":52},"in_reply_to":"bf659307_2b378a4f","updated":"2018-04-02 19:46:44.000000000","message":"Done","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5aa4d1289f9cac94c9533e45c61ad0a773031e14","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # It is good idea not to touch original response with lower()"},{"line_number":165,"context_line":"        _response \u003d deepcopy(self._websocket.response)"},{"line_number":166,"context_line":"        _response \u003d six.text_type(_response).lower()"},{"line_number":167,"context_line":"        self.assertTrue("},{"line_number":168,"context_line":"            _response.find(_desired_header) \u003e 0,"},{"line_number":169,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_eb3c3230","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":23},"updated":"2018-04-02 18:06:10.000000000","message":"can be replaced by assertIn(\u003cdesired_header\u003e, \u003cresponse_header\u003e)","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"028eb4088adc97433341732b158f240911663aae","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # It is good idea not to touch original response with lower()"},{"line_number":165,"context_line":"        _response \u003d deepcopy(self._websocket.response)"},{"line_number":166,"context_line":"        _response \u003d six.text_type(_response).lower()"},{"line_number":167,"context_line":"        self.assertTrue("},{"line_number":168,"context_line":"            _response.find(_desired_header) \u003e 0,"},{"line_number":169,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_8149d560","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":23},"in_reply_to":"bf659307_eb3c3230","updated":"2018-04-02 19:46:44.000000000","message":"Done","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2f2789149484b2239d44f63eb1cc56f8c170c8fa","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":156,"context_line":"            ) + six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_5c15db3e","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":50},"updated":"2018-04-03 06:34:12.000000000","message":"use new config opt name (no nova_)","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"30a299a8136bfcb0853e3d0a2aa051ca7b2831fd","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":156,"context_line":"            ) + six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_62c35558","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":50},"in_reply_to":"bf659307_5c15db3e","updated":"2018-04-03 10:09:33.000000000","message":"Ouch, thanks.","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2f2789149484b2239d44f63eb1cc56f8c170c8fa","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":156,"context_line":"            ) + six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"},{"line_number":159,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_bc7197aa","line":156,"range":{"start_line":156,"start_character":14,"end_line":156,"end_character":54},"updated":"2018-04-03 06:34:12.000000000","message":"this now has to be a second substitution to .format:\n\n  \u0027did not get ... on the {} call: {}\u0027.format(\u003cheader\u003e, \u003cresponse\u003e)","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"30a299a8136bfcb0853e3d0a2aa051ca7b2831fd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":156,"context_line":"            ) + six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"},{"line_number":159,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_a2cded85","line":156,"range":{"start_line":156,"start_character":14,"end_line":156,"end_character":54},"in_reply_to":"bf659307_bc7197aa","updated":"2018-04-03 10:09:33.000000000","message":"Yep, my bad. Thanks.","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2f2789149484b2239d44f63eb1cc56f8c170c8fa","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"},{"line_number":159,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."},{"line_number":160,"context_line":"        _desired_header \u003d \"server: {0}\".format("},{"line_number":161,"context_line":"            CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":162,"context_line":"        ).lower()"},{"line_number":163,"context_line":"        _response \u003d six.text_type(self._websocket.response).lower()"},{"line_number":164,"context_line":"        self.assertIn("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_1c6203d9","line":161,"range":{"start_line":161,"start_character":41,"end_line":161,"end_character":46},"updated":"2018-04-03 06:34:12.000000000","message":"again, new option name","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"30a299a8136bfcb0853e3d0a2aa051ca7b2831fd","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # Since every other server type returns Headers with different case"},{"line_number":159,"context_line":"        # (for example \u0027nginx\u0027), lowercase must be applied to eliminate issues."},{"line_number":160,"context_line":"        _desired_header \u003d \"server: {0}\".format("},{"line_number":161,"context_line":"            CONF.compute_feature_enabled.nova_vnc_server_header"},{"line_number":162,"context_line":"        ).lower()"},{"line_number":163,"context_line":"        _response \u003d six.text_type(self._websocket.response).lower()"},{"line_number":164,"context_line":"        self.assertIn("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_a292cd55","line":161,"range":{"start_line":161,"start_character":41,"end_line":161,"end_character":46},"in_reply_to":"bf659307_1c6203d9","updated":"2018-04-03 10:09:33.000000000","message":"Done","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2f2789149484b2239d44f63eb1cc56f8c170c8fa","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        ).lower()"},{"line_number":163,"context_line":"        _response \u003d six.text_type(self._websocket.response).lower()"},{"line_number":164,"context_line":"        self.assertIn("},{"line_number":165,"context_line":"            _response,"},{"line_number":166,"context_line":"            _desired_header,"},{"line_number":167,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_fc894f74","line":166,"range":{"start_line":165,"start_character":10,"end_line":166,"end_character":27},"updated":"2018-04-03 06:34:12.000000000","message":"must be the other way around as we test that the server name is in the response\n\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIn","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"30a299a8136bfcb0853e3d0a2aa051ca7b2831fd","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        ).lower()"},{"line_number":163,"context_line":"        _response \u003d six.text_type(self._websocket.response).lower()"},{"line_number":164,"context_line":"        self.assertIn("},{"line_number":165,"context_line":"            _response,"},{"line_number":166,"context_line":"            _desired_header,"},{"line_number":167,"context_line":"            \u0027Did not get the expected WebSocket HTTP Response.\u0027"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_82978948","line":166,"range":{"start_line":165,"start_character":10,"end_line":166,"end_character":27},"in_reply_to":"bf659307_fc894f74","updated":"2018-04-03 10:09:33.000000000","message":"Done","commit_id":"70c183173dedc79ae3ad225572690b3eaa12f367"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"27b8e6e4b38351a3477d667ffa665b8b6a7a5616","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.assertTrue("},{"line_number":152,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.vnc_server_header,"},{"line_number":156,"context_line":"                six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_b31f64b5","line":154,"range":{"start_line":154,"start_character":57,"end_line":154,"end_character":58},"updated":"2018-04-04 08:28:51.000000000","message":"missing formatting {} here for the second argument","commit_id":"b171e88fa49f1c920984c5b4237e122ae27365bf"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"ca1c4e37dc108e3db8acde4a01598ecb7ec85645","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.assertTrue("},{"line_number":152,"context_line":"            self._websocket.response.startswith(b\u0027HTTP/1.1 101 Switching \u0027"},{"line_number":153,"context_line":"                                                b\u0027Protocols\\r\\n\u0027),"},{"line_number":154,"context_line":"            \u0027Did not get the expected 101 on the {} call: \u0027.format("},{"line_number":155,"context_line":"                CONF.compute_feature_enabled.vnc_server_header,"},{"line_number":156,"context_line":"                six.text_type(self._websocket.response)"},{"line_number":157,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_d3a4584d","line":154,"range":{"start_line":154,"start_character":57,"end_line":154,"end_character":58},"in_reply_to":"bf659307_b31f64b5","updated":"2018-04-04 08:34:16.000000000","message":"thanks! %(","commit_id":"b171e88fa49f1c920984c5b4237e122ae27365bf"}],"tempest/config.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5aa4d1289f9cac94c9533e45c61ad0a773031e14","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                default\u003dFalse,"},{"line_number":405,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027nova_vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_abd4fae9","line":407,"range":{"start_line":407,"start_character":16,"end_line":407,"end_character":21},"updated":"2018-04-02 18:06:10.000000000","message":"I\u0027d dump \u0027nova_\u0027 from this option name, it is already in the compute group","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"028eb4088adc97433341732b158f240911663aae","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                default\u003dFalse,"},{"line_number":405,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027nova_vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_41797d91","line":407,"range":{"start_line":407,"start_character":16,"end_line":407,"end_character":21},"in_reply_to":"bf659307_abd4fae9","updated":"2018-04-02 19:46:44.000000000","message":"Done","commit_id":"afeec842bece2e20b036dc5d146b7a26df254c67"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a4be7b320af532a80bac47713783273b02d5522c","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                default\u003dFalse,"},{"line_number":405,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_ccc02f2e","line":407,"updated":"2018-04-04 18:12:23.000000000","message":"This patch adds a new option to Tempest, so a new corresponding release note is necessary.","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"b87d7c41f137dfd9c55086dfb52ab6d9dd715a39","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                default\u003dFalse,"},{"line_number":405,"context_line":"                help\u003d\u0027Enable VNC console. This configuration value should \u0027"},{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_d092f24b","line":407,"in_reply_to":"bf659307_ccc02f2e","updated":"2018-04-05 09:21:57.000000000","message":"Done","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a4be7b320af532a80bac47713783273b02d5522c","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"},{"line_number":411,"context_line":"                default\u003dFalse,"},{"line_number":412,"context_line":"                help\u003d\u0027Enable Spice console. This configuration value should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_4cb5ffcc","line":409,"range":{"start_line":409,"start_character":30,"end_line":409,"end_character":45},"updated":"2018-04-04 18:12:23.000000000","message":"better to add\n\n (WebSockify, nginx, etc.)\n\nafter \"name\" for easy understanding.","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a4be7b320af532a80bac47713783273b02d5522c","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"},{"line_number":411,"context_line":"                default\u003dFalse,"},{"line_number":412,"context_line":"                help\u003d\u0027Enable Spice console. This configuration value should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_cca7cfa7","line":409,"range":{"start_line":409,"start_character":49,"end_line":409,"end_character":54},"updated":"2018-04-04 18:12:23.000000000","message":"s/resp./response/","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"b87d7c41f137dfd9c55086dfb52ab6d9dd715a39","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"},{"line_number":411,"context_line":"                default\u003dFalse,"},{"line_number":412,"context_line":"                help\u003d\u0027Enable Spice console. This configuration value should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_30a1ee96","line":409,"range":{"start_line":409,"start_character":30,"end_line":409,"end_character":45},"in_reply_to":"bf659307_4cb5ffcc","updated":"2018-04-05 09:21:57.000000000","message":"Done","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"},{"author":{"_account_id":14356,"name":"Oleksandr Savatieiev","email":"osavatieiev@mirantis.com","username":"osavatieiev"},"change_message_id":"b87d7c41f137dfd9c55086dfb52ab6d9dd715a39","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                     \u0027be same as [nova.vnc]-\u003evnc_enabled in nova.conf\u0027),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027vnc_server_header\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027WebSockify\u0027,"},{"line_number":409,"context_line":"               help\u003d\u0027Expected VNC server name in resp. header.\u0027),"},{"line_number":410,"context_line":"    cfg.BoolOpt(\u0027spice_console\u0027,"},{"line_number":411,"context_line":"                default\u003dFalse,"},{"line_number":412,"context_line":"                help\u003d\u0027Enable Spice console. This configuration value should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_f0aa966f","line":409,"range":{"start_line":409,"start_character":49,"end_line":409,"end_character":54},"in_reply_to":"bf659307_cca7cfa7","updated":"2018-04-05 09:21:57.000000000","message":"Done","commit_id":"ef165a7cc4e8c58cb280a2577b94a70786e18a7a"}]}