)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3635e5d5fb34e8ffc8dcdb2b9100c8541b880e01","unresolved":false,"context_lines":[{"line_number":10,"context_line":"OpenStack REST API services."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1764375"},{"line_number":13,"context_line":"Depends-On: I98e75ed52f754a45d0774067fd1713bee2cecb64"},{"line_number":14,"context_line":"Change-Id: I7a12203eaf3e980e8af6fa8b3869592ee3429d2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"5f7c97a3_6d9d2bba","line":13,"updated":"2018-06-18 07:00:17.000000000","message":"nit: I think we don\u0027t need to use the \"Depends-On\" directive here because it\u0027s for a \"cross-repository dependencies\". So, you just need to do like this: https://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"901d4570aa239b56641d7649dfe5fed5fdddac74"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc72cd07065747551e4b324cb6a78706afe2d62c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fix support for a HTTP proxy server to connect to"},{"line_number":10,"context_line":"OpenStack REST API services."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Forbid oslo.log to write to STDOUT when listing test cases by setting up"},{"line_number":13,"context_line":"logging library at a later time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1764375"},{"line_number":16,"context_line":"Change-Id: I7a12203eaf3e980e8af6fa8b3869592ee3429d2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":90,"id":"9fdfeff1_e79098f0","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":32},"updated":"2019-02-05 07:22:36.000000000","message":"why this fix is mixed-in in proxy fix ?","commit_id":"9be27c1905a2de5aef0feb1de245dc70dbe3f7ca"}],"releasenotes/notes/fix-proxy-url-support-9dc90cde8cf64d89.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting \u0027proxy_url\u0027"},{"line_number":10,"context_line":"    option at [service-clients] section."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_c62c5003","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":77},"updated":"2018-06-06 12:10:17.000000000","message":"nit: ``proxy_url``","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting \u0027proxy_url\u0027"},{"line_number":10,"context_line":"    option at [service-clients] section."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_a6426f0e","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":77},"in_reply_to":"5f7c97a3_c62c5003","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting \u0027proxy_url\u0027"},{"line_number":10,"context_line":"    option at [service-clients] section."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_6633fc63","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":31},"updated":"2018-06-06 12:10:17.000000000","message":"nit: ``[service-clients]``","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting \u0027proxy_url\u0027"},{"line_number":10,"context_line":"    option at [service-clients] section."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_46491b30","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":31},"in_reply_to":"5f7c97a3_6633fc63","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"86777dffe869ba8fbcbd1266ec3647168666c4f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix support for a HTTP proxy server to connect to OpenStack REST API"},{"line_number":5,"context_line":"    services so that tempest library can connect to OpenStack services passing"},{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"5f7c97a3_91a8eb21","line":4,"updated":"2018-07-24 10:30:28.000000000","message":"s/a/an ?","commit_id":"fa4393ffe38709c03f4879c61300804c27ead3b6"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"86777dffe869ba8fbcbd1266ec3647168666c4f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fix support for a HTTP proxy server to connect to OpenStack REST API"},{"line_number":5,"context_line":"    services so that tempest library can connect to OpenStack services passing"},{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting ``proxy_url``"},{"line_number":10,"context_line":"    option at ``[service-clients]`` section."}],"source_content_type":"text/x-yaml","patch_set":48,"id":"5f7c97a3_d1cf4326","line":7,"updated":"2018-07-24 10:30:28.000000000","message":"Soft nit: s/target/the target","commit_id":"fa4393ffe38709c03f4879c61300804c27ead3b6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"97dfefcaa1b97f6ad64e8aad774a6bad721ecc07","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix support for a HTTP proxy server to connect to OpenStack REST API"},{"line_number":5,"context_line":"    services so that tempest library can connect to OpenStack services passing"},{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting ``proxy_url``"}],"source_content_type":"text/x-yaml","patch_set":86,"id":"1f769fc5_d02e42f9","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":9},"updated":"2019-01-02 16:02:31.000000000","message":"through","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"25fefc90412a74794ee24964dca163d0121465b1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix support for a HTTP proxy server to connect to OpenStack REST API"},{"line_number":5,"context_line":"    services so that tempest library can connect to OpenStack services passing"},{"line_number":6,"context_line":"    throw an HTTP proxy server. This can be useful for example to run tests"},{"line_number":7,"context_line":"    on a machine that does not have IP routes configured to connect to target"},{"line_number":8,"context_line":"    cloud, but has a connection to a proxy server that has that configured."},{"line_number":9,"context_line":"    Proxy server URL can be configured in tempest.conf by setting ``proxy_url``"}],"source_content_type":"text/x-yaml","patch_set":86,"id":"ffd0ebdf_39833007","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":9},"in_reply_to":"1f769fc5_d02e42f9","updated":"2019-01-03 11:24:54.000000000","message":"Done (https://review.openstack.org/#/c/628148/)","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"}],"releasenotes/notes/forbid-logging-to-stdout-931e166709c62ab7.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"97dfefcaa1b97f6ad64e8aad774a6bad721ecc07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    When no other destination has been specified write log messages to"},{"line_number":6,"context_line":"    STDERR instead of STDOUT to avoid mixing CLI output with log messages."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":86,"id":"1f769fc5_700e4e8e","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":74},"updated":"2019-01-02 16:02:31.000000000","message":"I\u0027m not sure this is a feature, but rather a bug fix.","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"25fefc90412a74794ee24964dca163d0121465b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    When no other destination has been specified write log messages to"},{"line_number":6,"context_line":"    STDERR instead of STDOUT to avoid mixing CLI output with log messages."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":86,"id":"ffd0ebdf_798e9828","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":74},"in_reply_to":"1f769fc5_700e4e8e","updated":"2019-01-03 11:24:54.000000000","message":"Done (https://review.openstack.org/#/c/628148/)","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc72cd07065747551e4b324cb6a78706afe2d62c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    When no other destination has been specified write log messages to"},{"line_number":6,"context_line":"    STDERR instead of STDOUT to avoid mixing CLI output with log messages."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":90,"id":"9fdfeff1_476f2492","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":74},"updated":"2019-02-05 07:22:36.000000000","message":"this is listed in fixes section so we can avoid it to write it in feature section otherwise it seems duplication. reno","commit_id":"9be27c1905a2de5aef0feb1de245dc70dbe3f7ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc72cd07065747551e4b324cb6a78706afe2d62c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    STDERR instead of STDOUT to avoid mixing CLI output with log messages."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"issues:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Because tempest uses STDOUT stream to return outputs (like for example"},{"line_number":11,"context_line":"    to list test names), tempest should never write logging lines to STDOUT"},{"line_number":12,"context_line":"    stream, and use STDERR instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    When oslo.log cannot find in tempest.conf a valid destination"},{"line_number":15,"context_line":"    where to write log messages to, it decides to use sys.stdout to create"},{"line_number":16,"context_line":"    a logging stream handler with, therefore causing all logging messages"},{"line_number":17,"context_line":"    to be written to STDOUT stream instead of STDERR stream."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    You can see the oslo.log code doing it at below link:"},{"line_number":20,"context_line":"      https://github.com/openstack/oslo.log/blob/215cc3a8ec5cb61a365a98d731d08ae2f13d46d1/oslo_log/log.py#L364-L369"}],"source_content_type":"text/x-yaml","patch_set":90,"id":"9fdfeff1_a7d13032","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":60},"updated":"2019-02-05 07:22:36.000000000","message":"so this is all is fixed right? this section is for known issues left from this change.","commit_id":"9be27c1905a2de5aef0feb1de245dc70dbe3f7ca"}],"tempest/common/credentials_factory.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param identity_version: Use the specified identity API version, regardless"},{"line_number":131,"context_line":"                             of the configuration. Valid values are \u0027v2\u0027, \u0027v3\u0027."},{"line_number":132,"context_line":"    :param proxy_url: (optional) specifies an URL to an HTTP proxy server to be"},{"line_number":133,"context_line":"                      used to connect to OpenStack rest APIs"},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":"    # If a test requires a new account to work, it can have it via forcing"},{"line_number":136,"context_line":"    # dynamic credentials. A new account will be produced only for that test."}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_910a141e","line":133,"range":{"start_line":133,"start_character":51,"end_line":133,"end_character":55},"updated":"2018-06-06 12:10:17.000000000","message":"nit: REST","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param identity_version: Use the specified identity API version, regardless"},{"line_number":131,"context_line":"                             of the configuration. Valid values are \u0027v2\u0027, \u0027v3\u0027."},{"line_number":132,"context_line":"    :param proxy_url: (optional) specifies an URL to an HTTP proxy server to be"},{"line_number":133,"context_line":"                      used to connect to OpenStack rest APIs"},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":"    # If a test requires a new account to work, it can have it via forcing"},{"line_number":136,"context_line":"    # dynamic credentials. A new account will be produced only for that test."}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_863f3386","line":133,"range":{"start_line":133,"start_character":51,"end_line":133,"end_character":55},"in_reply_to":"5f7c97a3_910a141e","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"}],"tempest/lib/common/dynamic_creds.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                         admin clients. Defaults to public."},{"line_number":66,"context_line":"    :param identity_uri: Identity URI of the target cloud"},{"line_number":67,"context_line":"    :param proxy_url: (optional) specifies an URL to an HTTP proxy server to be"},{"line_number":68,"context_line":"                      used to connect to OpenStack rest APIs"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, identity_version, name\u003dNone, network_resources\u003dNone,"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_d1008c03","line":68,"range":{"start_line":68,"start_character":51,"end_line":68,"end_character":55},"updated":"2018-06-06 12:10:17.000000000","message":"nit: REST","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                         admin clients. Defaults to public."},{"line_number":66,"context_line":"    :param identity_uri: Identity URI of the target cloud"},{"line_number":67,"context_line":"    :param proxy_url: (optional) specifies an URL to an HTTP proxy server to be"},{"line_number":68,"context_line":"                      used to connect to OpenStack rest APIs"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, identity_version, name\u003dNone, network_resources\u003dNone,"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_065323e4","line":68,"range":{"start_line":68,"start_character":51,"end_line":68,"end_character":55},"in_reply_to":"5f7c97a3_d1008c03","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"}],"tempest/lib/common/http.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        or even the lowest level :meth:`urlopen`."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        IMPORTANT NOTE: parameters URL and method appears here in reversed"},{"line_number":74,"context_line":"        order respect to overridden request method. Returned value is also of"},{"line_number":75,"context_line":"        different type."},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_e605cc15","line":74,"range":{"start_line":74,"start_character":14,"end_line":74,"end_character":21},"updated":"2018-06-06 12:10:17.000000000","message":"with respect","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        or even the lowest level :meth:`urlopen`."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        IMPORTANT NOTE: parameters URL and method appears here in reversed"},{"line_number":74,"context_line":"        order respect to overridden request method. Returned value is also of"},{"line_number":75,"context_line":"        different type."},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_865893fa","line":74,"range":{"start_line":74,"start_character":14,"end_line":74,"end_character":21},"in_reply_to":"5f7c97a3_e605cc15","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"22f5397a7f9d30deae7b22c45a76262a816db8e8","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def __init__(self, info, url):"},{"line_number":114,"context_line":"        self.update((six.u(key).lower(), value)"},{"line_number":115,"context_line":"                    for key, value in six.iteritems(info.headers))"},{"line_number":116,"context_line":"        self.status \u003d info.status"},{"line_number":117,"context_line":"        self[\u0027status\u0027] \u003d str(info.status)"},{"line_number":118,"context_line":"        self.reason \u003d info.reason"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_86473878","line":115,"range":{"start_line":115,"start_character":38,"end_line":115,"end_character":51},"updated":"2018-06-06 12:10:17.000000000","message":"nit: There was discussion in the past about just doing info.headers.items() instead: http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"5be801049f5ba239e01ce7df26a20277c116f298","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def __init__(self, info, url):"},{"line_number":114,"context_line":"        self.update((six.u(key).lower(), value)"},{"line_number":115,"context_line":"                    for key, value in six.iteritems(info.headers))"},{"line_number":116,"context_line":"        self.status \u003d info.status"},{"line_number":117,"context_line":"        self[\u0027status\u0027] \u003d str(info.status)"},{"line_number":118,"context_line":"        self.reason \u003d info.reason"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_066c839a","line":115,"range":{"start_line":115,"start_character":38,"end_line":115,"end_character":51},"in_reply_to":"5f7c97a3_86473878","updated":"2018-06-06 14:44:52.000000000","message":"Done","commit_id":"ee60d97f65b6c66500ae2a44e7ced96e81ca47e4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a02454900b32f9ba865e54a04aea35e51b470d6c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        or even the lowest level :meth:`urlopen`."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        IMPORTANT NOTE: parameters URL and method appears here in reversed"},{"line_number":74,"context_line":"        order wirh respect to overridden request method. Returned value is"},{"line_number":75,"context_line":"        also of different type."},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"5f7c97a3_6bd70551","line":74,"range":{"start_line":74,"start_character":14,"end_line":74,"end_character":18},"updated":"2018-07-03 22:17:10.000000000","message":"with","commit_id":"88588c3184893de763c7a5845a670c997895c9fb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"97dfefcaa1b97f6ad64e8aad774a6bad721ecc07","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        or even the lowest level :meth:`urlopen`."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        IMPORTANT NOTE: parameters URL and method appears here in reversed"},{"line_number":75,"context_line":"        order wirh respect to overridden request method. Returned value is"},{"line_number":76,"context_line":"        also of different type."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":86,"id":"1f769fc5_b0ddc615","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":18},"updated":"2019-01-02 16:02:31.000000000","message":"with","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"25fefc90412a74794ee24964dca163d0121465b1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        or even the lowest level :meth:`urlopen`."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        IMPORTANT NOTE: parameters URL and method appears here in reversed"},{"line_number":75,"context_line":"        order wirh respect to overridden request method. Returned value is"},{"line_number":76,"context_line":"        also of different type."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":86,"id":"ffd0ebdf_39981069","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":18},"in_reply_to":"1f769fc5_b0ddc615","updated":"2019-01-03 11:24:54.000000000","message":"Done (https://review.openstack.org/#/c/628148/)","commit_id":"fcb039866912d99974519dacdd3b8fb1b249fc49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc72cd07065747551e4b324cb6a78706afe2d62c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.follow_redirects \u003d follow_redirects"},{"line_number":60,"context_line":"        super(ClosingHttp, self).__init__(**params)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def request(self, url, method, headers\u003dNone, **params):"},{"line_number":63,"context_line":"        \"\"\"Make an HTTP request using :meth:`urlopen`"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        Make a request using :meth:`urlopen` with the appropriate encoding of"}],"source_content_type":"text/x-python","patch_set":90,"id":"9fdfeff1_a7b610dc","line":62,"range":{"start_line":62,"start_character":35,"end_line":62,"end_character":59},"updated":"2019-02-05 07:22:36.000000000","message":"why we are changing the signature of this function? Old one should work as it is.\n\nThis removes the *args and so backward incompatible changes.","commit_id":"9be27c1905a2de5aef0feb1de245dc70dbe3f7ca"}]}