)]}'
{"tempest/api/object_storage/test_object_formpost.py":[{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"c8933c449a0fa4e2ae1160c0c3837a3ee1bb7480","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# Copyright (C) 2013 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Christian Schwede \u003cchristian.schwede@enovance.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FCQY%3D","line":4,"updated":"2013-11-15 11:18:03.000000000","message":"Is it OK to describe a specific company name in OpenStack source codes?","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"6c581de789e5f29b4bfe92ade3bc53c52cd098e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# Copyright (C) 2013 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Christian Schwede \u003cchristian.schwede@enovance.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B1q4%3D","line":4,"in_reply_to":"AAAATn%2F%2FCQY%3D","updated":"2013-11-19 14:28:51.000000000","message":"Yes, as long as it\u0027s under the Apache 2.0 License.","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"496eae4525196e5072e0b9c46101a6adafbd61d9","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        boundary \u003d \u0027--boundary--\u0027"},{"line_number":76,"context_line":"        data \u003d []"},{"line_number":77,"context_line":"        for (key, value) in fields.items():"},{"line_number":78,"context_line":"            data.append(\u0027--\u0027 + boundary)"},{"line_number":79,"context_line":"            data.append(\u0027Content-Disposition: form-data; name\u003d\"%s\"\u0027 % key)"},{"line_number":80,"context_line":"            data.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B2v4%3D","line":77,"updated":"2013-11-19 10:24:08.000000000","message":"Minor nitpick: \n\nIt would be better to iterate over the items using the method `iteritems()` instead of `items()`","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"6c581de789e5f29b4bfe92ade3bc53c52cd098e0","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        boundary \u003d \u0027--boundary--\u0027"},{"line_number":76,"context_line":"        data \u003d []"},{"line_number":77,"context_line":"        for (key, value) in fields.items():"},{"line_number":78,"context_line":"            data.append(\u0027--\u0027 + boundary)"},{"line_number":79,"context_line":"            data.append(\u0027Content-Disposition: form-data; name\u003d\"%s\"\u0027 % key)"},{"line_number":80,"context_line":"            data.append(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B2sQ%3D","line":77,"in_reply_to":"AAAATn%2F%2B2v4%3D","updated":"2013-11-19 14:28:51.000000000","message":"iteritems() is no longer supported in Python 3, thus it would break compability.","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"496eae4525196e5072e0b9c46101a6adafbd61d9","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @attr(type\u003d[\u0027gate\u0027, \u0027negative\u0027])"},{"line_number":120,"context_line":"    def test_post_object_using_form_expired(self):"},{"line_number":121,"context_line":"        body, content_type \u003d self.get_multipart_form(expires\u003d0)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        headers \u003d {\u0027Content-Type\u0027: content_type,"},{"line_number":124,"context_line":"                   \u0027Content-Length\u0027: str(len(body))}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B2uE%3D","line":121,"updated":"2013-11-19 10:24:08.000000000","message":"I think it would be more pertinent to create a form that expires in, say, 1 sec, sleep for a second or two, then validate that the form has expired.","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"6c581de789e5f29b4bfe92ade3bc53c52cd098e0","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @attr(type\u003d[\u0027gate\u0027, \u0027negative\u0027])"},{"line_number":120,"context_line":"    def test_post_object_using_form_expired(self):"},{"line_number":121,"context_line":"        body, content_type \u003d self.get_multipart_form(expires\u003d0)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        headers \u003d {\u0027Content-Type\u0027: content_type,"},{"line_number":124,"context_line":"                   \u0027Content-Length\u0027: str(len(body))}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B1qc%3D","line":121,"in_reply_to":"AAAATn%2F%2B2uE%3D","updated":"2013-11-19 14:28:51.000000000","message":"Agreed, will update this.","commit_id":"acab8d04cdb755289480c33c8ff7b45213b985ba"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"6190b910d4700c5b9e1c7e8ab96b2b4426dfcd12","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.api.object_storage import base"},{"line_number":24,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":25,"context_line":"from tempest.test import attr"},{"line_number":26,"context_line":"from tempest.test import HTTP_SUCCESS"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Bm9Y%3D","line":24,"updated":"2013-11-22 14:52:21.000000000","message":"I think you should change importing here.\nFor more info:\nhttps://review.openstack.org/#/c/54688/\nPlease follow this patch.","commit_id":"46f15b06e57295dc3a9e9790d8b66bc9b4db815d"}]}
