)]}'
{"tempest/api/compute/admin/test_flavors.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4129b69df0385a4c2154eb085a085003ed2e3a6d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.assertEqual(flavor[\u0027name\u0027], flavor_name)"},{"line_number":75,"context_line":"        self.assertEqual(flavor[\u0027vcpus\u0027], self.vcpus)"},{"line_number":76,"context_line":"        self.assertEqual(flavor[\u0027disk\u0027], self.disk)"},{"line_number":77,"context_line":"        self.assertEqual(flavor[\u0027ram\u0027], self.ram)"},{"line_number":78,"context_line":"        self.assertEqual(flavor[\u0027swap\u0027], self.swap)"},{"line_number":79,"context_line":"        self.assertEqual(flavor[\u0027rxtx_factor\u0027], self.rxtx)"},{"line_number":80,"context_line":"        self.assertEqual(flavor[\u0027OS-FLV-EXT-DATA:ephemeral\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B6U8%3D","line":77,"updated":"2013-11-18 17:06:01.000000000","message":"I think we should assert the flavor[\u0027id\u0027] here. Because below both test cases specify the flavor_id.\nOr you should pass the \u0027auto\u0027 to this method.","commit_id":"3e5bd624841d047a40a7c0c15045a6758198cdd6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c1bdfcdc61038a25c821b04671b58c6b1fd46068","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.assertEqual(flavor[\u0027name\u0027], flavor_name)"},{"line_number":75,"context_line":"        self.assertEqual(flavor[\u0027vcpus\u0027], self.vcpus)"},{"line_number":76,"context_line":"        self.assertEqual(flavor[\u0027disk\u0027], self.disk)"},{"line_number":77,"context_line":"        self.assertEqual(flavor[\u0027ram\u0027], self.ram)"},{"line_number":78,"context_line":"        self.assertEqual(flavor[\u0027swap\u0027], self.swap)"},{"line_number":79,"context_line":"        self.assertEqual(flavor[\u0027rxtx_factor\u0027], self.rxtx)"},{"line_number":80,"context_line":"        self.assertEqual(flavor[\u0027OS-FLV-EXT-DATA:ephemeral\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B34Q%3D","line":77,"in_reply_to":"AAAATn%2F%2B6U8%3D","updated":"2013-11-19 04:46:36.000000000","message":"you are right, we\u0027d better to add \u0027auto\u0027 test case.","commit_id":"3e5bd624841d047a40a7c0c15045a6758198cdd6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4129b69df0385a4c2154eb085a085003ed2e3a6d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":98,"context_line":"    def test_create_flavor_with_uuid_id(self):"},{"line_number":99,"context_line":"        flavor_id \u003d str(uuid.uuid4())"},{"line_number":100,"context_line":"        new_flavor_id \u003d self._create_flavor(flavor_id)"},{"line_number":101,"context_line":"        self.assertEqual(new_flavor_id, flavor_id)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B6WQ%3D","line":99,"updated":"2013-11-18 17:06:01.000000000","message":"We can use data_utils.rand_uuid() now.","commit_id":"3e5bd624841d047a40a7c0c15045a6758198cdd6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97eebb633e64e9564f25a74036aa9943b320ba96","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":98,"context_line":"    def test_create_flavor_with_uuid_id(self):"},{"line_number":99,"context_line":"        flavor_id \u003d str(uuid.uuid4())"},{"line_number":100,"context_line":"        new_flavor_id \u003d self._create_flavor(flavor_id)"},{"line_number":101,"context_line":"        self.assertEqual(new_flavor_id, flavor_id)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B34A%3D","line":99,"in_reply_to":"AAAATn%2F%2B34c%3D","updated":"2013-11-19 04:52:12.000000000","message":"Sorry, I noticed that work will be duplicated with your work(Ibda1a5e424280bad8535ee27f66dec99bf68f676).\nThis should be done after your patch.","commit_id":"3e5bd624841d047a40a7c0c15045a6758198cdd6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c1bdfcdc61038a25c821b04671b58c6b1fd46068","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":98,"context_line":"    def test_create_flavor_with_uuid_id(self):"},{"line_number":99,"context_line":"        flavor_id \u003d str(uuid.uuid4())"},{"line_number":100,"context_line":"        new_flavor_id \u003d self._create_flavor(flavor_id)"},{"line_number":101,"context_line":"        self.assertEqual(new_flavor_id, flavor_id)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B34c%3D","line":99,"in_reply_to":"AAAATn%2F%2B6WQ%3D","updated":"2013-11-19 04:46:36.000000000","message":"I see, will use it.","commit_id":"3e5bd624841d047a40a7c0c15045a6758198cdd6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6ac492dde121aed05562d271f315e15b7dd0f572","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # If nova receives a request with None as flavor_id,"},{"line_number":106,"context_line":"        # nova generates flavor_id of uuid."},{"line_number":107,"context_line":"        flavor_id \u003d None"},{"line_number":108,"context_line":"        self._create_flavor(flavor_id)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":111,"context_line":"    def test_create_flavor_verify_entry_in_list_details(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2B22g%3D","line":108,"updated":"2013-11-19 10:01:42.000000000","message":"How about assert the type of UUID here?","commit_id":"dd749f84446c52ee0f900bb6ec5a35bc67b4f119"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"81a40126a7f8215a3c33dfb8a3069f41cb53afc0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # If nova receives a request with None as flavor_id,"},{"line_number":106,"context_line":"        # nova generates flavor_id of uuid."},{"line_number":107,"context_line":"        flavor_id \u003d None"},{"line_number":108,"context_line":"        self._create_flavor(flavor_id)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":111,"context_line":"    def test_create_flavor_verify_entry_in_list_details(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2B2yE%3D","line":108,"in_reply_to":"AAAATn%2F%2B22g%3D","updated":"2013-11-19 10:10:18.000000000","message":"Thanks, good idea.","commit_id":"dd749f84446c52ee0f900bb6ec5a35bc67b4f119"}]}