)]}'
{"tempest/api/compute/v3/servers/test_attach_volume.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ba2c7f38c209e66d558c65d2e1e84f88338ad2a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.api.compute import base"},{"line_number":19,"context_line":"from tempest.common.utils.linux.remote_client import RemoteClient"},{"line_number":20,"context_line":"from tempest import config"},{"line_number":21,"context_line":"from tempest import test"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2F5Qo%3D","line":21,"updated":"2014-02-24 08:17:44.000000000","message":"Please do not mix the patch purpose. The patch scope would be unclear.\n\nThe other developers are trying to fix this kind of import code and the this patch does not change v2 part.","commit_id":"8b06c31f52bb6b10ef9cd204d59fdf1d1f9f3829"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ba2c7f38c209e66d558c65d2e1e84f88338ad2a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        attached_volume_id \u003d server[expected_key][0][\u0027id\u0027]"},{"line_number":126,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":127,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":128,"context_line":"                         attached_volume_id)"},{"line_number":129,"context_line":"        params \u003d {\u0027name\u0027: server[\u0027name\u0027]}"},{"line_number":130,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":131,"context_line":"        attached_volume_id \u003d body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2F5RU%3D","line":128,"updated":"2014-02-24 08:17:44.000000000","message":"possible to merge line127-128 to one line.","commit_id":"8b06c31f52bb6b10ef9cd204d59fdf1d1f9f3829"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ba2c7f38c209e66d558c65d2e1e84f88338ad2a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        attached_volume_id \u003d body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027]"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":133,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":134,"context_line":"                         attached_volume_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2F5RQ%3D","line":134,"updated":"2014-02-24 08:17:44.000000000","message":"ditto","commit_id":"8b06c31f52bb6b10ef9cd204d59fdf1d1f9f3829"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"38b3fd6526323b81f5f96fdf580dd7a4bb727260","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        resp, server \u003d self.servers_client.get_server(server[\u0027id\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":124,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":125,"context_line":"                         server[expected_key][0][\u0027id\u0027])"},{"line_number":126,"context_line":"        params \u003d {\u0027name\u0027: server[\u0027name\u0027]}"},{"line_number":127,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":128,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Ba9Y%3D","line":125,"updated":"2013-11-26 09:56:04.000000000","message":"suggest using a readable variable to replace server[expected_key][0][\u0027id\u0027]","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"e65845b98aea050d45523e2c6566de16770bdb14","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        resp, server \u003d self.servers_client.get_server(server[\u0027id\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":124,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":125,"context_line":"                         server[expected_key][0][\u0027id\u0027])"},{"line_number":126,"context_line":"        params \u003d {\u0027name\u0027: server[\u0027name\u0027]}"},{"line_number":127,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":128,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BawA%3D","line":125,"in_reply_to":"AAAATn%2F%2Ba9Y%3D","updated":"2013-11-26 10:27:36.000000000","message":"done","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"38b3fd6526323b81f5f96fdf580dd7a4bb727260","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":128,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":129,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":130,"context_line":"                         body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class AttachVolumeTestXML(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Ba9U%3D","line":130,"updated":"2013-11-26 09:56:04.000000000","message":"suggest using a readable variable to replace body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027]","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"e65845b98aea050d45523e2c6566de16770bdb14","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":128,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":129,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":130,"context_line":"                         body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class AttachVolumeTestXML(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bav4%3D","line":130,"in_reply_to":"AAAATn%2F%2Ba9U%3D","updated":"2013-11-26 10:27:36.000000000","message":"done","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ba2c7f38c209e66d558c65d2e1e84f88338ad2a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        attached_volume_id \u003d server[expected_key][0][\u0027id\u0027]"},{"line_number":124,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":125,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":126,"context_line":"                         attached_volume_id)"},{"line_number":127,"context_line":"        params \u003d {\u0027name\u0027: server[\u0027name\u0027]}"},{"line_number":128,"context_line":"        resp, body \u003d self.servers_client.list_servers_with_detail(params)"},{"line_number":129,"context_line":"        attached_volume_id \u003d body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2F5QU%3D","line":126,"updated":"2014-02-24 08:17:44.000000000","message":"ditto","commit_id":"8b06c31f52bb6b10ef9cd204d59fdf1d1f9f3829"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ba2c7f38c209e66d558c65d2e1e84f88338ad2a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        attached_volume_id \u003d body[\u0027servers\u0027][0][expected_key][0][\u0027id\u0027]"},{"line_number":130,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":131,"context_line":"        self.assertEqual(volume[\u0027id\u0027],"},{"line_number":132,"context_line":"                         attached_volume_id)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"class AttachVolumeTestXML(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2F5QQ%3D","line":132,"updated":"2014-02-24 08:17:44.000000000","message":"ditto","commit_id":"8b06c31f52bb6b10ef9cd204d59fdf1d1f9f3829"}],"tempest/services/compute/xml/common.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"38b3fd6526323b81f5f96fdf580dd7a4bb727260","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            else:"},{"line_number":122,"context_line":"                json[tag] \u003d [xml_to_json(child)]"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            json[tag] \u003d xml_to_json(child)"},{"line_number":125,"context_line":"    return json"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Ba%2Bk%3D","line":124,"updated":"2013-11-26 09:56:04.000000000","message":"The additional parameter could be removed, so we don\u0027t need maintain the attr_expected_list.\n\nif tag in json:\n    if isinstance(json[tag], list):\n         json[tag].append(xml_to_json(child))\n    else:\n         json[tag] \u003d [json[tag], xml_to_json(child)]\nelse:\n    json[tag] \u003d xml_to_json(child)","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"e65845b98aea050d45523e2c6566de16770bdb14","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            else:"},{"line_number":122,"context_line":"                json[tag] \u003d [xml_to_json(child)]"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            json[tag] \u003d xml_to_json(child)"},{"line_number":125,"context_line":"    return json"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bawg%3D","line":124,"in_reply_to":"AAAATn%2F%2Ba%2Bk%3D","updated":"2013-11-26 10:27:36.000000000","message":"no, it won\u0027t work. If there is only one element for this tag that should be list, it will also be converted to dict. thanks for your review.","commit_id":"c2495bbbed5355c65c844101d3e891d1477a85da"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7f932446c64d7b7e99a5ffeede90c1ebaf66d352","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                json[tag] \u003d [xml_to_json(child)]"},{"line_number":134,"context_line":"            return json"},{"line_number":135,"context_line":"        json[tag] \u003d xml_to_json(child)"},{"line_number":136,"context_line":"    return json"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2B9i0%3D","line":135,"updated":"2014-01-20 11:30:23.000000000","message":"Why were plurals removed?","commit_id":"e145b6651a25f51649882b1b2b398ea90fff4f41"}]}