)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eb069146dd335198b76804da786331e059951955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d7d5b08_92707820","updated":"2021-11-30 00:49:27.000000000","message":"\u003e Patch Set 5:\n\u003e \n\u003e is this still relevant? If so let\u0027s rebase and review\n\nI will check it tomorrow. ","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"}],"tempest/api/compute/servers/test_servers_negative.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfd7d84a3c4301a1091e51a24a08ce5d0154f600","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        volume \u003d self.create_volume()"},{"line_number":276,"context_line":"        bdm \u003d {\u0027uuid\u0027: volume[\u0027id\u0027],"},{"line_number":277,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":278,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":279,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":280,"context_line":"                          self.create_test_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_e210d350","line":277,"range":{"start_line":275,"start_character":0,"end_line":277,"end_character":39},"updated":"2018-04-24 12:50:31.000000000","message":"This test would be faster if you used the imageRef uuid and used source_type\u003d\u0027image\u0027.","commit_id":"9c09cbbb4b3ee6d9712864a1ca660b9a983f3fde"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1514bc365f9b0b66e079f88ed2224adad37547d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        volume \u003d self.create_volume()"},{"line_number":276,"context_line":"        bdm \u003d {\u0027uuid\u0027: volume[\u0027id\u0027],"},{"line_number":277,"context_line":"               \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":278,"context_line":"               \u0027destination_type\u0027: \u0027volume\u0027}"},{"line_number":279,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":280,"context_line":"                          self.create_test_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_63f7db5a","line":277,"range":{"start_line":275,"start_character":0,"end_line":277,"end_character":39},"in_reply_to":"9f6a8fd7_e210d350","updated":"2018-04-24 23:33:05.000000000","message":"yea, we have built image id. will do","commit_id":"9c09cbbb4b3ee6d9712864a1ca660b9a983f3fde"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"15449eed721ba12d004363b209354164a23dbdd9","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":271,"context_line":"    @decorators.idempotent_id(\u0027bdf40926-aa9a-4cb8-8922-f3bc1b8650b2\u0027)"},{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        bdm \u003d {\"source_type\": \"image\","},{"line_number":276,"context_line":"               \"uuid\": self.image_ref}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_318f5324","line":273,"range":{"start_line":273,"start_character":20,"end_line":273,"end_character":28},"updated":"2018-08-21 21:36:21.000000000","message":"Does this depend on the image service as well?","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbb0eacfb31101b0ebd924e125165edb84a8cd5b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        bdm \u003d {\"source_type\": \"image\","},{"line_number":276,"context_line":"               \"uuid\": self.image_ref}"},{"line_number":277,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":278,"context_line":"                          self.create_test_server,"},{"line_number":279,"context_line":"                          image_id\u003dself.image_ref,"},{"line_number":280,"context_line":"                          block_device_mapping_v2\u003d[bdm])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_dacd4187","line":277,"range":{"start_line":275,"start_character":8,"end_line":277,"end_character":45},"updated":"2018-04-26 11:13:18.000000000","message":"You might be getting this for a different bug. Do you want to assert something in the error response message? I was expecting to see destination_type\u003d\u0027volume\u0027 in here which is why I\u0027m kind of surprised this isn\u0027t failing on that, unless nova defaults destination_type to \u0027volume\u0027 somewhere.","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"91179619ecba9bfc92e6b61315bb9087927194af","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        bdm \u003d {\"source_type\": \"image\","},{"line_number":276,"context_line":"               \"uuid\": self.image_ref}"},{"line_number":277,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":278,"context_line":"                          self.create_test_server,"},{"line_number":279,"context_line":"                          image_id\u003dself.image_ref,"},{"line_number":280,"context_line":"                          block_device_mapping_v2\u003d[bdm])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_bd688787","line":277,"range":{"start_line":275,"start_character":8,"end_line":277,"end_character":45},"in_reply_to":"9f6a8fd7_9a9ca96b","updated":"2018-04-26 11:58:41.000000000","message":"yea, in PS2, i mistakenly left destination_type to local and it failed as invalid destination_type then left it not passing as it is optional.","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"15449eed721ba12d004363b209354164a23dbdd9","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        bdm \u003d {\"source_type\": \"image\","},{"line_number":276,"context_line":"               \"uuid\": self.image_ref}"},{"line_number":277,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":278,"context_line":"                          self.create_test_server,"},{"line_number":279,"context_line":"                          image_id\u003dself.image_ref,"},{"line_number":280,"context_line":"                          block_device_mapping_v2\u003d[bdm])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f1aa3b83","line":277,"range":{"start_line":275,"start_character":8,"end_line":277,"end_character":45},"in_reply_to":"9f6a8fd7_bd688787","updated":"2018-08-21 21:36:21.000000000","message":"I think that this documentation conflicts with the desire to add this test: https://docs.openstack.org/tempest/latest/HACKING.html#negative-tests\n\nIt\u0027s clear from the test above (L262) that many BadRequest tests exist for POST /servers. While I wouldn\u0027t expect those guidelines to apply for every endpoint, it does get in the way of approving this change.","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a0508b6022ea382e26c263b68abe0ddbc6973435","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @decorators.related_bug(\u00271766306\u0027, status_code\u003d400)"},{"line_number":273,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":274,"context_line":"    def test_create_server_without_boot_index_in_bdm(self):"},{"line_number":275,"context_line":"        bdm \u003d {\"source_type\": \"image\","},{"line_number":276,"context_line":"               \"uuid\": self.image_ref}"},{"line_number":277,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":278,"context_line":"                          self.create_test_server,"},{"line_number":279,"context_line":"                          image_id\u003dself.image_ref,"},{"line_number":280,"context_line":"                          block_device_mapping_v2\u003d[bdm])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_9a9ca96b","line":277,"range":{"start_line":275,"start_character":8,"end_line":277,"end_character":45},"in_reply_to":"9f6a8fd7_dacd4187","updated":"2018-04-26 11:14:53.000000000","message":"I guess destination_type is marked optional:\n\nhttps://developer.openstack.org/api-ref/compute/#create-server","commit_id":"420b47c5cf62db4d588046020f1b357c4d2fd228"}]}