)]}'
{"tempest/common/waiters.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"be90da3ddc24a192b3fa4fb26cff8944111ef0d4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":202,"context_line":"            raise exceptions.VolumeResourceBuildErrorException("},{"line_number":203,"context_line":"                resource_name\u003dresource_name, resource_id\u003dresource_id)"},{"line_number":204,"context_line":"        if failure_status:"},{"line_number":205,"context_line":"            if resource_status in failure_status:"},{"line_number":206,"context_line":"                raise exceptions.VolumeResourceBuildException("},{"line_number":207,"context_line":"                    resource_name\u003dresource_name, resource_id\u003dresource_id,"},{"line_number":208,"context_line":"                    status\u003dresource_status)"},{"line_number":209,"context_line":"        if resource_name \u003d\u003d \u0027volume\u0027 and resource_status \u003d\u003d \u0027error_restoring\u0027:"},{"line_number":210,"context_line":"            raise exceptions.VolumeRestoreErrorException(volume_id\u003dresource_id)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_b397ef90","line":208,"range":{"start_line":204,"start_character":0,"end_line":208,"end_character":43},"updated":"2018-05-02 14:34:07.000000000","message":"I think it\u0027s a better way:\n\nif resource_name \u003d\u003d \u0027volume\u0027:\n    if resource_status \u003d\u003d \u0027error_restoring\u0027:\n        raise exceptions.VolumeRestoreErrorException(volume_id\u003dresource_id)\n    if resource_status \u003d\u003d \u0027error_extending\u0027:\n        raise exceptions.VolumeResourceBuildException(\n                    resource_name\u003dresource_name, resource_id\u003dresource_id,\n                    status\u003dresource_status)","commit_id":"7f36117299c9d361d1cb3629fddcc14246dbdf46"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"b8602d84a82a2fa017d074b9610365f4c119271f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":202,"context_line":"            raise exceptions.VolumeResourceBuildErrorException("},{"line_number":203,"context_line":"                resource_name\u003dresource_name, resource_id\u003dresource_id)"},{"line_number":204,"context_line":"        if failure_status:"},{"line_number":205,"context_line":"            if resource_status in failure_status:"},{"line_number":206,"context_line":"                raise exceptions.VolumeResourceBuildException("},{"line_number":207,"context_line":"                    resource_name\u003dresource_name, resource_id\u003dresource_id,"},{"line_number":208,"context_line":"                    status\u003dresource_status)"},{"line_number":209,"context_line":"        if resource_name \u003d\u003d \u0027volume\u0027 and resource_status \u003d\u003d \u0027error_restoring\u0027:"},{"line_number":210,"context_line":"            raise exceptions.VolumeRestoreErrorException(volume_id\u003dresource_id)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b4d7874b","line":208,"range":{"start_line":204,"start_character":8,"end_line":208,"end_character":42},"updated":"2018-05-30 08:46:18.000000000","message":"I think we don\u0027t have need to pass \"failure_status\" from \"test_volume_extend_when_volume_has_snapshot\" but we can add if condition in \"wait_for_volume_resource_status\" for any kind of error for raising the exception.","commit_id":"7f36117299c9d361d1cb3629fddcc14246dbdf46"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3b94d1413b56f54d68610d851d4324374d8c74dc","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if resource_status \u003d\u003d \u0027error\u0027 and resource_status !\u003d status:"},{"line_number":202,"context_line":"            raise exceptions.VolumeResourceBuildErrorException("},{"line_number":203,"context_line":"                resource_name\u003dresource_name, resource_id\u003dresource_id)"},{"line_number":204,"context_line":"        if failure_status:"},{"line_number":205,"context_line":"            if resource_status in failure_status:"},{"line_number":206,"context_line":"                raise exceptions.VolumeResourceBuildException("},{"line_number":207,"context_line":"                    resource_name\u003dresource_name, resource_id\u003dresource_id,"},{"line_number":208,"context_line":"                    status\u003dresource_status)"},{"line_number":209,"context_line":"        if resource_name \u003d\u003d \u0027volume\u0027 and resource_status \u003d\u003d \u0027error_restoring\u0027:"},{"line_number":210,"context_line":"            raise exceptions.VolumeRestoreErrorException(volume_id\u003dresource_id)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_01eb9277","line":208,"range":{"start_line":204,"start_character":8,"end_line":208,"end_character":42},"in_reply_to":"5f7c97a3_b4d7874b","updated":"2018-05-30 16:11:51.000000000","message":"The benefit of passing in failure_status is that this method won\u0027t have to account for all of the assorted different statuses that are relevant for different tests.","commit_id":"7f36117299c9d361d1cb3629fddcc14246dbdf46"}]}