)]}'
{"tempest/api/compute/servers/test_multiple_create.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"726fea92ab46370771a305cf2029bcb30c74ccbb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.assertNotIn(\u0027reservation_id\u0027, body)"},{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f0d65027","line":42,"range":{"start_line":42,"start_character":42,"end_line":42,"end_character":47},"updated":"2018-06-13 06:52:19.000000000","message":"-1, -2 etc index is not clear here.","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"307d3bf795ba7a825d6adead519ddaeeaf8dcc3c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"},{"line_number":46,"context_line":"    def test_multiple_create_with_reservation_return(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7f7c0320","line":43,"updated":"2018-05-18 02:47:18.000000000","message":"This is not necessarily true as the template for defining this is determined by the value of `multi_instance_display_name_template` according to docs (also the Nova docs misspell \"template\" as \"templete\" as an aside). \n\nShould we add a CONF option for `multi_instance_display_name_template` to Tempest?","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5890a6700fbcd2e25982abf6b33549a8ba3d5be5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"},{"line_number":46,"context_line":"    def test_multiple_create_with_reservation_return(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_72294c99","line":43,"in_reply_to":"5f7c97a3_2744021b","updated":"2018-05-23 21:47:18.000000000","message":"i agree it was on api-ref side but that was more just reflecting the code there and after your nova patch it is more just extra info on names nova generate than contract. \n- https://review.openstack.org/#/c/569462/2","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cf514b18be770b82a2b8ba824e6eea98f1096bf5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"},{"line_number":46,"context_line":"    def test_multiple_create_with_reservation_return(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ac821cc7","line":43,"in_reply_to":"5f7c97a3_72294c99","updated":"2018-05-24 15:28:43.000000000","message":"Sorry, I cannot follow your point.\n\nhttps://developer.openstack.org/api-ref/compute/#create-multiple-servers says\n\n A base name for creating unique names during multiple create.\n A unique string will be appended to the end of this base name\n for every server created. The server names become {name}-1,\n {name}-2, {name}-3, etc.\n\nAt the above part, {name} means the request parameter \u0027name\u0027 because the above part is written on the parameter part. This test specifies \u0027VM\u0027 as a name, then the additional check verifies \u0027VM-1\u0027 and \u0027VM-2\u0027 based on the above description.\nFor me, this additional check is completely matching to the above part of official API document. I am not sure what is the problem of this patch and why we don\u0027t need to block the backwards incompatibility check related to this document.","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"98a5478f2895a6e4f2f39b51d2bbc955efac4711","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"},{"line_number":46,"context_line":"    def test_multiple_create_with_reservation_return(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8637384e","line":43,"in_reply_to":"5f7c97a3_7f7c0320","updated":"2018-05-20 23:11:47.000000000","message":"I am not sure if server name template or pattern is API contract and we should tests those value strictly in tempest.","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"152e5f74f50f287870d7f0a8343c43861c7188c5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(2, len(servers))"},{"line_number":41,"context_line":"        # NOTE: If specifying a server name on the request API,"},{"line_number":42,"context_line":"        # server names should be \"(name)-(index)\" on Nova API side."},{"line_number":43,"context_line":"        self.assertEqual(set([\u0027VM-1\u0027, \u0027VM-2\u0027]), server_names)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027864777fb-2f1e-44e3-b5b9-3eb6fa84f2f7\u0027)"},{"line_number":46,"context_line":"    def test_multiple_create_with_reservation_return(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2744021b","line":43,"in_reply_to":"5f7c97a3_8637384e","updated":"2018-05-22 21:19:42.000000000","message":"This behavior is written on the compute API document officially. So we can say that is the API contract and need to test the behavior, I think.","commit_id":"b59f458f2823bfcfd8a530003d34e912110c2f3a"}]}