)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7edd7f0868c693fa15e57c71187fdfb4d5665a49","unresolved":false,"context_lines":[{"line_number":10,"context_line":"source volume or snapshot will be changed to \u0027backing-up\u0027, and will be"},{"line_number":11,"context_line":"changed to volume or snapshot\u0027s original status after the backup"},{"line_number":12,"context_line":"creation finished. So it is necessary to add status check for the source"},{"line_number":13,"context_line":"volume or snapshot to make the tests more robust."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0add3989e1184012b908c5fab459cda41194dec3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_ac4d0173","line":13,"updated":"2018-05-30 02:51:54.000000000","message":"API documentation seems to support this behavior by skimming through different sections, but is there a place where this is explained more carefully?","commit_id":"0aa6badd10f32fb5acc3b984a2d26096b1aa93e5"}],"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7edd7f0868c693fa15e57c71187fdfb4d5665a49","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertIn(new_id, [b[\u0027id\u0027] for b in backups])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Restore backup"},{"line_number":106,"context_line":"        restore \u003d self.admin_backups_client.restore_backup("},{"line_number":107,"context_line":"            backup[\u0027id\u0027])[\u0027restore\u0027]"},{"line_number":108,"context_line":"        self.addCleanup(self.admin_volume_client.delete_volume,"},{"line_number":109,"context_line":"                        restore[\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_1153f23a","side":"PARENT","line":106,"updated":"2018-05-30 02:51:54.000000000","message":"These changes to use os_primary creds instead of os_admin creds is unrelated and should be done in a separate patchset.","commit_id":"0a83c71252897e214eb58cec2c00a6b1f2905e99"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"655ff8b3ddb0f398cddf98782ca47ca9ce60d4f1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertIn(new_id, [b[\u0027id\u0027] for b in backups])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Restore backup"},{"line_number":106,"context_line":"        restore \u003d self.admin_backups_client.restore_backup("},{"line_number":107,"context_line":"            backup[\u0027id\u0027])[\u0027restore\u0027]"},{"line_number":108,"context_line":"        self.addCleanup(self.admin_volume_client.delete_volume,"},{"line_number":109,"context_line":"                        restore[\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_76b80e10","side":"PARENT","line":106,"in_reply_to":"5f7c97a3_1153f23a","updated":"2018-05-30 15:03:45.000000000","message":"Thanks, Felipe.\n\nThe changes have been divided into two patchset:\n1. https://review.openstack.org/#/c/571213/\n2. https://review.openstack.org/#/c/571217/","commit_id":"0a83c71252897e214eb58cec2c00a6b1f2905e99"}],"tempest/api/volume/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7edd7f0868c693fa15e57c71187fdfb4d5665a49","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":153,"context_line":"        return snapshot"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def create_backup(self, volume_id, backup_client\u003dNone, **kwargs):"},{"line_number":156,"context_line":"        \"\"\"Wrapper utility that returns a test backup.\"\"\""},{"line_number":157,"context_line":"        if backup_client is None:"},{"line_number":158,"context_line":"            backup_client \u003d self.backups_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_7110265a","side":"PARENT","line":155,"updated":"2018-05-30 02:51:54.000000000","message":"Why modify the interface here? I checked other plugins and this doesn\u0027t seem to break anyone but i haven\u0027t done an exhaustive search.","commit_id":"0a83c71252897e214eb58cec2c00a6b1f2905e99"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7edd7f0868c693fa15e57c71187fdfb4d5665a49","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                    description\u003ddescription,"},{"line_number":71,"context_line":"                                    container\u003d\u0027container\u0027)"},{"line_number":72,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":73,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":74,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Get a given backup"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_6c05a90f","side":"PARENT","line":73,"updated":"2018-05-30 02:51:54.000000000","message":"This is yet another unrelated change.","commit_id":"0a83c71252897e214eb58cec2c00a6b1f2905e99"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"caf493715a7b8fbabdb5b0e0b2f434014b43091d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                    description\u003ddescription,"},{"line_number":71,"context_line":"                                    container\u003d\u0027container\u0027)"},{"line_number":72,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":73,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":74,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Get a given backup"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_16d51a1c","side":"PARENT","line":73,"in_reply_to":"5f7c97a3_6c05a90f","updated":"2018-05-30 15:19:32.000000000","message":"The volume status will be checked in `create_backup()` method, so this statement can be removed.","commit_id":"0a83c71252897e214eb58cec2c00a6b1f2905e99"}]}
