)]}'
{"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4e3e800e0ca4443af9fb8bfc20e880aea9ada931","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # List volume transfers, the result should be greater than"},{"line_number":55,"context_line":"        # or equal to 1"},{"line_number":56,"context_line":"        body \u003d self.client.list_volume_transfers()[\u0027transfers\u0027]"},{"line_number":57,"context_line":"        self.assertNotEqual(len(body), 0)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":60,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72a62c56","line":57,"range":{"start_line":57,"start_character":13,"end_line":57,"end_character":28},"updated":"2018-05-23 21:41:09.000000000","message":"this bug is not about changing the assert call, bug is that tests does not cleanup the volume.\n\nAnd that can happen if the created volumes if something wrong happen between create_volume_transfer()[@L43] call and accept_volume_transfer()[@L60] call then volume stay in \u0027awaiting-transfer\u0027 state and addCleanup[@L38] of delete_volume will not be able to delete the volume which are in \u0027awaiting-transfer\u0027 state.\n\nWe need to add the delete_volume_transfer() as addCleanup just after the create_volume_transfer() call and this should be added with test_utils.call_and_ignore_notfound_exc() to ignore the already deleted or accepted transfer.\n\nThis needs to be done in both of the tests.","commit_id":"81cc8d1b77a65dbca697328e4dd302a2d5ce6004"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"b6931aafeb8f1d13ec7b6b4442d9ae3bc8a5eebe","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":64,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("},{"line_number":65,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":66,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":67,"context_line":"                        self.client.delete_volume_transfer,"},{"line_number":68,"context_line":"                        transfer_id)"},{"line_number":69,"context_line":"        for key in [\u0027id\u0027, \u0027name\u0027, \u0027links\u0027, \u0027volume_id\u0027]:"},{"line_number":70,"context_line":"            self.assertIn(key, body)"},{"line_number":71,"context_line":"        waiters.wait_for_volume_resource_status(self.alt_volumes_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_1ec3e339","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":36},"updated":"2018-05-31 07:12:36.000000000","message":"Does \"addCleanup\" is required just after \"accept_volume_transfer\" as \"addCleanup\" is already called just after \"create_volume_transfer\"","commit_id":"b663948e488276e2c513f357a0734ad7588fc7f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3fa1aa3580329ce94e7cd5587646c80ef77bcb78","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":64,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("},{"line_number":65,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":66,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":67,"context_line":"                        self.client.delete_volume_transfer,"},{"line_number":68,"context_line":"                        transfer_id)"},{"line_number":69,"context_line":"        for key in [\u0027id\u0027, \u0027name\u0027, \u0027links\u0027, \u0027volume_id\u0027]:"},{"line_number":70,"context_line":"            self.assertIn(key, body)"},{"line_number":71,"context_line":"        waiters.wait_for_volume_resource_status(self.alt_volumes_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_61def86d","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":36},"in_reply_to":"5f7c97a3_1ec3e339","updated":"2018-05-31 07:51:34.000000000","message":"nice catch. this should not be needed now.","commit_id":"b663948e488276e2c513f357a0734ad7588fc7f6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dd887ba072fe1c5ce5623a4d1504bd80840f3264","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":64,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("},{"line_number":65,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":66,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":67,"context_line":"                        self.client.delete_volume_transfer,"},{"line_number":68,"context_line":"                        transfer_id)"},{"line_number":69,"context_line":"        for key in [\u0027id\u0027, \u0027name\u0027, \u0027links\u0027, \u0027volume_id\u0027]:"},{"line_number":70,"context_line":"            self.assertIn(key, body)"},{"line_number":71,"context_line":"        waiters.wait_for_volume_resource_status(self.alt_volumes_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_649926c2","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":36},"in_reply_to":"5f7c97a3_61def86d","updated":"2018-05-31 08:46:26.000000000","message":"Thanks for the comment. But what if anything wrong happens during accepting volume transfer?","commit_id":"b663948e488276e2c513f357a0734ad7588fc7f6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4164a14507e2d7a0e903575d857ebe5ec70220b6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":64,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("},{"line_number":65,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":66,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":67,"context_line":"                        self.client.delete_volume_transfer,"},{"line_number":68,"context_line":"                        transfer_id)"},{"line_number":69,"context_line":"        for key in [\u0027id\u0027, \u0027name\u0027, \u0027links\u0027, \u0027volume_id\u0027]:"},{"line_number":70,"context_line":"            self.assertIn(key, body)"},{"line_number":71,"context_line":"        waiters.wait_for_volume_resource_status(self.alt_volumes_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d73540f8","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":36},"in_reply_to":"5f7c97a3_649926c2","updated":"2018-06-01 01:05:32.000000000","message":"Good question. \nIn that case, transfer is not accepted and L47 cleanup will take care of cleaning up the ongoing transfer. \n\nIf it pass then class level cleanup will delete the volume as it will be in \u0027available\u0027 state. \n\nSo in both case we will be good without L66 cleanup.","commit_id":"b663948e488276e2c513f357a0734ad7588fc7f6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5e78b77ce7135245f9fb6bf88fe8c4e0a1baf381","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # List volume transfers, the result should be greater than"},{"line_number":59,"context_line":"        # or equal to 1"},{"line_number":60,"context_line":"        body \u003d self.client.list_volume_transfers()[\u0027transfers\u0027]"},{"line_number":61,"context_line":"        self.assertNotEqual(len(body), 0)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":64,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_60002035","line":61,"updated":"2018-06-01 05:21:08.000000000","message":"We should revert this change as Ghanshyam said in patchset 1. This is not a necessary change.\n\nBesides that, it is better to do this:\n\n    self.assertNotEqual(0, len(body))\n\nBecause the order should be (expected_value, actual_value).","commit_id":"e09fc5d6093a7ff99420b5e00cfc642f87113873"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5e78b77ce7135245f9fb6bf88fe8c4e0a1baf381","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # List all volume transfers with details, check the detail-specific"},{"line_number":95,"context_line":"        # elements, and look for the created transfer."},{"line_number":96,"context_line":"        transfers \u003d self.client.list_volume_transfers(detail\u003dTrue)[\u0027transfers\u0027]"},{"line_number":97,"context_line":"        self.assertNotEqual(len(transfers), 0)"},{"line_number":98,"context_line":"        for transfer in transfers:"},{"line_number":99,"context_line":"            self.assertIn(\u0027created_at\u0027, transfer)"},{"line_number":100,"context_line":"        volume_list \u003d [transfer[\u0027volume_id\u0027] for transfer in transfers]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_00fb6c46","line":97,"updated":"2018-06-01 05:21:08.000000000","message":"Ditto.","commit_id":"e09fc5d6093a7ff99420b5e00cfc642f87113873"}]}