)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e818ed786692cb6dac1a48daad1f3f381169f993","unresolved":false,"context_lines":[{"line_number":14,"context_line":"filters, even if those filters weren\u0027t enabled in Nova. This patch"},{"line_number":15,"context_line":"changes the default to match the current Nova default value."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-bug: 1628443"},{"line_number":18,"context_line":"Change-Id: I5c87865dc650d383ee006d36b6d52cdd90577ab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_e090fd50","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":20},"updated":"2018-09-17 22:49:55.000000000","message":"I like that we list the filters in this option as the name makes more sense now but.. we should be careful to consider the intention of the original fix[1] for this bug. Sorry if I misled you but there appears to be a decent amount of history with this config option. \n\nThis comment[2] has an explanation of tempest\u0027s use case for using \u0027all\u0027. One point says the is_scheduler_filter_enabled method is only used when writing tests, and during review no way will a scheduler with an improper name be merged intentionally, so the \"functional\" bug, weather this returns True for \u0027asdf\u0027 if the filter option is set to \u0027all\u0027 even if nova does not have an \u0027asdf\u0027 fitler is considered invalid because it will be caught in review. Is there another case I\u0027m missing or why is it not enough for reviewers to catch this misuse of the function?\n\nSo with all of the thought put into leaving this value\u0027s default as \u0027all\u0027, is it still beneficial to change it? Without any substantial evidence, like a gate failure, I\u0027m not sure if a change is needed.\n\n[1] https://review.openstack.org/#/c/405064/\n[2] https://bugs.launchpad.net/tempest/+bug/1628443/comments/3","commit_id":"3749b813d658b38ebc8eca135cec848f841b6aa0"}],"tempest/common/compute.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"636e751d7351aa2ca34c3a7a214daa2470c92cdd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    filters \u003d CONF.compute_feature_enabled.scheduler_available_filters"},{"line_number":56,"context_line":"    if not filters:"},{"line_number":57,"context_line":"        return False"},{"line_number":58,"context_line":"    if \u0027all\u0027 in filters:"},{"line_number":59,"context_line":"        return True"},{"line_number":60,"context_line":"    if filter_name in filters:"},{"line_number":61,"context_line":"        return True"},{"line_number":62,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_61eda6b6","side":"PARENT","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":19},"updated":"2018-07-19 05:39:53.000000000","message":"This is a backwards incompatible change. For people currently using Tempest with \u0027all\u0027 it will stop behaving correctly and break them so we can\u0027t just remove this without issuing deprecation warning for a few cycles.","commit_id":"de5f0da10e44a52e5bc5f577e4ec33231add3831"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef60b61843b45582cae331e65547c94158e98a6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    filters \u003d CONF.compute_feature_enabled.scheduler_available_filters"},{"line_number":56,"context_line":"    if not filters:"},{"line_number":57,"context_line":"        return False"},{"line_number":58,"context_line":"    if \u0027all\u0027 in filters:"},{"line_number":59,"context_line":"        return True"},{"line_number":60,"context_line":"    if filter_name in filters:"},{"line_number":61,"context_line":"        return True"},{"line_number":62,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_90a8de20","side":"PARENT","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":19},"in_reply_to":"5f7c97a3_61eda6b6","updated":"2018-09-12 07:10:41.000000000","message":"Yeah, fair enough. I\u0027ve changed this review to deprecate the \u0027all\u0027 value.","commit_id":"de5f0da10e44a52e5bc5f577e4ec33231add3831"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4aafb9567d493de15f2c0e5246a83485c3d5ca7f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    This function checks whether the given compute scheduler filter is enabled"},{"line_number":48,"context_line":"    in the nova config file. If the scheduler_enabled_filters option is set to"},{"line_number":49,"context_line":"    \u0027all\u0027 in tempest.conf then, this function returns True with assumption that"},{"line_number":50,"context_line":"    requested filter \u0027filter_name\u0027 is one of available filter in nova"},{"line_number":51,"context_line":"    (\"nova.scheduler.filters.all_filters\")."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_2b6dcd99","line":50,"range":{"start_line":50,"start_character":45,"end_line":50,"end_character":54},"updated":"2018-11-02 06:53:27.000000000","message":"s/available/enabled","commit_id":"00c2b0c33fd7e3c5c409643469ab2a5e6cbb644e"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e1c05a8549d1e18ac567383779fb556ea3b0cf7a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    This function checks whether the given compute scheduler filter is enabled"},{"line_number":48,"context_line":"    in the nova config file. If the scheduler_enabled_filters option is set to"},{"line_number":49,"context_line":"    \u0027all\u0027 in tempest.conf then, this function returns True with assumption that"},{"line_number":50,"context_line":"    requested filter \u0027filter_name\u0027 is one of available filter in nova"},{"line_number":51,"context_line":"    (\"nova.scheduler.filters.all_filters\")."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_1cf2926a","line":50,"range":{"start_line":50,"start_character":45,"end_line":50,"end_character":54},"in_reply_to":"3f79a3b5_2b6dcd99","updated":"2018-11-02 12:10:00.000000000","message":"Done","commit_id":"00c2b0c33fd7e3c5c409643469ab2a5e6cbb644e"}],"tempest/config.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"0faf0daea4887b1c9d6c3142d077a9accd5f6a11","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                default\u003dTrue,"},{"line_number":469,"context_line":"                help\u003d\u0027Enable special configuration drive with metadata.\u0027),"},{"line_number":470,"context_line":"    cfg.ListOpt(\u0027scheduler_available_filters\u0027,"},{"line_number":471,"context_line":"                default\u003d[\u0027RetryFilter,AvailabilityZoneFilter,ComputeFilter,\u0027"},{"line_number":472,"context_line":"                         \u0027ComputeCapabilitiesFilter,ImagePropertiesFilter,\u0027"},{"line_number":473,"context_line":"                         \u0027ServerGroupAntiAffinityFilter,\u0027"},{"line_number":474,"context_line":"                         \u0027ServerGroupAffinityFilter\u0027],"},{"line_number":475,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":476,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":477,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3153256f","line":474,"range":{"start_line":471,"start_character":24,"end_line":474,"end_character":53},"updated":"2018-06-05 07:08:47.000000000","message":"I think some of filters from nova.conf have missed e.g. SameHostFilter,DifferentHostFilter.\nIs it intentional?","commit_id":"acc729c05e17ce83c19b7b32c518693d21072420"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6f6e803d7ddfcb1c18b519a658df110fed53a84d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                default\u003dTrue,"},{"line_number":469,"context_line":"                help\u003d\u0027Enable special configuration drive with metadata.\u0027),"},{"line_number":470,"context_line":"    cfg.ListOpt(\u0027scheduler_available_filters\u0027,"},{"line_number":471,"context_line":"                default\u003d[\u0027RetryFilter,AvailabilityZoneFilter,ComputeFilter,\u0027"},{"line_number":472,"context_line":"                         \u0027ComputeCapabilitiesFilter,ImagePropertiesFilter,\u0027"},{"line_number":473,"context_line":"                         \u0027ServerGroupAntiAffinityFilter,\u0027"},{"line_number":474,"context_line":"                         \u0027ServerGroupAffinityFilter\u0027],"},{"line_number":475,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":476,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":477,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_515a6150","line":474,"range":{"start_line":471,"start_character":24,"end_line":474,"end_character":53},"in_reply_to":"5f7c97a3_3153256f","updated":"2018-06-05 07:19:16.000000000","message":"I\u0027ve used the nova defaults, which don\u0027t include SameHostFilter and DifferentHostFilter:\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/scheduler.py#L308-L314","commit_id":"acc729c05e17ce83c19b7b32c518693d21072420"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"636e751d7351aa2ca34c3a7a214daa2470c92cdd","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                default\u003dTrue,"},{"line_number":469,"context_line":"                help\u003d\u0027Enable special configuration drive with metadata.\u0027),"},{"line_number":470,"context_line":"    cfg.ListOpt(\u0027scheduler_available_filters\u0027,"},{"line_number":471,"context_line":"                default\u003d[\u0027RetryFilter,AvailabilityZoneFilter,ComputeFilter,\u0027"},{"line_number":472,"context_line":"                         \u0027ComputeCapabilitiesFilter,ImagePropertiesFilter,\u0027"},{"line_number":473,"context_line":"                         \u0027ServerGroupAntiAffinityFilter,\u0027"},{"line_number":474,"context_line":"                         \u0027ServerGroupAffinityFilter\u0027],"},{"line_number":475,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":476,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":477,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_81d9e2f1","line":474,"range":{"start_line":471,"start_character":25,"end_line":474,"end_character":52},"updated":"2018-07-19 05:39:53.000000000","message":"I don\u0027t think this is populated with the full list of available filters in devstack installation anywhere for tempest. That is something we might have to do in another patch set in devstack.","commit_id":"d92d0f60a3994389c3b0a4c58ca556712f28898e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"35b2cb45a1fcc0727bcf9548d2d3833789349e72","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\u0027The \"all\" default value of \u0027"},{"line_number":482,"context_line":"                                  \u0027scheduler_available_filters is interpreted \u0027"},{"line_number":483,"context_line":"                                  \u0027by many tests as meaning \"all filters are \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_532b3032","line":480,"range":{"start_line":480,"start_character":16,"end_line":480,"end_character":38},"updated":"2018-09-12 07:55:17.000000000","message":"1. This will deprecate config item scheduler_available_filters, not only its default value.\n2. To populate all filters according to nova.conf may be done in devstack, but for product cloud testing lacking of simple default value will bring much trouble.","commit_id":"176e4fd45e85cb1e31902d74a86c716cebeefef6"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7266cc9733bea69d4709ca4e08cfb1df895082c2","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\u0027The \"all\" default value of \u0027"},{"line_number":482,"context_line":"                                  \u0027scheduler_available_filters is interpreted \u0027"},{"line_number":483,"context_line":"                                  \u0027by many tests as meaning \"all filters are \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_28be28ae","line":480,"range":{"start_line":480,"start_character":16,"end_line":480,"end_character":38},"in_reply_to":"3f79a3b5_4daff62a","updated":"2018-09-13 10:16:36.000000000","message":"Right, except in this case the nova defaults are a subset of all available filter. For example, DifferentHostFilter isn\u0027t in the nova defaults. On the other hand, tempest\u0027s is_scheduler_filter_enabled() method treats \"all\" as meaning \"all filters are enabled\" [1], and it\u0027ll return True for any filter if scheduler_available_filters is set to \"all\". So, assuming everything set to default, if a test depends on DifferentHostFilter, it\u0027ll ask is_scheduler_filter_enabled(), get True, then fail and/or behave unexpectedly. I don\u0027t see a way around this short of requiring an explicit list of filters, without any special values.\n\n[1] https://github.com/openstack/tempest/blob/19.0.0/tempest/common/compute.py#L59","commit_id":"176e4fd45e85cb1e31902d74a86c716cebeefef6"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d487b8aaee62ee10e670aae49679bd1482300a99","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\u0027The \"all\" default value of \u0027"},{"line_number":482,"context_line":"                                  \u0027scheduler_available_filters is interpreted \u0027"},{"line_number":483,"context_line":"                                  \u0027by many tests as meaning \"all filters are \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5e65771c","line":480,"range":{"start_line":480,"start_character":16,"end_line":480,"end_character":38},"in_reply_to":"3f79a3b5_532b3032","updated":"2018-09-12 09:36:18.000000000","message":"\u003e 1. This will deprecate config item\n\u003e scheduler_available_filters, not\n\u003e only its default value.\n\nYeah, I know, I just don\u0027t see how else we can indicate the deprecation of a particular *value*.\n\n\u003e 2. To populate all filters according to nova.conf may be\n\u003e done in devstack, but for product cloud testing\n\u003e lacking of simple default value will bring much\n\u003e trouble.\n\nThat\u0027s the thing though, \"all\" *wasn\u0027t* simple. If it\u0027s set to \u0027all\u0027 in tempest.conf, but to the default in nova.conf, that\u0027s misleading and is technically a bug, because a test that depends on DifferentHostFilter, for example, will still run, then behave unexpectedly because the filter isn\u0027t actually enabled. Our Red Hat QE have run into this a number of times. I\u0027m open to other ideas, but so far all I have is \"it can only be a list of filters, no other special value allowed.\" At least then everything is explicit, and there\u0027s less confusion.","commit_id":"176e4fd45e85cb1e31902d74a86c716cebeefef6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"38fc2bf31870ec4881704cc7c6deeea26f24b7f8","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\u0027The \"all\" default value of \u0027"},{"line_number":482,"context_line":"                                  \u0027scheduler_available_filters is interpreted \u0027"},{"line_number":483,"context_line":"                                  \u0027by many tests as meaning \"all filters are \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4daff62a","line":480,"range":{"start_line":480,"start_character":16,"end_line":480,"end_character":38},"in_reply_to":"3f79a3b5_5e65771c","updated":"2018-09-13 09:29:49.000000000","message":"\u0027all\u0027 usually means the tested system uses the nova.conf\u0027s default value.\ne.g., [compute-feature-enabled].serial_console\u0027s default value is False because nova.conf:serial_console.enabled default to False.\nSo if the tested system changed nova.conf:serial_console.enabled, [compute-feature-enabled].serial_console must be changed accordingly.","commit_id":"176e4fd45e85cb1e31902d74a86c716cebeefef6"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e818ed786692cb6dac1a48daad1f3f381169f993","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":472,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as hints\""},{"line_number":473,"context_line":"                     \" to the scheduler when creating a server. A special \""},{"line_number":474,"context_line":"                     \"entry \u0027all\u0027 indicates all filters that are included \""},{"line_number":475,"context_line":"                     \"with nova are enabled. Empty list indicates all filters \""},{"line_number":476,"context_line":"                     \"are disabled. The full list of available filters is in \""},{"line_number":477,"context_line":"                     \"nova.conf: filter_scheduler.enabled_filters. If the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_536429b9","line":474,"range":{"start_line":474,"start_character":28,"end_line":474,"end_character":33},"updated":"2018-09-17 22:49:55.000000000","message":"I wish this value was more explicit, like \u0027all_nova_defaults\u0027 or something like that. I think that would help make it more clear.","commit_id":"3749b813d658b38ebc8eca135cec848f841b6aa0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0334941fd80078e57480ea475824b479dd41296d","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_983faede","line":484,"range":{"start_line":480,"start_character":0,"end_line":484,"end_character":71},"updated":"2018-10-18 16:42:25.000000000","message":"we can use deprecated_opts like L72 and use new config option scheduler_enabled_filters in code. that way people still using old one continue working.\n\nOtherwise we would not have way to use both config option.","commit_id":"7e2c1e143ac552c7a17551e7f275cae64bd6fe49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37bad58f5aa18ea2a45507abecfcb1762eef6e32","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_acca89a0","line":484,"range":{"start_line":480,"start_character":0,"end_line":484,"end_character":71},"in_reply_to":"3f79a3b5_1024150d","updated":"2018-10-31 01:06:12.000000000","message":"it should work fine. whatever value is set on \u0027scheduler_available_filter\u0027 will be taken and proceed. The only issue is if anyone relies on \u0027all\u0027 default value will change to new default value list which should be fine if we mention that in reno upgrade section.","commit_id":"7e2c1e143ac552c7a17551e7f275cae64bd6fe49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9def790cb9871ea38f4e969ac6f9d4dad54fb9f9","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_1024150d","line":484,"range":{"start_line":480,"start_character":0,"end_line":484,"end_character":71},"in_reply_to":"3f79a3b5_46319e09","updated":"2018-10-29 12:42:42.000000000","message":"Can this work if \u0027all\u0027 is a supported value for the deprecated scheduler_available_filters but not for the new scheduler_enabled_filters? I\u0027m not really familiar with deprecation internals, I\u0027m just afraid that someone who has \u0027all\u0027 for scheduler_available_filters will see errors because \u0027all\u0027 isn\u0027t a valid value for scheduler_enabled_filters, which replaces it.","commit_id":"7e2c1e143ac552c7a17551e7f275cae64bd6fe49"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"db8ef047a2366bf8a920e0ebb596122384953436","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_db7c2eec","line":484,"range":{"start_line":480,"start_character":0,"end_line":484,"end_character":71},"in_reply_to":"3f79a3b5_983faede","updated":"2018-10-19 15:53:10.000000000","message":"Wait, did you want to support the \u0027all\u0027 value for scheduler_enabled_filters? I thought we didn\u0027t, which is why I didn\u0027t do a straight up \"replacement\"","commit_id":"7e2c1e143ac552c7a17551e7f275cae64bd6fe49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c81c2f12416629dece42988eec4a8a73c0d3a7b3","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                     \"default) then, this option must be configured to \""},{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_46319e09","line":484,"range":{"start_line":480,"start_character":0,"end_line":484,"end_character":71},"in_reply_to":"3f79a3b5_db7c2eec","updated":"2018-10-26 06:31:45.000000000","message":"not with \u0027all\u0027 but with same default value you added in this patch. \n\nThat way we can achieve: \n- start supporting the new config options scheduler_enabled_filters with new defaults [L486]\n\n- If anyone has overridden the old config options \u0027scheduler_available_filters\u0027 with custom values, we keep supporting that till deprecation phase.","commit_id":"7e2c1e143ac552c7a17551e7f275cae64bd6fe49"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5128a5d6e0c5db87802d7e2f7b03e15002dc304e","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_2a4bc0b2","line":481,"range":{"start_line":481,"start_character":35,"end_line":481,"end_character":66},"updated":"2018-10-30 20:43:45.000000000","message":"I cannot follow this meaning. The help message is already improved with https://review.openstack.org/#/c/405064/ as the above.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f84065deea624cb826d5756c03d7ab0c93109a2b","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_df40a107","line":481,"range":{"start_line":481,"start_character":35,"end_line":481,"end_character":66},"in_reply_to":"3f79a3b5_2a4bc0b2","updated":"2018-11-01 16:07:33.000000000","message":"Consider a fan on a desk in a nuclear power station. A button next to the fan has a large label with the title \"cooling on/off\". Underneath that title is a paragraph describing how this switch doesn\u0027t in fact turn off the fan but rather the cooling for the reactors. The function of the button is described but only if you read the text. That\u0027s bad UX.\n\nWhat artom\u0027s referring to here behavior of the option, not the wording of its help text. As highlighted in the change you\u0027ve linked, to a unobservant reader, \u0027all\u0027 would suggest all _enabled_ nova filters rather than all _possible_ filters. Sure, they might read the help text to find out this is not the case but it is likely that would only do so after they\u0027ve seen their tests fail and have dug in to investigate why that\u0027s happening. This is, in my opinion, a bug.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b192a641699718c7f0b6a02c50bf247e7ac7c4a7","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_f2454f73","line":481,"range":{"start_line":481,"start_character":35,"end_line":481,"end_character":66},"in_reply_to":"3f79a3b5_df40a107","updated":"2018-11-05 19:04:53.000000000","message":"\u003e Consider a fan on a desk in a nuclear power station. A button next to the fan has a large label with the title \"cooling on/off\".\n\nHehe, I am a big fun of this kind :-)","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"39e90a8616e2f9fd8552a95171a2564903443723","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                     \"contain the same filters that Nova uses in the test \""},{"line_number":479,"context_line":"                     \"environment.\","},{"line_number":480,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":481,"context_line":"                deprecated_reason\u003d\"The \u0027all\u0027 default is confusing. Deprecated \""},{"line_number":482,"context_line":"                                  \"in favor of scheduler_enabled_filters, \""},{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_4a74ce9b","line":481,"range":{"start_line":481,"start_character":35,"end_line":481,"end_character":66},"in_reply_to":"3f79a3b5_df40a107","updated":"2018-11-01 19:40:20.000000000","message":"Heh, perhaps Ken\u0027ichi was right, I wasn\u0027t being super explicit. On any case, it\u0027s a moot point, as I\u0027ve done the deprecation like gmann suggested, so there\u0027s no longer a need for a deprecated_reason text.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"836a470a2b599573e54403737fda9d67eed885ba","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_4cad0e81","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"updated":"2018-10-30 02:58:10.000000000","message":"In fact only 4 filters are used in Tempest: DifferentHostFilter, SameHostFilter, ServerGroupAffinityFilter, ServerGroupAntiAffinityFilter, so I hesitate whether we should put something like RetryFilter here, I don\u0027t know whether it will cause some confusion(RetryFilter is here or not here makes no difference)","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"39e90a8616e2f9fd8552a95171a2564903443723","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_aa9b2263","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"in_reply_to":"3f79a3b5_4cad0e81","updated":"2018-11-01 19:40:20.000000000","message":"\u003e In fact only 4 filters are used in Tempest: DifferentHostFilter,\n \u003e SameHostFilter, ServerGroupAffinityFilter, ServerGroupAntiAffinityFilter,\n \u003e so I hesitate whether we should put something like RetryFilter\n \u003e here, I don\u0027t know whether it will cause some confusion(RetryFilter\n \u003e is here or not here makes no difference)\n\nThis isn\u0027t about what Tempest uses, it\u0027s about making sure that in default deployments, Nova\u0027s and Tempest\u0027s views of what filters are enabled are the same. Otherwise, tests that depend on, for example, SameHostFilter will fail because they think it\u0027s enabled (from Tempest\u0027s \u0027all\u0027 default) when in reality it isn\u0027t (from Nova\u0027s defaults).","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5128a5d6e0c5db87802d7e2f7b03e15002dc304e","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_aa5fd072","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"in_reply_to":"3f79a3b5_4cad0e81","updated":"2018-10-30 20:43:45.000000000","message":"Nice point.\nIn addition, I am not sure how to follow the default value change of Nova if it happens.\nTempest is branchless, should we change this option value for the latest master even if this option is used for stable branches which are not affected yet at the time.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf3e146a2f8dd7baed3b622e9367c787b9d76323","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_e2e93ae4","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"in_reply_to":"3f79a3b5_7f15cd3d","updated":"2018-11-02 04:14:54.000000000","message":"removing the default value makes difficult to configure Tempest. We faced \"Hard to Configure Tempest\" issue in past and keeping the default values which can run on master deployement eaisly. \n\nAnd yes we cannot accomodate older branches if default values are changed. And we take care of such default change with upgrade reno like service side.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f84065deea624cb826d5756c03d7ab0c93109a2b","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_7f15cd3d","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"in_reply_to":"3f79a3b5_aa5fd072","updated":"2018-11-01 16:07:33.000000000","message":"\u003e Nice point.\n \u003e In addition, I am not sure how to follow the default value change\n \u003e of Nova if it happens.\n \u003e Tempest is branchless, should we change this option value for the\n \u003e latest master even if this option is used for stable branches which\n \u003e are not affected yet at the time.\n\nIt is branchless, yes, but some configuration is expected/required, particularly for older releases, right? As things stand, tempest will not work with nova-scheduler in its default configuration and you will need to configure either nova-scheduler or tempest. This is really awkward to do from a deployment tool because, in general, they\u0027re using the nova-scheduler defaults unless they\u0027ve been explicitly told not to. As a result they\u0027ve nothing to configure tempest with. We could hardcode the above list within said deployment tools (so they\u0027ll always manually configure this option in tempest) but then we\u0027re duplicating effort and it doesn\u0027t resolve the problem that tempest is broken out-of-the-box if using the \"standard\" nova-scheduler configuration.\n\nWhat this change means is that the _default_ value will be suitable for testing against master and will work by default. This requires the least effort from a deployment/CI perspective because for the situations where we\u0027re configuring the nova-scheduler settings, we have enough information to configure tempest too, and for the situations where we\u0027re using the nova defaults we can use the tempest default too. Deployment tooling will still need to figure out some way to identify what nova\u0027s defaults are/were for older releases but that won\u0027t be necessary on master, where 90% of the automated testing takes place. The alternative to this is to remove the default entirely, but, as noted above, doing so you would deployments duplicate nova\u0027s implicit defaults.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37bad58f5aa18ea2a45507abecfcb1762eef6e32","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                                  \"whose default value comes from Nova\u0027s \""},{"line_number":484,"context_line":"                                  \"enabled_filters. See bug 1628443.\"),"},{"line_number":485,"context_line":"    cfg.ListOpt(\u0027scheduler_enabled_filters\u0027,"},{"line_number":486,"context_line":"                default\u003d[\"RetryFilter\", \"AvailabilityZoneFilter\","},{"line_number":487,"context_line":"                         \"ComputeFilter\", \"ComputeCapabilitiesFilter\","},{"line_number":488,"context_line":"                         \"ImagePropertiesFilter\","},{"line_number":489,"context_line":"                         \"ServerGroupAntiAffinityFilter\","},{"line_number":490,"context_line":"                         \"ServerGroupAffinityFilter\"],"},{"line_number":491,"context_line":"                help\u003d\"A list of enabled filters that nova will accept as \""},{"line_number":492,"context_line":"                     \"hints to the scheduler when creating a server. Empty \""},{"line_number":493,"context_line":"                     \"list indicates all filters are disabled. The full list \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_0c4a9d23","line":490,"range":{"start_line":486,"start_character":24,"end_line":490,"end_character":54},"in_reply_to":"3f79a3b5_aa5fd072","updated":"2018-10-31 01:06:12.000000000","message":"nice point about stable branches but that is the case for every config option. We try to make the default value of tempest config options as close as to corresponding service config options on the master branch.\n\nLike other options also we can default this config options to the default value of what Nova has in master. And change their default value if that is changed on the service side. For example, we did for nova-cert options.","commit_id":"443308b5a35320d0751c8854625260e4922d4c7c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4aafb9567d493de15f2c0e5246a83485c3d5ca7f","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                     \"nova.conf, as tests can fail in unpredictable ways if \""},{"line_number":483,"context_line":"                     \"Nova\u0027s and Tempest\u0027s enabled filters don\u0027t match. \""},{"line_number":484,"context_line":"                     \"Empty list indicates all filters are disabled. The \""},{"line_number":485,"context_line":"                     \"full list of available filters is in nova.conf: \""},{"line_number":486,"context_line":"                     \"filter_scheduler.enabled_filters.\","},{"line_number":487,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt("},{"line_number":488,"context_line":"                    \u0027scheduler_available_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_eb66f5bc","line":485,"range":{"start_line":485,"start_character":35,"end_line":485,"end_character":44},"updated":"2018-11-02 06:53:27.000000000","message":"enabled","commit_id":"00c2b0c33fd7e3c5c409643469ab2a5e6cbb644e"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e1c05a8549d1e18ac567383779fb556ea3b0cf7a","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                     \"nova.conf, as tests can fail in unpredictable ways if \""},{"line_number":483,"context_line":"                     \"Nova\u0027s and Tempest\u0027s enabled filters don\u0027t match. \""},{"line_number":484,"context_line":"                     \"Empty list indicates all filters are disabled. The \""},{"line_number":485,"context_line":"                     \"full list of available filters is in nova.conf: \""},{"line_number":486,"context_line":"                     \"filter_scheduler.enabled_filters.\","},{"line_number":487,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt("},{"line_number":488,"context_line":"                    \u0027scheduler_available_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_3c70aedb","line":485,"range":{"start_line":485,"start_character":35,"end_line":485,"end_character":44},"in_reply_to":"3f79a3b5_eb66f5bc","updated":"2018-11-02 12:10:00.000000000","message":"Done","commit_id":"00c2b0c33fd7e3c5c409643469ab2a5e6cbb644e"}]}