)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f9ab5da07c87effc617f86729357b30249fff0ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Not all the apis in tempest/api/volume/admin/test_volumes_backup.py"},{"line_number":10,"context_line":"should use admin credential, some apis could switch to use primary"},{"line_number":11,"context_line":"credential."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied77f68c982f3a8445956ad1a4ea47c3795d3294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_4a8c3a35","line":12,"updated":"2018-05-31 00:02:28.000000000","message":"Would be helpful to link to https://github.com/openstack/cinder/blob/master/cinder/policies/backups.py","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"c3982cd54d64d1e62ce7d4fc7253e769b3d11a93","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Not all the apis in tempest/api/volume/admin/test_volumes_backup.py"},{"line_number":10,"context_line":"should use admin credential, some apis could switch to use primary"},{"line_number":11,"context_line":"credential."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied77f68c982f3a8445956ad1a4ea47c3795d3294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_65d84952","line":12,"in_reply_to":"5f7c97a3_4a8c3a35","updated":"2018-05-31 01:22:57.000000000","message":"Yes, the link will be helpful","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"}],"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f9ab5da07c87effc617f86729357b30249fff0ae","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.addCleanup(self._delete_backup, new_id)"},{"line_number":93,"context_line":"        self.assertIn(\"id\", import_backup)"},{"line_number":94,"context_line":"        self.assertEqual(new_id, import_backup[\u0027id\u0027])"},{"line_number":95,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":96,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":97,"context_line":"                                                \u0027available\u0027)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ca960a4d","line":95,"range":{"start_line":95,"start_character":53,"end_line":95,"end_character":73},"updated":"2018-05-31 00:02:28.000000000","message":"Looks like this can be non-admin?","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"c3982cd54d64d1e62ce7d4fc7253e769b3d11a93","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.addCleanup(self._delete_backup, new_id)"},{"line_number":93,"context_line":"        self.assertIn(\"id\", import_backup)"},{"line_number":94,"context_line":"        self.assertEqual(new_id, import_backup[\u0027id\u0027])"},{"line_number":95,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":96,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":97,"context_line":"                                                \u0027available\u0027)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_856b2583","line":95,"range":{"start_line":95,"start_character":53,"end_line":95,"end_character":73},"in_reply_to":"5f7c97a3_ca960a4d","updated":"2018-05-31 01:22:57.000000000","message":"The \u0027import_backup\u0027 can only be createdy by os_admin credential, so only os_admin user can access it.","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f9ab5da07c87effc617f86729357b30249fff0ae","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # Verify if restored volume is there in volume list"},{"line_number":113,"context_line":"        volumes \u003d self.volumes_client.list_volumes()[\u0027volumes\u0027]"},{"line_number":114,"context_line":"        self.assertIn(restore[\u0027volume_id\u0027], [v[\u0027id\u0027] for v in volumes])"},{"line_number":115,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":116,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":117,"context_line":"                                                \u0027available\u0027)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0aa9628e","line":115,"range":{"start_line":115,"start_character":53,"end_line":115,"end_character":73},"updated":"2018-05-31 00:02:28.000000000","message":"Looks like this can be non-admin?","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"c3982cd54d64d1e62ce7d4fc7253e769b3d11a93","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # Verify if restored volume is there in volume list"},{"line_number":113,"context_line":"        volumes \u003d self.volumes_client.list_volumes()[\u0027volumes\u0027]"},{"line_number":114,"context_line":"        self.assertIn(restore[\u0027volume_id\u0027], [v[\u0027id\u0027] for v in volumes])"},{"line_number":115,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":116,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":117,"context_line":"                                                \u0027available\u0027)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_650a89d2","line":115,"range":{"start_line":115,"start_character":53,"end_line":115,"end_character":73},"in_reply_to":"5f7c97a3_0aa9628e","updated":"2018-05-31 01:22:57.000000000","message":"ditto","commit_id":"262ae94869d48784ab998f7e86e50e6ef45dc001"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"776add09fe5b863a0c569d81fb9865f2d65d6edc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _delete_backup(self, backup_id):"},{"line_number":37,"context_line":"        self.admin_backups_client.delete_backup(backup_id)"},{"line_number":38,"context_line":"        self.admin_backups_client.wait_for_resource_deletion(backup_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _decode_url(self, backup_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7711cc5c","line":37,"updated":"2018-06-01 01:07:44.000000000","message":"I\u0027m guessing here we need admin because L92 deletes backup that was imported?","commit_id":"112b8446e36e09118b1c32e71864704ba69f4db9"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"5c389936c09c687470d86d098c6c3ed384fd315d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _delete_backup(self, backup_id):"},{"line_number":37,"context_line":"        self.admin_backups_client.delete_backup(backup_id)"},{"line_number":38,"context_line":"        self.admin_backups_client.wait_for_resource_deletion(backup_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _decode_url(self, backup_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7a969140","line":37,"in_reply_to":"5f7c97a3_7711cc5c","updated":"2018-06-01 01:41:36.000000000","message":"Yes, :)","commit_id":"112b8446e36e09118b1c32e71864704ba69f4db9"}]}