)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3857973fda58559c26285453a4f07bd5799d9c9f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertIn(restore[\u0027volume_id\u0027], [v[\u0027id\u0027] for v in volumes])"},{"line_number":118,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":119,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":120,"context_line":"                                                \u0027available\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @decorators.idempotent_id(\u002747a35425-a891-4e13-961c-c45deea21e94\u0027)"},{"line_number":123,"context_line":"    def test_volume_backup_reset_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bb052248","side":"PARENT","line":120,"updated":"2018-05-31 04:43:29.000000000","message":"I think this check is necessary because resotre-backup operation changes the state of the backup to \"restoring\"[0]. So, adding a comment/NOTE might be useful to avoid the confusing here.\n\n[0] https://review.openstack.org/#/c/165371/8/tempest/api/volume/admin/test_volumes_backup.py","commit_id":"e317b0b84080a8afcb15311d9b86a89753306cde"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"feb223178dfea711f4bcf8db37f56af39597fbb3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertIn(restore[\u0027volume_id\u0027], [v[\u0027id\u0027] for v in volumes])"},{"line_number":118,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":119,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":120,"context_line":"                                                \u0027available\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @decorators.idempotent_id(\u002747a35425-a891-4e13-961c-c45deea21e94\u0027)"},{"line_number":123,"context_line":"    def test_volume_backup_reset_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9b3865ee","side":"PARENT","line":120,"in_reply_to":"5f7c97a3_9b6aa5ea","updated":"2018-05-31 06:30:38.000000000","message":"Maybe this test is originallly to test restoring the import backup, but actually to test restoring the original backup.","commit_id":"e317b0b84080a8afcb15311d9b86a89753306cde"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"132f0280f53b0285f01438b583310450c1070a84","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertIn(restore[\u0027volume_id\u0027], [v[\u0027id\u0027] for v in volumes])"},{"line_number":118,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":119,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":120,"context_line":"                                                \u0027available\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @decorators.idempotent_id(\u002747a35425-a891-4e13-961c-c45deea21e94\u0027)"},{"line_number":123,"context_line":"    def test_volume_backup_reset_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9b6aa5ea","side":"PARENT","line":120,"in_reply_to":"5f7c97a3_bb052248","updated":"2018-05-31 06:27:00.000000000","message":"Hi, Masayuki. When restore backup, [0] is to restore `import_backup[\u0027id\u0027]`, but here is to restore the `backup[\u0027id\u0027]`. If to restore the `backup[\u0027id\u0027]`, I think the waiters can be removed.","commit_id":"e317b0b84080a8afcb15311d9b86a89753306cde"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"2d09fc979d3879e52cad2451b4d1093a319fea6d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.addCleanup(self.admin_volume_client.delete_volume,"},{"line_number":107,"context_line":"                        restore[\u0027volume_id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(import_backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":109,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_backups_client,"},{"line_number":110,"context_line":"                                                import_backup[\u0027id\u0027],"},{"line_number":111,"context_line":"                                                \u0027available\u0027)"},{"line_number":112,"context_line":"        waiters.wait_for_volume_resource_status(self.admin_volume_client,"},{"line_number":113,"context_line":"                                                restore[\u0027volume_id\u0027],"},{"line_number":114,"context_line":"                                                \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f479e3c4","line":111,"range":{"start_line":109,"start_character":8,"end_line":111,"end_character":60},"updated":"2018-06-07 05:18:41.000000000","message":"I feel no additional advantage of using waiter here, is there any issue if we don\u0027t remove the existing waiter which was in L[115] of base code, else looks fine","commit_id":"738d3fea3050bc4dad32f1f04b4a0feeaec796dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"57812bb1a09217d973eb454c32e72112663c310c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":106,"context_line":"                        restore[\u0027volume_id\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":108,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":109,"context_line":"            self.backups_client, backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":110,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":111,"context_line":"            self.volumes_client, restore[\u0027volume_id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_acee77b2","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":59},"updated":"2018-06-11 10:57:12.000000000","message":"please add a note here about why we are waiting for backup[\u0027id\u0027] to be available\n\n# When restore operation is performed then, backup[\u0027id\u0027]\n# goes to \u0027restoring\u0027 state so we need to wait for\n# backup[\u0027id\u0027] to become \u0027available\u0027.","commit_id":"9c21ef99193c7799719e08af4593ba626cca1e2e"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"9ccb53561181d51bc14be4557e63ab96269acae4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":106,"context_line":"                        restore[\u0027volume_id\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":108,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":109,"context_line":"            self.backups_client, backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":110,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":111,"context_line":"            self.volumes_client, restore[\u0027volume_id\u0027], \u0027available\u0027)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_15044b13","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":59},"in_reply_to":"5f7c97a3_acee77b2","updated":"2018-06-11 15:29:23.000000000","message":"Done, :)","commit_id":"9c21ef99193c7799719e08af4593ba626cca1e2e"}]}