)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"fcbd402d155db271976aa77fbcca264732c62fd9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     msidana \u003cmanik@voereir.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-05 12:18:07 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing the dependency of CONF.network.public_network_id on test_volume_boot_pattern()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I887b941b92b61f6ca9d6054f94b2ff9abbc1f5f8"},{"line_number":10,"context_line":"Closes-Bug: #1774870"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d164314c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":87},"updated":"2018-06-05 07:07:05.000000000","message":"You can update the commit message with some description to make this more understandable.","commit_id":"95f82c4cf83807c314f66495b8ab0c9c86fe91d1"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d9228b398539d48ae8eeae9417a87b6727790","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        waiters.wait_for_server_termination(self.servers_client, server[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027557cd2c2-4eb8-4dce-98be-f86765ff311b\u0027)"},{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.network.public_network_id,"},{"line_number":72,"context_line":"                          \u0027The public_network_id option must be specified.\u0027)"},{"line_number":73,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":74,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_654a0084","side":"PARENT","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"updated":"2018-06-07 02:17:53.000000000","message":"you can add comment here\n# Note: This test is being skipped based on \u0027public_network_id\u0027. It is being used in create_floating_ip() method which is being called from get_server_ip() method.","commit_id":"575dc80cd9b9fb748707b15942e1592ae9747211"},{"author":{"_account_id":17927,"name":"Manik Sidana","email":"manik@voereir.com","username":"maniksidana019"},"change_message_id":"510032a88c83b55650be8ba286eec9d7451b4ab5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        waiters.wait_for_server_termination(self.servers_client, server[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027557cd2c2-4eb8-4dce-98be-f86765ff311b\u0027)"},{"line_number":71,"context_line":"    @testtools.skipUnless(CONF.network.public_network_id,"},{"line_number":72,"context_line":"                          \u0027The public_network_id option must be specified.\u0027)"},{"line_number":73,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":74,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f4700343","side":"PARENT","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"in_reply_to":"5f7c97a3_654a0084","updated":"2018-06-07 04:23:33.000000000","message":"Sure, I\u0027ll add it.","commit_id":"575dc80cd9b9fb748707b15942e1592ae9747211"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"64b4516737f9bb9d1c89be56c6dc1f8ba1b9b87c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # write content to volume on instance"},{"line_number":103,"context_line":"        LOG.info(\"Setting timestamp in instance %s\", instance_1st)"},{"line_number":104,"context_line":"        ip_instance_1st \u003d self.get_server_ip(instance_1st)"},{"line_number":105,"context_line":"        timestamp \u003d self.create_timestamp(ip_instance_1st,"},{"line_number":106,"context_line":"                                          private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc3d25de","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":44},"updated":"2018-06-05 08:42:00.000000000","message":"I think get_server_ip is using network which is defined in config.(e.g. floating).\nIf you remove the check for skip test of network id, it will run fine in case when network exists on system.\nBut if network does not exist then this fix will fail the test instead of skiping it.","commit_id":"95f82c4cf83807c314f66495b8ab0c9c86fe91d1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f623894f81f485b046c2ba083e54bf604564e8bc","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # write content to volume on instance"},{"line_number":103,"context_line":"        LOG.info(\"Setting timestamp in instance %s\", instance_1st)"},{"line_number":104,"context_line":"        ip_instance_1st \u003d self.get_server_ip(instance_1st)"},{"line_number":105,"context_line":"        timestamp \u003d self.create_timestamp(ip_instance_1st,"},{"line_number":106,"context_line":"                                          private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_05fd4c3a","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":44},"in_reply_to":"5f7c97a3_dc3d25de","updated":"2018-06-07 02:10:36.000000000","message":"yes, it is being used in create_floating_ip() which is being called from get_server_ip() L104 [1].\n\nThis was added in https://review.openstack.org/#/c/421724/15.\n\nI think it will be good to add a note or comment so that we can get to know the reason of skipping this tests based on \npublic_network_id. \n\n[1] https://github.com/openstack/tempest/blob/5aeb551a58078abd34884583ac70ad425f4590ba/tempest/scenario/manager.py#L850","commit_id":"95f82c4cf83807c314f66495b8ab0c9c86fe91d1"}]}