)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"88e9e5c38e36ee92f5bb1780113f94bab6179543","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"correct port_security behavior when enabled/disabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will address the flowing:"},{"line_number":10,"context_line":" * sync tempest port_security conf with neutron\u0027s default."},{"line_number":11,"context_line":" * Correct behavior when port_security is False or extension"},{"line_number":12,"context_line":"   not available, do not create port_security resources."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_58975d3a","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":37},"updated":"2018-07-05 16:41:17.000000000","message":"is it following?","commit_id":"0d5029c26e2006b94d139935b063459159e77000"}],"tempest/scenario/manager.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"7c7d1bbc2896bcc9e2c67cecd8fec7a608a35d95","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if kwargs:"},{"line_number":158,"context_line":"                # Convert security group names to security group ids"},{"line_number":159,"context_line":"                # to pass to create_port"},{"line_number":160,"context_line":"                if kwargs[\u0027security_groups\u0027]:"},{"line_number":161,"context_line":"                    security_groups \u003d \\"},{"line_number":162,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":163,"context_line":"                        ).get(\u0027security_groups\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_f582efa4","line":160,"range":{"start_line":160,"start_character":16,"end_line":160,"end_character":45},"updated":"2018-07-05 17:04:24.000000000","message":"I think better approach is \"if \u0027security_groups\u0027 in kwargs:\"\nModified approach can lead to exception if \"security_groups\" will not be available in kwargs.\n\nE.g.\nCase: When \"security_groups\" exist in kwargs, this is fine.\nkwargs\u003d{\u0027security_groups\u0027: \u0027exist\u0027}\nif kwargs[\u0027security_groups\u0027]:\n     print(\"existing\")\n\nOutput: existing\n\nCase: When \"security_groups\" doesn\u0027t exist in kwargs, lead to exception.\nkwargs\u003d{\u0027no_security_groups\u0027: \u0027test\u0027}\nif kwargs[\u0027security_groups\u0027]:\n     print(\"existing\")\n\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nKeyError: \u0027security_groups\u0027","commit_id":"0d5029c26e2006b94d139935b063459159e77000"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"0c95b5859aa9d4a6611042bb0a1dacb390990c99","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if kwargs:"},{"line_number":158,"context_line":"                # Convert security group names to security group ids"},{"line_number":159,"context_line":"                # to pass to create_port"},{"line_number":160,"context_line":"                if \u0027security_groups\u0027in kwargs and kwargs[\u0027security_groups\u0027]:"},{"line_number":161,"context_line":"                    security_groups \u003d \\"},{"line_number":162,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":163,"context_line":"                        ).get(\u0027security_groups\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_cc214afe","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":75},"updated":"2018-07-08 05:21:25.000000000","message":"I don\u0027t see any relevancy of using \"kwargs[\u0027security_groups\u0027]\" as you already used \"\u0027security_groups\u0027in kwargs\".\nIs there any specific purpose of using it?","commit_id":"379e928c0bdd23ba9341589fbee8e6c2a58dcb54"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"9d192616c4cf7e473be513fa9865fb38b06ae8ff","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if kwargs:"},{"line_number":158,"context_line":"                # Convert security group names to security group ids"},{"line_number":159,"context_line":"                # to pass to create_port"},{"line_number":160,"context_line":"                if \u0027security_groups\u0027in kwargs and kwargs[\u0027security_groups\u0027]:"},{"line_number":161,"context_line":"                    security_groups \u003d \\"},{"line_number":162,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":163,"context_line":"                        ).get(\u0027security_groups\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_ec3526f7","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":75},"in_reply_to":"5f7c97a3_2cbd5e67","updated":"2018-07-08 07:22:57.000000000","message":"Where I can check for the skip if list is empty?","commit_id":"379e928c0bdd23ba9341589fbee8e6c2a58dcb54"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"3fe8fbb656fdd7c9557128ac29474c95eea245bd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if kwargs:"},{"line_number":158,"context_line":"                # Convert security group names to security group ids"},{"line_number":159,"context_line":"                # to pass to create_port"},{"line_number":160,"context_line":"                if \u0027security_groups\u0027in kwargs and kwargs[\u0027security_groups\u0027]:"},{"line_number":161,"context_line":"                    security_groups \u003d \\"},{"line_number":162,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":163,"context_line":"                        ).get(\u0027security_groups\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_2cbd5e67","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":75},"in_reply_to":"5f7c97a3_cc214afe","updated":"2018-07-08 06:20:34.000000000","message":"yes as the default right now is to init to empty, so you will have a key with empty list. i added a \"skip\" if list empty","commit_id":"379e928c0bdd23ba9341589fbee8e6c2a58dcb54"}]}