)]}'
{"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b8976a789a50e45cbf6f29afad98a74f6345ae83","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertIn(\u0027available\u0027, body[\u0027status\u0027])"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _is_true(self, val):"},{"line_number":144,"context_line":"        if val in [\u0027true\u0027, \u0027True\u0027, True]:"},{"line_number":145,"context_line":"            return True"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BtKs%3D","line":144,"updated":"2013-11-21 10:08:21.000000000","message":"How about\n\n return val in [\u0027true\u0027, \u0027True\u0027, True]\n?","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fb8c8d5fe97035886063899721100c880241a78f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertIn(\u0027available\u0027, body[\u0027status\u0027])"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _is_true(self, val):"},{"line_number":144,"context_line":"        if val in [\u0027true\u0027, \u0027True\u0027, True]:"},{"line_number":145,"context_line":"            return True"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BdOI%3D","line":144,"in_reply_to":"AAAATn%2F%2BgwI%3D","updated":"2013-11-25 21:04:11.000000000","message":"The code, which Masayuki showed, returns a bool value like the following:\n\n \u003e\u003e\u003e val \u003d \"true\"\n \u003e\u003e\u003e print val in [\"true\", \"True\", True]\n True\n \u003e\u003e\u003e","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"},{"author":{"_account_id":8286,"name":"zhangyanzi","email":"yanzi.zhang@samsung.com","username":"zhangyanzi"},"change_message_id":"821afcaeef8f04f04725bc10b896331cc561841e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertIn(\u0027available\u0027, body[\u0027status\u0027])"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _is_true(self, val):"},{"line_number":144,"context_line":"        if val in [\u0027true\u0027, \u0027True\u0027, True]:"},{"line_number":145,"context_line":"            return True"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BgwI%3D","line":144,"in_reply_to":"AAAATn%2F%2BtKs%3D","updated":"2013-11-25 10:07:41.000000000","message":"Hi Masayuki :\nBecause the return value should be compared with bool, so it returned a bool value.","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b8976a789a50e45cbf6f29afad98a74f6345ae83","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Get Volume information"},{"line_number":158,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume[\u0027id\u0027])"},{"line_number":159,"context_line":"        bool_flag \u003d self._is_true(fetched_volume[\u0027metadata\u0027][\u0027readonly\u0027])"},{"line_number":160,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":161,"context_line":"        self.assertEqual(True, bool_flag)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BtI0%3D","line":159,"updated":"2013-11-21 10:08:21.000000000","message":"Just a question.\nWhy do we need \u0027_is_true\u0027 method?\nI think this return value should be determined.","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"},{"author":{"_account_id":8286,"name":"zhangyanzi","email":"yanzi.zhang@samsung.com","username":"zhangyanzi"},"change_message_id":"821afcaeef8f04f04725bc10b896331cc561841e","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Get Volume information"},{"line_number":158,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume[\u0027id\u0027])"},{"line_number":159,"context_line":"        bool_flag \u003d self._is_true(fetched_volume[\u0027metadata\u0027][\u0027readonly\u0027])"},{"line_number":160,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":161,"context_line":"        self.assertEqual(True, bool_flag)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bgw0%3D","line":159,"in_reply_to":"AAAATn%2F%2BtI0%3D","updated":"2013-11-25 10:07:41.000000000","message":"Because the \u0027fetched_volume[\u0027metadata\u0027][\u0027readonly\u0027]\u0027 is string.\nShould be converted to bool.","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b8976a789a50e45cbf6f29afad98a74f6345ae83","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # Get Volume information"},{"line_number":170,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume[\u0027id\u0027])"},{"line_number":171,"context_line":"        bool_flag \u003d self._is_true(fetched_volume[\u0027metadata\u0027][\u0027readonly\u0027])"},{"line_number":172,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":173,"context_line":"        self.assertEqual(False, bool_flag)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BtIw%3D","line":171,"updated":"2013-11-21 10:08:21.000000000","message":"ditto","commit_id":"4e8930f1e33655ac279bbfbc9461b1efd222e61b"}]}