)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2281e5d007aa01fc1c875ec5701856d99fc9273","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test case uses \u0027network\u0027 as a query parameter, but this is"},{"line_number":10,"context_line":"an invalid parameter. In before, the test passed because neutron"},{"line_number":11,"context_line":"server ignored this parameter. However, neutron is not going to"},{"line_number":12,"context_line":"ignore invalid inputs anymore. This patch replaces \u0027network\u0027 with"},{"line_number":13,"context_line":"\u0027floating_network_id\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iad1c82bf85167498deaf731f048e29060558a95c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_9f8e8d77","line":12,"range":{"start_line":11,"start_character":31,"end_line":12,"end_character":30},"updated":"2018-06-19 09:54:01.000000000","message":"Please provide more information about this change. Ignoring the invalid input was 200 till now. is it going to change to 400? and is not backward incompatible change ? even though it fix the wrong usage of query param.","commit_id":"de9a98acbe3fa8cc693d0547b87a812eb505e880"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2e4639380b5a3da9ff4b04298ca67c59124dbd73","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test case uses \u0027network\u0027 as a query parameter, but this is"},{"line_number":10,"context_line":"an invalid parameter. In before, the test passed because neutron"},{"line_number":11,"context_line":"server ignored this parameter. However, neutron is not going to"},{"line_number":12,"context_line":"ignore invalid inputs anymore. This patch replaces \u0027network\u0027 with"},{"line_number":13,"context_line":"\u0027floating_network_id\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iad1c82bf85167498deaf731f048e29060558a95c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_12d78124","line":12,"range":{"start_line":11,"start_character":31,"end_line":12,"end_character":30},"in_reply_to":"5f7c97a3_9f8e8d77","updated":"2018-06-22 14:38:17.000000000","message":"Done","commit_id":"de9a98acbe3fa8cc693d0547b87a812eb505e880"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6d3cdc1632b97c0bbf82c550370c8ded4490f5aa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"an invalid parameter. In before, the test passed because neutron"},{"line_number":11,"context_line":"server ignored this parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, neutron is planing to employ a strict validation validation"},{"line_number":14,"context_line":"against filter parameters [1]. The motivation is to algin with the"},{"line_number":15,"context_line":"OpenStack API guideline [2]. In particular, the API guideline"},{"line_number":16,"context_line":"mentioned the following:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_9907e9c9","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":68},"updated":"2018-06-27 07:41:18.000000000","message":"nit: unnecessary \"validation\" anyways","commit_id":"2475b8c480535035561ba454c578edfdcb3a5e89"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"7146b4449a23ff1d4dd80ac895251f07af8bc696","unresolved":false,"context_lines":[{"line_number":11,"context_line":"server ignored this parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, neutron is planing to employ a strict validation validation"},{"line_number":14,"context_line":"against filter parameters [1]. The motivation is to algin with the"},{"line_number":15,"context_line":"OpenStack API guideline [2]. In particular, the API guideline"},{"line_number":16,"context_line":"mentioned the following:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_a90037b3","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":57},"updated":"2018-06-28 05:03:00.000000000","message":"nit: s/algin/align/g","commit_id":"2475b8c480535035561ba454c578edfdcb3a5e89"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a659c455cccf2351f022220a2aaaad08c31f5828","unresolved":false,"context_lines":[{"line_number":32,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1749820"},{"line_number":33,"context_line":"[2] http://specs.openstack.org/openstack/api-wg/guidelines/http/"},{"line_number":34,"context_line":"    response-codes.html#failure-code-clarifications"},{"line_number":35,"context_line":"[3] http://eavesdrop.openstack.org/meetings/api_sig/2018/"},{"line_number":36,"context_line":"    api_sig.2018-03-15-16.00.log.html#l-120"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Change-Id: Iad1c82bf85167498deaf731f048e29060558a95c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_cc76e1a4","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":43},"updated":"2018-06-28 05:40:25.000000000","message":"from discussion, i understood that neutron will introduce this behavior with extensions and you mentioned above that neutron will control the old behaviour with config option. Is there any document or something to know the neutron final decision?\n\nAs old behaviour can be supported by neutron, i am ok to change the tests to move to new behaviour.","commit_id":"2475b8c480535035561ba454c578edfdcb3a5e89"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1d65e4bd626f9fad4d9a91d0c30e0ba8441f63d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"an invalid parameter. In before, the test passed because neutron"},{"line_number":11,"context_line":"server ignored this parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, neutron is planing to employ a strict validation validation"},{"line_number":14,"context_line":"against filter parameters [1]. The motivation is to algin with the"},{"line_number":15,"context_line":"OpenStack API guideline [2]. In particular, the API guideline"},{"line_number":16,"context_line":"mentioned the following:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_771e4860","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":68},"updated":"2018-06-29 21:59:04.000000000","message":"nit: validation","commit_id":"074b5a397157444a46f63a3d0879c90f56f0f29a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1d65e4bd626f9fad4d9a91d0c30e0ba8441f63d2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"server ignored this parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, neutron is planing to employ a strict validation validation"},{"line_number":14,"context_line":"against filter parameters [1]. The motivation is to algin with the"},{"line_number":15,"context_line":"OpenStack API guideline [2]. In particular, the API guideline"},{"line_number":16,"context_line":"mentioned the following:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_3738d0d2","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":57},"updated":"2018-06-29 21:59:04.000000000","message":"align","commit_id":"074b5a397157444a46f63a3d0879c90f56f0f29a"}],"tempest/api/network/admin/test_external_network_extension.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d09365d528ee0817b3152ac4d58a03e0ae4e8568","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":119,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":120,"context_line":"        floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":121,"context_line":"            floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":122,"context_line":"        self.assertIn(created_floating_ip[\u0027id\u0027],"},{"line_number":123,"context_line":"                      (f[\u0027id\u0027] for f in floatingip_list[\u0027floatingips\u0027]))"},{"line_number":124,"context_line":"        self.admin_networks_client.delete_network(external_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e6638718","line":121,"updated":"2018-06-19 00:06:26.000000000","message":"Looks consistent wit https://developer.openstack.org/api-ref/network/v2/#list-floating-ips","commit_id":"de9a98acbe3fa8cc693d0547b87a812eb505e880"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6d3cdc1632b97c0bbf82c550370c8ded4490f5aa","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":119,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":120,"context_line":"        floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":121,"context_line":"            floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":122,"context_line":"        self.assertIn(created_floating_ip[\u0027id\u0027],"},{"line_number":123,"context_line":"                      (f[\u0027id\u0027] for f in floatingip_list[\u0027floatingips\u0027]))"},{"line_number":124,"context_line":"        self.admin_networks_client.delete_network(external_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b9c42561","line":121,"updated":"2018-06-27 07:41:18.000000000","message":"According to https://developer.openstack.org/api-ref/network/v2/#list-floating-ips this change seems valid because of nonexistent \"network\" parameter.\n\nBTW the original test just got all floating ips by ignoring the specified parameter and the following assertIn could pass.\nSo maybe it is nice to have another check to verify the valid parameter works fine. But it should be out of scope from this patch anyways.","commit_id":"2475b8c480535035561ba454c578edfdcb3a5e89"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3460279d957cf469fd7e91f5ddfb8a1e29a32b0b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_cb50cb2f","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"updated":"2018-07-02 01:20:10.000000000","message":"as you mentioned, neutron will perform validation based on both 1. extension and 2. config option. in that case we need to check the config options also.\n\nAlso it will fail as neutron changes are not merged yet. It will not find this extension in current build and try to check the old param which will block you neutron change. \n\nWe have procedure to handle such cases. \n1. Propose change to the project, get a +2 on the change even with failing\n2. Propose skip on Tempest which will only be approved after the\n  corresponding change in the project has a +2 on change\n3. Land project change in master and all open stable branches (if required)\n4. Land changed test in Tempest\n\nSection 2. Bug fix on core project needing Tempest changes: in \nhttps://docs.openstack.org/tempest/latest/HACKING.html#branchless-tempest-considerations","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"519763c8273740fd7769d8f3dfa0165336778a13","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6dae27e5","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_1f6fab29","updated":"2018-07-17 15:45:58.000000000","message":"Please clarify why this patch needs to go through the lengthy process. Going thorough the procedure will delay the review process and making us miss the Rocky deadline, so I would like to understand the rationale behind this request.\n\nPlease note that this is a simple bug fixes in tempest to fix its incorrect API usage. It really shouldn\u0027t have anything to do with the neutron\u0027s side implementation. This patch is still valid even if the proposal is eventually rejected on the neutron side.\n\nIn addition, please note that there are a bunch of patches on neutron side that depends on this fix. All of them are targeted for Rocky. If this patch cannot merge before the FF next week, the important neutron feature would have to be delayed for 6 months, which is very costy.\n\nI also saw this patch has already got two +2 and a +1 from neutron liaison. I prefer to merge this patch as is and discuss the backward-compatibility in the follow-up patch: https://review.openstack.org/#/c/583284/","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"57eb3519b40c643aa2660fcff46b33a9e16e8a82","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1f6fab29","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_21a4f206","updated":"2018-07-17 04:56:02.000000000","message":"Thanks for updates. Yeah extensions name looks ok now but we need implementation on neutron side which actually fix this bug. For that, we need to go with the bug fix process i mentioned earlier. \n\nSame way you are doing in  - https://review.openstack.org/#/c/575550/","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19f4405a45bff90613a17ac131c5c9104fbbdb20","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c2d63327","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_39e72712","updated":"2018-07-04 10:00:53.000000000","message":"You means, \n- if config options is false then, extensions can not enabled (as it is not available) so new API validation is disabled. \n- If config options is True, extensions can be enabled or disabled. \n\nIf so, i really do not understand the use case of that config options. cloud provider/administrator can enable and disable the extensions directly. \n\n\nRE on using neutron config: In these cases, we add corresponding config option in Tempest conf and then use it in tests. For example [1] \n\n[1] - https://github.com/openstack/tempest/blob/634bdf206b75336f0c97f7358323d3d7678c7a6a/tempest/config.py#L666\n\nRE on Tempest process:\nIt will pass but Tempest does not know what will be new extension name \u0027filter-validation\u0027 or will it be final approach or not. That is the reason we need to follow the process to avoid tests change on each time neutron change extension name etc. \n\nOnce your neutron patch is merged and we know \u0027filter-validation\u0027 is the right extensions tests should check then, we merge this fix but till than test can be skipped (with +2 on neutron proposal).","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"183a07c55c8f5db938cad8ab1af28669705a084a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6fb851e7","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_6dae27e5","updated":"2018-07-18 01:49:03.000000000","message":"\u003ePlease clarify why this patch needs to go through the lengthy process. \n\nThat is the process of fixing the bug which are backward incompatible way. If we do not need to follow the process then what is point of testing the backward incompatibility. This process is all about - \"How QA know what is accepted changes on project side and how project can tell QA to move forward to pass the tests testing the behaviour change\" \n\n\u003ePlease note that this is a simple bug fixes in tempest to fix its incorrect API usage. It really shouldn\u0027t have anything to do with the neutron\u0027s side implementation. \n\nThis is not simple bug though :). This is backward incompatible change even that correcting the incorrect usage of API. And it depends on neutron implementation only. Neutron going to 400 for invalid parameter after neutron implementation only otherwise why the original tests failing on neutron side. \n \nAnd I do not understand why this process is lengthy. \n- You get +2 on neutron side implementation - this is usual neutron time for their changes review. (They can give +2 on zuul -1 also and you mention there this is as per QA process)\n- push patch in tempest to skip the tests - we merge that patch in tempest immediately once neutron single core is +2 on neutron side patch.  This is done during your neutron changes are under review. \n- Neutron change pass and you merge them.\n- later any time we unskip the tempest tests with test modification. \n\n\u003eI also saw this patch has already got two +2 and a +1 from neutron liaison.\n\nThat is ok but key thing matter is we follow the process which is very simple and easy to do.","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3a75b8ad195a27f7ccf439c925c1f1d5fddbe5ab","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b7e4290c","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_6fb851e7","updated":"2018-07-21 13:16:33.000000000","message":"It looks the second point is not the reality.\n\nRight now, the neutron patch (https://review.openstack.org/#/c/574907/) got +2/+W but the tempest patch for skipping tests (https://review.openstack.org/#/c/583441/) are not merged immediately.","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6244b06cc6580453e5bde622d3321572dab17e39","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_21a4f206","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_c2d63327","updated":"2018-07-15 04:20:54.000000000","message":"The patch in neutron-lib is merged: https://review.openstack.org/#/c/580190/ . Based on that, we should know \u0027filter-validation\u0027 is the right extensions the tests should check. Your comment about whether \u0027filter-validation\u0027 is the final approach is addressed. Would it be enough to refresh your vote?","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8fc9e09e2e80a64c3b4c4e0197197e161c957c16","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0260ab34","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_c2d63327","updated":"2018-07-04 10:07:55.000000000","message":"got the use case of config options from your neutron change[1]. I again forget the neutron support of plugin + extensions. You are right about having the need of config options for plugins.  \n\nSo in that case (as per below propose code), extensions enable/disable is enough here. \n\n- https://review.openstack.org/#/c/574907/9/neutron/extensions/filter_validation.py\n\n[1] https://review.openstack.org/#/c/574907/","commit_id":"1733f44adb928669f30132ca747696623c65cc05"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"0f838fdb01e3e1a4f7f25e4d5ee588e3eaee54cd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":119,"context_line":"                        self.admin_floating_ips_client.delete_floatingip,"},{"line_number":120,"context_line":"                        created_floating_ip[\u0027id\u0027])"},{"line_number":121,"context_line":"        if utils.is_extension_enabled(\u0027filter-validation\u0027, \u0027network\u0027):"},{"line_number":122,"context_line":"            floatingip_list \u003d self.admin_floating_ips_client.list_floatingips("},{"line_number":123,"context_line":"                floating_network_id\u003dexternal_network[\u0027id\u0027])"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_39e72712","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":70},"in_reply_to":"5f7c97a3_cb50cb2f","updated":"2018-07-04 01:20:33.000000000","message":"Neutron will perform validation based on extension only. The config option is for controlling the present of the extension.\n\nI am not exactly sure what do you mean by \"check the config options\" though. It seems to be technically impossible for an API test suite to check the neutron config file in the control plane.\n\nThe test result [1] proved that everything is fine even if the neutron changes are not merged. I guess we don\u0027t have to go through the procedure in this case.\n\n[1] https://review.openstack.org/#/c/579903/","commit_id":"1733f44adb928669f30132ca747696623c65cc05"}]}