)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d8f35afcae3ccf171cb1a93d674f714603844793","unresolved":false,"context_lines":[{"line_number":12,"context_line":"If tempest.conf file doesn\u0027t exist on default location"},{"line_number":13,"context_line":"then command was failing."},{"line_number":14,"context_line":"It never used the config file value from command line."},{"line_number":15,"context_line":"Command was running successfully only when running from tempest "},{"line_number":16,"context_line":"directory or tempest.conf exist in current directory"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic8dcaff920e5cdfb9a9457ff3a3137c225622409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_a62386aa","line":15,"updated":"2018-06-28 03:15:40.000000000","message":"very nit: trailing whitespace","commit_id":"ec6974c6952315df56387c0a891d2ddb211c4c58"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81a363f76f958c8d84c2f0de4ef761badb5e2a40","unresolved":false,"context_lines":[{"line_number":14,"context_line":"It never used the config file value from command line."},{"line_number":15,"context_line":"Command was running successfully only when running from tempest"},{"line_number":16,"context_line":"directory or tempest.conf exist in current directory"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic8dcaff920e5cdfb9a9457ff3a3137c225622409"},{"line_number":19,"context_line":"Closes-Bug: #1766354"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3f79a3b5_b845ca19","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"updated":"2018-08-07 06:35:38.000000000","message":"also add below BP link for tracking\n\n\nPartially-Implements: blueprint tempest-cli-unit-test-coverage","commit_id":"d1832d03138287f9fa92678d6e78dd1a0ba8c464"}],"tempest/cmd/account_generator.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d8f35afcae3ccf171cb1a93d674f714603844793","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    setup_logging()"},{"line_number":297,"context_line":"    if not opts:"},{"line_number":298,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c6280287","side":"PARENT","line":299,"updated":"2018-06-28 03:15:40.000000000","message":"Can you put this deprecation log to after the setup_loggin() at least?","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b2126c69b904e1e63d602216395d71339f1e7928","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    setup_logging()"},{"line_number":297,"context_line":"    if not opts:"},{"line_number":298,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b1e06299","side":"PARENT","line":299,"updated":"2018-07-02 05:00:06.000000000","message":"Yeah, it\u0027s been a long time. But I guess users just get confused if it will be just removed. So, it might be better to keep this message if there\u0027s no particular reason.","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"48ba5cbe1174bb35b60b83fa741ae7162c1cca33","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    setup_logging()"},{"line_number":297,"context_line":"    if not opts:"},{"line_number":298,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_678b0c1e","side":"PARENT","line":299,"in_reply_to":"5f7c97a3_c6280287","updated":"2018-06-29 05:20:26.000000000","message":"As this is deprecated from long time, so isn\u0027t it ok to remove? Please suggest your opinion else it can be move below after setup_logging()","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b2126c69b904e1e63d602216395d71339f1e7928","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"},{"line_number":303,"context_line":"    if opts.os_tenant_name:"},{"line_number":304,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":305,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d1db9ee7","side":"PARENT","line":302,"updated":"2018-07-02 05:00:06.000000000","message":"I meant like this\n\n  def main(opts\u003dNone):\n    if opts.config_file:\n      config.CONF.set_config_path(opts.config_file)\n    setup_logging()\n    if not opts:\n      LOG.warning(\"....\")\n      opts \u003d get_options()\n    :","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d8f35afcae3ccf171cb1a93d674f714603844793","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"},{"line_number":303,"context_line":"    if opts.os_tenant_name:"},{"line_number":304,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":305,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_661d6e61","side":"PARENT","line":302,"updated":"2018-06-28 03:15:40.000000000","message":"Or how about moving this section to just before setup_loggin()?","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"48ba5cbe1174bb35b60b83fa741ae7162c1cca33","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"},{"line_number":303,"context_line":"    if opts.os_tenant_name:"},{"line_number":304,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":305,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_87d668f2","side":"PARENT","line":302,"in_reply_to":"5f7c97a3_661d6e61","updated":"2018-06-29 05:20:26.000000000","message":"If Log.Warning will be move before setup_loggin(), then We can\u0027t call Log.Warning as logging is setup in setup_loggin()","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81705c41d9670073b58b787486d4423aa8b0457e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"def main(opts\u003dNone):"},{"line_number":296,"context_line":"    setup_logging()"},{"line_number":297,"context_line":"    if not opts:"},{"line_number":298,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":299,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":300,"context_line":"        opts \u003d get_options()"},{"line_number":301,"context_line":"    if opts.config_file:"},{"line_number":302,"context_line":"        config.CONF.set_config_path(opts.config_file)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_1ddf253a","side":"PARENT","line":299,"range":{"start_line":298,"start_character":0,"end_line":299,"end_character":62},"updated":"2018-08-03 07:47:13.000000000","message":"we need to keep this warning as old cli is still there. i understand if we use it like here then setting self._path issue occur again.\n\nso let\u0027s set a variable to True if not opts and then log warning after config path set like below:\n    log_warning \u003d False\n    if not opts:\n        log_warning \u003d True\n        opts \u003d get_options()\n    if opts.config_file:\n        config.CONF.set_config_path(opts.config_file)\n    setup_logging()\n    if log_warning:\n        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \"\n                    \"please use: \u0027tempest account-generator\u0027\")","commit_id":"91e88523c55b28423da8763bd0c944f542248d97"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"723130d3f14b63df6ca57bdd43e6741415cd4631","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    setup_logging()"},{"line_number":303,"context_line":"    if log_warning:"},{"line_number":304,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":305,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":306,"context_line":"    if opts.os_tenant_name:"},{"line_number":307,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":308,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_2da23340","line":305,"updated":"2018-09-20 07:24:58.000000000","message":"If you want to remove this warning, I think we can remove this with adding a reno. But I think it should be a different patch not this.","commit_id":"b26222566fe005fb74f25ff8528d25338b1190e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01420d1d851497e3006f7416e4f17fee5558184b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    setup_logging()"},{"line_number":303,"context_line":"    if log_warning:"},{"line_number":304,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":305,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":306,"context_line":"    if opts.os_tenant_name:"},{"line_number":307,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":308,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_6df34ba0","line":305,"in_reply_to":"3f79a3b5_18c5335c","updated":"2018-10-03 02:10:34.000000000","message":"I do not think we should remove this warning. removing this warning means we are bringing back the old CLI entry point which were deprecated. \n\nWe need to keep this and at some point, remove those old entry points but not sure when.","commit_id":"b26222566fe005fb74f25ff8528d25338b1190e0"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"c8f9a08a3cccf6642cf39518eec6afc9cbf19166","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    setup_logging()"},{"line_number":303,"context_line":"    if log_warning:"},{"line_number":304,"context_line":"        LOG.warning(\"Use of: \u0027tempest-account-generator\u0027 is deprecated, \""},{"line_number":305,"context_line":"                    \"please use: \u0027tempest account-generator\u0027\")"},{"line_number":306,"context_line":"    if opts.os_tenant_name:"},{"line_number":307,"context_line":"        LOG.warning(\"\u0027os-tenant-name\u0027 and \u0027OS_TENANT_NAME\u0027 are both \""},{"line_number":308,"context_line":"                    \"deprecated, please use \u0027os-project-name\u0027 or \""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_18c5335c","line":305,"in_reply_to":"3f79a3b5_2da23340","updated":"2018-09-20 07:31:54.000000000","message":"Sure, will remove in next PS.","commit_id":"b26222566fe005fb74f25ff8528d25338b1190e0"}],"tempest/tests/cmd/test_account_generator.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cb22d7fc1e55d146654fda0874fa01074fab4b88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import fixtures"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from tempest.cmd import account_generator"},{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest.tests import base"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_045464fd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":27},"updated":"2018-07-02 16:24:41.000000000","message":"nit: This should be included among the imports above, not with Tempest imports. https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"c55149cdc24d8803ada67d72b5f38a0ad41a74da"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cb22d7fc1e55d146654fda0874fa01074fab4b88","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027,"},{"line_number":118,"context_line":"                                   self.DEFAULT_CONFIG_FILE)"},{"line_number":119,"context_line":"        path \u003d os.path.join(conf_dir, conf_file)"},{"line_number":120,"context_line":"        self.opts.config_file \u003d \u0027%s\u0027 % path"},{"line_number":121,"context_line":"        self.opts.admin \u003d True"},{"line_number":122,"context_line":"        account_generator.CONF.set_config_path(path)"},{"line_number":123,"context_line":"        self.assertTrue(account_generator.CONF._path)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6484385e","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":30},"updated":"2018-07-02 16:24:41.000000000","message":"nit: Do these need to be set? I don\u0027t see self.opts being passed in anywhere in this test.","commit_id":"c55149cdc24d8803ada67d72b5f38a0ad41a74da"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"0a5516ba2c44a979fb7d66e93a99b2c9918ad43d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        admin_creds \u003d cp.default_admin_creds"},{"line_number":111,"context_line":"        self.assertEqual(self.opts.os_tenant_name, admin_creds.tenant_name)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_account_genrator_config_file_path_set(self):"},{"line_number":114,"context_line":"        self.DEFAULT_CONFIG_DIR \u003d os.path.join(os.getcwd(), \"etc\")"},{"line_number":115,"context_line":"        self.DEFAULT_CONFIG_FILE \u003d \"tempest.conf\""},{"line_number":116,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_643e4fba","line":113,"updated":"2018-07-04 08:18:25.000000000","message":"s/genrator/generator","commit_id":"bd7e6701be657650f2b2daf9fc5546861e635ada"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"0a5516ba2c44a979fb7d66e93a99b2c9918ad43d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        account_generator.CONF.set_config_path(path)"},{"line_number":124,"context_line":"        self.assertTrue(account_generator.CONF._path)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_account_genrator_config_file_path_notset(self):"},{"line_number":127,"context_line":"        account_generator.CONF.set_config_path(\"\")"},{"line_number":128,"context_line":"        self.assertFalse(account_generator.CONF._path)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4441d335","line":126,"updated":"2018-07-04 08:18:25.000000000","message":"ditto","commit_id":"bd7e6701be657650f2b2daf9fc5546861e635ada"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81705c41d9670073b58b787486d4423aa8b0457e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def test_account_generator_config_file_path_notset(self):"},{"line_number":127,"context_line":"        account_generator.CONF.set_config_path(\"\")"},{"line_number":128,"context_line":"        self.assertFalse(account_generator.CONF._path)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class TestAccountGeneratorV3(TestAccountGeneratorV2):"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_dd6f6d5f","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":0},"updated":"2018-08-03 07:47:13.000000000","message":"these test case are not enough to capture the regressions. i want to have one positive and one negative test case at least where we can check passing the non default config path by --config-path arg and test case gets the credential set on this dummy non default config file.","commit_id":"f9165549730bc005557f8bd5e317838ba4da0202"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"545c461388bb6b969e3c0f155aeaf8cd5c880f2b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_926a82b2","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"updated":"2018-10-03 00:02:29.000000000","message":"This should be included on L21 actually","commit_id":"15659d885d6014f48a8d22024b6d4bafe979de1e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3c53fb93dc99bfca4cea4a34fb30c05dbfb1f4cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_ec40c861","line":18,"updated":"2018-10-02 17:37:54.000000000","message":"unnecessary blank line in the same 3rd party python libraries.","commit_id":"15659d885d6014f48a8d22024b6d4bafe979de1e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7a60ef20545ff7a8f83fb238b27cf17349bbb2a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import fixtures"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from tempest.cmd import account_generator"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest.tests import base"},{"line_number":23,"context_line":"from tempest.tests import fake_config"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_05614b39","line":20,"range":{"start_line":19,"start_character":23,"end_line":20,"end_character":41},"updated":"2018-10-03 07:18:03.000000000","message":"we need line break here as these are repo import and 3rd party import\n\nsuggestion on import ordering- \n- https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"8080011ad1284752df4e0aa20a512b9f35995281"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"74dd259d3951d20c66193b099dd91735e82b1de4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertEqual(self.opts.os_tenant_name, admin_creds.tenant_name)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_account_generator_config_file_path_set(self):"},{"line_number":113,"context_line":"        os.environ[\"TEMPEST_CONFIG_DIR\"] \u003d os.path.join(os.getcwd(), \"etc\")"},{"line_number":114,"context_line":"        os.environ[\"TEMPEST_CONFIG\"] \u003d \"tempest.conf\""},{"line_number":115,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027)"},{"line_number":116,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027)"},{"line_number":117,"context_line":"        path \u003d os.path.join(conf_dir, conf_file)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_32af75e1","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":53},"updated":"2018-10-09 06:09:46.000000000","message":"these can leads to bug 1796073. we need to use mocking here","commit_id":"ea95081bdc1138ae8e35cd29067f7fd741c0fe9d"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"a6aef6e53059027735e42204acf710712f411bc7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertEqual(self.opts.os_tenant_name, admin_creds.tenant_name)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_account_generator_config_file_path_set(self):"},{"line_number":113,"context_line":"        os.environ[\"TEMPEST_CONFIG_DIR\"] \u003d os.path.join(os.getcwd(), \"etc\")"},{"line_number":114,"context_line":"        os.environ[\"TEMPEST_CONFIG\"] \u003d \"tempest.conf\""},{"line_number":115,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027)"},{"line_number":116,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027)"},{"line_number":117,"context_line":"        path \u003d os.path.join(conf_dir, conf_file)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_5bfe146b","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":53},"in_reply_to":"3f79a3b5_32af75e1","updated":"2018-10-17 12:28:21.000000000","message":"Done","commit_id":"ea95081bdc1138ae8e35cd29067f7fd741c0fe9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"74dd259d3951d20c66193b099dd91735e82b1de4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        account_generator.CONF.set_config_path(path)"},{"line_number":121,"context_line":"        self.assertTrue(account_generator.CONF._path)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_account_generator_config_file_path_notset(self):"},{"line_number":124,"context_line":"        account_generator.CONF.set_config_path(\"\")"},{"line_number":125,"context_line":"        self.assertFalse(account_generator.CONF._path)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TestAccountGeneratorV3(TestAccountGeneratorV2):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_92ee891f","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":54},"updated":"2018-10-09 06:09:46.000000000","message":"this test is failing on py36 job - http://logs.openstack.org/30/577730/17/check/openstack-tox-py36/be21413/testr_results.html.gz","commit_id":"ea95081bdc1138ae8e35cd29067f7fd741c0fe9d"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"a6aef6e53059027735e42204acf710712f411bc7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        account_generator.CONF.set_config_path(path)"},{"line_number":121,"context_line":"        self.assertTrue(account_generator.CONF._path)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_account_generator_config_file_path_notset(self):"},{"line_number":124,"context_line":"        account_generator.CONF.set_config_path(\"\")"},{"line_number":125,"context_line":"        self.assertFalse(account_generator.CONF._path)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TestAccountGeneratorV3(TestAccountGeneratorV2):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_1bf09c92","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":54},"in_reply_to":"3f79a3b5_92ee891f","updated":"2018-10-17 12:28:21.000000000","message":"Done","commit_id":"ea95081bdc1138ae8e35cd29067f7fd741c0fe9d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"91b3cb4a237a260c0c28bf75b533c32b7d77e3ea","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get,"},{"line_number":126,"context_line":"                        autospec\u003dTrue):"},{"line_number":127,"context_line":"            account_generator.CONF.set_config_path(path)"},{"line_number":128,"context_line":"            self.assertTrue(account_generator.CONF._path)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_account_generator_config_file_path_notset(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_c963e5dd","line":127,"range":{"start_line":127,"start_character":12,"end_line":127,"end_character":56},"updated":"2018-11-03 13:43:05.000000000","message":"Why not call account_generator.main here instead? This is not calling the entrypoint where you made the fix.","commit_id":"ccc97239db393d88a4cbd5b82850f78642e7e5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"229dbb929c10ff9756f14a40113cc511a4ca7846","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get,"},{"line_number":126,"context_line":"                        autospec\u003dTrue):"},{"line_number":127,"context_line":"            account_generator.CONF.set_config_path(path)"},{"line_number":128,"context_line":"            self.assertTrue(account_generator.CONF._path)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_account_generator_config_file_path_notset(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_2ab7b9d9","line":127,"range":{"start_line":127,"start_character":12,"end_line":127,"end_character":56},"in_reply_to":"3f79a3b5_c963e5dd","updated":"2018-11-22 09:15:59.000000000","message":"+1, I too prefer to call the outermost function and check behaviour in most inner function.","commit_id":"ccc97239db393d88a4cbd5b82850f78642e7e5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e64d2577f0ce58a58e9530b8f021ba7798fadbf7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get,"},{"line_number":126,"context_line":"                        autospec\u003dTrue):"},{"line_number":127,"context_line":"            account_generator.CONF.set_config_path(path)"},{"line_number":128,"context_line":"            self.assertTrue(account_generator.CONF._path)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_account_generator_config_file_path_notset(self):"},{"line_number":131,"context_line":"        conf_dir \u003d \"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_8a212d00","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":57},"updated":"2018-11-22 09:33:25.000000000","message":"instead of just checking True, can we check the exact path here which we are passing in --config","commit_id":"ccc97239db393d88a4cbd5b82850f78642e7e5d5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"91b3cb4a237a260c0c28bf75b533c32b7d77e3ea","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get,"},{"line_number":144,"context_line":"                        autospec\u003dTrue):"},{"line_number":145,"context_line":"            account_generator.CONF.set_config_path(path)"},{"line_number":146,"context_line":"            self.assertFalse(account_generator.CONF._path)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_e95ee112","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":56},"updated":"2018-11-03 13:43:05.000000000","message":"Ditto.","commit_id":"ccc97239db393d88a4cbd5b82850f78642e7e5d5"}]}